Commit Graph

31847 Commits

Author SHA1 Message Date
Nick French 37b2e68628 res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability
This change implements a few different generic things which were brought
on by Google Voice SIP.

1.  The concept of flow transports have been introduced.  These are
configurable transports in pjsip.conf which can be used to reference a
flow of signaling to a target.  These have runtime configuration that can
be changed by the signaling itself (such as Service-Routes and
P-Preferred-Identity).  When used these guarantee an individual connection
(in the case of TCP or TLS) even if multiple flow transports exist to the
same target.

2.  Service-Routes (RFC 3608) support has been added to the outbound
registration module which when received will be stored on the flow
transport and used for requests referencing it.

3.  P-Associated-URI / P-Preferred-Identity (RFC 3325) support has been
added to the outbound registration module.  If a P-Associated-URI header
is received it will be used on requests as the P-Preferred-Identity.

4.  Configurable outbound extension support has been added to the outbound
registration module.  When set the extension will be placed in the
Supported header.

5.  Header parameters can now be configured on an outbound registration
which will be placed in the Contact header.

6.  Google specific OAuth / Bearer token authentication
(draft-ietf-sipcore-sip-authn-02) has been added to the outbound
registration module.

All functionality changes are controlled by pjsip.conf configuration
options and do not affect non-configured pjsip endpoints otherwise.

ASTERISK-27971 #close

Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58
2018-10-24 07:51:25 -05:00
George Joseph 51b5f0f193 Merge "res_xmpp: Remove deprecated JabberStatus application." 2018-10-24 07:47:58 -05:00
George Joseph eb1b48d514 Merge "app_dial/app_queue: Update application option documentation" 2018-10-24 07:47:19 -05:00
George Joseph 11b73a75c8 Merge "lock: Replace __ast_mutex_logger with private log_mutex_error." 2018-10-24 07:46:11 -05:00
Sean Bright f940b7b63d say: Remove legacy language deprecation logic
These language codes (tw, ge, mx, and cz) were deprecated in 1.6.2.

Change-Id: I18e4d2af2e83556fa91e39a7338030583ef05d50
2018-10-23 08:43:41 -04:00
Sean Bright 9e8d671658 res_xmpp: Remove deprecated JabberStatus application.
Change-Id: I1a00ca22d59d6b6d2166aa56f0e9338a33e5ac60
2018-10-22 11:51:08 -04:00
Richard Mudgett 544ef21bfe Merge "Fix 'statement' typo throughout code." 2018-10-22 10:25:32 -05:00
Richard Mudgett d1b9a3fbcc Merge "options.c: Remove 'internal_timing' notice" 2018-10-22 10:23:45 -05:00
Richard Mudgett 20c1b1a911 Merge "samples: PARKINGSLOT -> PARKING_SPACE in parking sample config" 2018-10-22 10:21:06 -05:00
Corey Farrell 687ab7aeee
astobj2: Eliminate legacy container allocation macros.
These macros have been documented as legacy for a long time but are
still used in new code because they exist.  Remove all references to:
* ao2_container_alloc_options
* ao2_t_container_alloc_options
* ao2_t_container_alloc

These macro's are also removed.  Only ao2_container_alloc remains due to
it's use in over 100 places.

Change-Id: I1a26258b5bf3deb081aaeed11a0baa175c933c7a
2018-10-19 17:33:05 -04:00
Corey Farrell 4c19b94968
lock: Replace __ast_mutex_logger with private log_mutex_error.
__ast_mutex_logger used the variable `canlog` without accepting it as a
argument.  Replace with internal macro `log_mutex_error` which takes
canlog as the first arguement.  This will prevent confusion when working
with lock.c code, many of the function declare the canlog variable and
in some cases it previously appeared to be unused.

Change-Id: I83b372cb0654c5c18eadc512f65a57fa6c2e9853
2018-10-19 12:34:08 -04:00
George Joseph 221d01c32d Merge "taskprocessor: Warn on unused result from pushing task." 2018-10-19 08:39:18 -05:00
George Joseph f71545e7fb Merge "modules: Add missing run time module support levels." 2018-10-19 08:38:15 -05:00
Richard Mudgett 9838a5e57a app_dial/app_queue: Update application option documentation
* Update the post-answer documentation and example.  The Dial example was
incorrect and misleading for the post-answer subroutine useage.

* Fix note and warning paragraphs in option descriptions.  They don't show
up in the wiki.

Change-Id: I81019a1fd75d5b9151f76b52c38e2a90da682d14
2018-10-18 17:23:01 -05:00
Sean Bright 90bd8371f2 samples: PARKINGSLOT -> PARKING_SPACE in parking sample config
PARKINGSLOT was deprecated in Asterisk 12 but the sample config was not
updated to reflect that.

Change-Id: I3e087c19d9ee587094fa5304102d8084a79c2b3c
2018-10-18 14:59:01 -05:00
Sean Bright be04a64c49 options.c: Remove 'internal_timing' notice
Change-Id: I9882394617724a497df1d6f529a87965191be3ce
2018-10-18 15:18:36 -04:00
Richard Mudgett 467f7c6724 Fix 'statement' typo throughout code.
Most were in comments.  A couple were in warning messages.

Pointed out by Jonathan H on the Asterisk users mailing list.

Change-Id: I6286939dff5d0a27a2758140570106f1cb351855
2018-10-18 12:44:10 -05:00
Richard Mudgett 7ab4befc2b res_rtp_asterisk.c: Add conditional module dependency to res_pjproject
* The dependency ensures that res_pjproject cannot be manually unloaded
before res_rtp_asterisk.
* The dependency allows startup loading errors to report that
res_rtp_asterisk depends upon res_pjproject.

Change-Id: Icf5e7581f4ddd6189929f6174c74dd951f887377
2018-10-17 16:13:51 -05:00
Richard Mudgett 1fad6b9079 modules: Add missing run time module support levels.
Change-Id: I29b9dbfa4bbfc49f21eba356858e38b1d3041824
2018-10-17 14:50:54 -05:00
Jenkins2 52e5e09f36 Merge "bundled pjproject: Remove timer cleanup usage patch." 2018-10-17 09:00:43 -05:00
Corey Farrell 5ab94d2a3e
taskprocessor: Warn on unused result from pushing task.
Add attribute_warn_unused_result to ast_taskprocessor_push,
ast_taskprocessor_push_local and ast_threadpool_push.  This will help
ensure we perform the necessary cleanup upon failure.

Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d
2018-10-17 09:14:05 -04:00
George Joseph e349bf40ca Merge "refdebug: Create refstats.py script." 2018-10-16 13:43:07 -05:00
Richard Mudgett 915861b431 bundled pjproject: Remove timer cleanup usage patch.
This patch is not in the upstream pjproject and does unsafe things with
the timer->_timer_id and timer->_grp_lock values in pj_timer_entry_reset()
outside of the timer heap lock.  pj_timer_entry_reset() is also called for
timers that are not about to be rescheduled in a few places.

Change-Id: I4fe0b4bc648f7be5903cf4531b94fc87275713c1
2018-10-16 12:37:42 -05:00
George Joseph 430f97f5e7 Merge "threadpool: Eliminate pointless AO2 usage." 2018-10-16 10:15:28 -05:00
Corey Farrell 79677ead28 refdebug: Create refstats.py script.
This allows us to process AO2 statistics for total objects, memory
usage, memory overhead and lock usage.

* Install refstats.py and reflocks.py into the Asterisk scripts folder.
* Enable support for reflocks.py without DEBUG_THREADS.

Steal a bit from the ao2 magic to flag when an object lock is used.
Remove 'lockobj' from reflocks.py since we can now record 'used' or
'unused' for those objects.

Add comments to explain thread safety of the 'struct __priv_data'
bitfields.

Change-Id: I84e9d679cc86d772cc97c888d9d856a17e0d3a4a
2018-10-15 15:35:35 -05:00
Alexei Gradinari aae5bdc22e res_pjsip: set callerid_tag to empty string
This patch sets the callerid_tag to empty string by default.

If the callerid_tag is set to NULL then the tag does not
become part of a connected line update.
For example:
Alice's tag is "Alice".
Bob's tag is empty.
Charlie's tag is "Charlie".
Alice calls Bob and then does attended transfer to Charlie.
When Alice hangs up the CONNECTEDLINE(tag) is "Alice"
on the interception routine on the Charlie's channel, but should be empty.

Ths patch also fix memory leaks if there are more then one options
"callerid", "callerid_tag", "voicemail_extension" and "contact_user"
in the pjsip.conf endpoint definition.

Change-Id: I86ba455c4677ca8d516d9a04ce7fb4d24dd576e4
2018-10-15 14:17:43 -05:00
George Joseph 5ff42a2bb5 Merge "res_statsd.c: Fix returned reload status." 2018-10-15 11:26:34 -05:00
Corey Farrell f06de6900e threadpool: Eliminate pointless AO2 usage.
thread_worker_pair, set_size_data and task_pushed_data structures are
allocated with AO2 objects, passed to a taskprocessor, then released.
They never have multiple owners or use locking so AO2 only adds
overhead.

Change-Id: I2204d2615d9d952670fcb48e0a9c0dd1a6ba5036
2018-10-13 06:22:19 -05:00
Corey Farrell 675d8a46b4 main/astfd: Fix GCC8 format-truncation warning.
The field used to store call arguments was not large enough to hold the
arguments string that can be constructed for 'open'.  Expand it to
prevent this warning/error.

Change-Id: I514927f256481bc84df10a51b19d5b5fb1bc387e
2018-10-12 12:21:47 -05:00
Jenkins2 265d91a120 Merge "loader: Flag module as declined in all cases where it fails to load." 2018-10-10 12:26:58 -05:00
Richard Mudgett 682f96cb5c res_statsd.c: Fix returned reload status.
The return status when there was no change in statsd.conf was incorrect.
This resulted in the wrong status message on the CLI when reloading the
module.

* Fixed cleanup on initial load if initializing statsd failed.

Change-Id: Id24fae75f1a7ff584a444a5680e867d989792481
2018-10-09 16:30:33 -05:00
George Joseph f7fb47e5cd Merge "core/frame: generate correct T.140 payload in ast_sendtext_data()" 2018-10-05 14:32:43 -05:00
George Joseph b3a97a850b Merge "func_periodic_hook.c: Cleanup module resources on failure." 2018-10-05 14:32:21 -05:00
George Joseph 4f3b7e08c9 Merge "codec_speex.c: Cleanup module loading to DECLINE and not FAILURE." 2018-10-05 14:30:40 -05:00
George Joseph 0056f260dd Merge "res_smdi.c: Fix module ref counting and inverted test." 2018-10-05 10:52:18 -05:00
George Joseph 9549511731 Merge "res_statsd.c: Made use defaults if the statsd.conf file does not exist." 2018-10-05 10:10:28 -05:00
George Joseph 4b90cb1cd0 Merge "res_smdi.c: Made use defaults if the smdi.conf file does not exist." 2018-10-05 10:09:50 -05:00
neutrino88 17f4e6ad4d core/frame: generate correct T.140 payload in ast_sendtext_data()
ast_sendtext_data() would create an incorrect T.140 text frame which
length include the null terminator byte. It causes ultimately RTP
packets to be send with this trailing 0. The proposed fix just set the
correct length to the text frame

ASTERISK-28089
Reported by: Emmanuel BUU
Tested by: Emmanuel BUU

Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96
2018-10-05 08:57:53 -05:00
Corey Farrell c8ee1a183f
loader: Flag module as declined in all cases where it fails to load.
This has no effect on startup since AST_MODULE_LOAD_FAILURE aborts
startup, but it's possible for this code to be returned on manual load
of a module after startup.

It is an error for a module to not have a load callback but this is not
a fatal system error.  In this case flag the module as declined, return
AST_MODULE_LOAD_FAILURE only if a required module is broken.

Expand doxygen documentation for AST_MODULE_LOAD_*.

Change-Id: I3c030bb917f6e5a0dfd9d91491a4661b348cabf8
2018-10-04 19:40:47 -04:00
Richard Mudgett c6c3a63696 func_periodic_hook.c: Cleanup module resources on failure.
* Make load_module() cleanup if it failed to setup the module.

* Make unload_module() always return 0.  It is silly to fail unloading if
the hook function we try to unregister was not even registered.

Change-Id: I280fc6e8ba2a7ee2588ca01d870eebaf74b4ffe6
2018-10-04 14:38:52 -05:00
Richard Mudgett 9f02861d22 codec_speex.c: Cleanup module loading to DECLINE and not FAILURE.
If codec_speex fails to register a translator it would cause Asterisk to
exit instead of continue as a DECLINED module.

* Make unload_module() always return 0.  It is silly to fail unloading if
any translators we try to unregister were not even registered.

Change-Id: Ia262591f68333dad17673ba7104d11c88096f51a
2018-10-04 14:36:47 -05:00
George Joseph 30717bafbf CI: Fix missing () in gates.jenkinsfile
Change-Id: I2f252e0f8c7f1a6328438fbd2be5d6574b7dfa5b
2018-10-04 13:04:12 -05:00
Jenkins2 0db94c7519 Merge "CI: Add timestamps and timeouts to jenkinsfiles" 2018-10-04 12:50:18 -05:00
Jenkins2 e430442c4c Merge "jenkins: Fix cleanup command redirection." 2018-10-04 11:28:39 -05:00
George Joseph 58622a87f4 CI: Add timestamps and timeouts to jenkinsfiles
Change-Id: Ide83574dc957bc1df28e30a69079140050dfc35f
2018-10-04 10:14:28 -05:00
George Joseph 772d991a43 Merge "ast_coredumper: Remove .gdbinit file on exit" 2018-10-04 09:43:09 -05:00
George Joseph 5d3cc31bf8 Merge "CI: Use brace expansion instead of calling out to seq" 2018-10-04 09:41:48 -05:00
George Joseph 1630a87b59 Merge "CI: Look up configured kernel.core_pattern sysctl" 2018-10-04 08:54:24 -05:00
George Joseph aec9708300 Merge "ast_coredumper: Don't use "declare -n"" 2018-10-04 07:27:18 -05:00
George Joseph 45eb9a28eb Merge "astobj2: Comment on OBJ_NOLOCK in ao2_container_clone." 2018-10-04 07:25:47 -05:00