Commit graph

3074 commits

Author SHA1 Message Date
Tilghman Lesher
5a71f180ad Merged revisions 128812 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r128812 | tilghman | 2008-07-07 18:21:52 -0500 (Mon, 07 Jul 2008) | 2 lines

Stop using deprecated method, as requested by Kevin.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-07 23:25:39 +00:00
Mark Michelson
4f0f9d27cf Crap
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128733 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-07 20:30:46 +00:00
Mark Michelson
742815875d If imapfolder=foo were set in voicemail.conf, then when calling VoiceMailMain,
app_voicemail would attempt to play a file called vm-foo instead of playing
vm-INBOX to play the "new" sound file. This commit fixes that issue.

This may fix one of the problems reported in issue #12987



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-07 20:28:33 +00:00
Mark Michelson
04a10e77a0 Get app_voicemail compiling when IMAP storage is used.
Brought up by reporter on issue #12987



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-07 17:34:06 +00:00
Kevin P. Fleming
6b06e9a8eb Merged revisions 127892,127895 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127892 | kpfleming | 2008-07-03 17:18:38 -0500 (Thu, 03 Jul 2008) | 6 lines

a couple of small Solaris-related fixes

(closes issue #11885)
Reported by: snuffy, asgaroth


........
r127895 | kpfleming | 2008-07-03 17:20:16 -0500 (Thu, 03 Jul 2008) | 3 lines

remove this, it has been moved to the main Makefile


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 22:23:04 +00:00
Mark Michelson
6cfe27089c Make change proposed by andrew53 on bugtracker
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 20:59:51 +00:00
Mark Michelson
5a8a23f9ba Thanks to a suggestion from seanbright, print a warning if the attachment
of the whisper or barge audiohooks fails.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127856 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 20:37:21 +00:00
Mark Michelson
bb9a355ff0 Fix build
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 20:23:57 +00:00
Mark Michelson
dd315e5f74 Fix a crash when attempting to spy on an unbridged channel.
(closes issue #12986)
Reported by: andrew53



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127831 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 20:19:10 +00:00
Mark Michelson
e4c93fc8c3 Added a new option, "timeoutpriority" to queues.conf. A detailed
explanation of the change may be found in configs/queues.conf.sample

(closes issue #12690)
Reported by: atis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 14:34:25 +00:00
Tilghman Lesher
267b9d4eb4 Oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 22:17:37 +00:00
Tilghman Lesher
885d17506b Keep ast_app_inboxcount API compatible with 1.6.0.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 21:27:53 +00:00
Tilghman Lesher
3a27a6a9e7 Fix some crashlike bugs because flag could be NULL in play_record_review().
(Closes issue #12892)
Reported by: jaroth
Patch originally by jaroth, fixed by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 20:52:27 +00:00
Mark Michelson
13a81dd7ae Merged revisions 127244 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127244 | mmichelson | 2008-07-01 18:36:40 -0500 (Tue, 01 Jul 2008) | 5 lines

Add error message to failed open(2) calls inside the copy() function of
app_voicemail. This idea came as part of my work in helping to resolve
issue #12764.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 23:38:12 +00:00
Kevin P. Fleming
da14954bdc another minor ast_channel memory size decrease... for nearly all channels, 'dialcontext' is only going to be set once during the channel's lifetime, so make it a string field instead of a char array
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126960 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 16:16:36 +00:00
Luigi Rizzo
f55143f0a6 fix an uninitialized variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 15:44:50 +00:00
Mark Michelson
6d1ebfbed5 Remove debug message
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125856 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 16:18:07 +00:00
Mark Michelson
ab7809ace9 Ensure the thread-safety of the monexec variable in app_queue.
Thanks to Russell for pointing out the problem



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125855 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 16:16:13 +00:00
Mark Michelson
09c659d7d0 Make this compile with dev-mode on
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125666 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 00:22:03 +00:00
Mark Michelson
9aef593e58 The monitor-join option for queues was deprecated in favor of using
MixMonitor to mix audio. However, it was pointed out to me that because
of this, the command set for the MONITOR_EXEC variable is ignored as well.
This means that people can't do their own custom mixing commands at the end
of recordings in order to make, for instance, stereo recordings of calls.

With this patch, app_queue will set the "joinfiles" variable for the channel's
monitor if MONITOR_EXEC is not zero-length. This means that for normal audio
mixing, MixMonitor is still the preferred choice, but we allow custom
mixing to be done with the two Monitor streams if desired.

(closes issue #12923)
Reported by: snyfer



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 00:15:54 +00:00
Mark Michelson
0178d0ccd6 Improve consistency between app_dial and app_queue with regards
to how language is handled between two channels whose native
language is different. Prior to this patch, app_dial would have
the callee inherit the caller's language, and app_queue would not.

After this patch, app_dial no longer has the language inheritance
capability. This seems to make the most sense since it seems more
natural for a person to hear files played back in his/her native
language instead of the language of the person on the far end of
the call. See the CHANGES file for hints on how to keep the 
previous behavior of app_dial if desired.

(closes issue #12489)
Reported by: bcnit



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 23:35:29 +00:00
Mark Michelson
edbe6b7a25 Fix a really stupid mistake
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125591 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 23:06:18 +00:00
Mark Michelson
3859074667 Merged revisions 125585 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r125585 | mmichelson | 2008-06-26 17:52:39 -0500 (Thu, 26 Jun 2008) | 11 lines

Add the interface of a queue member to the output of the "queue show" command
so that it can easily be associated with a queue member's name. This helps
so that the appropriate queue member can be removed or paused since the 
interface is required, not the member's name.

(closes issue #12783)
Reported by: davevg
Patches:
      app_queue.diff uploaded by davevg (license 209) with small mod from me


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125586 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 23:01:02 +00:00
Mark Michelson
96f92f468f Merged revisions 125476 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r125476 | mmichelson | 2008-06-26 15:56:01 -0500 (Thu, 26 Jun 2008) | 11 lines

Prior to this patch, the "queue show" command used cached
information for realtime queues instead of giving up-to-date
info. Now realtime is queried for the latest and greatest in
queue info.

(closes issue #12858)
Reported by: bcnit
Patches:
      queue_show.patch uploaded by putnopvut (license 60)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 20:57:41 +00:00
Tilghman Lesher
c9ac1b8ca5 Don't play "your message has been saved" twice.
(closes issue #12893)
 Reported by: jaroth
 Patches: 
       duplicate_saved.patch uploaded by jaroth (license 50)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125438 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 17:40:25 +00:00
Kevin P. Fleming
fd4a60c459 Merged revisions 125132 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r125132 | kpfleming | 2008-06-25 17:21:30 -0500 (Wed, 25 Jun 2008) | 10 lines

allow tonezone to live in a different place than DAHDI/Zaptel, since dahdi-tools and dahdi-linux are now separate packages and can be installed in different places

don't include tonezone.h in dahdi_compat.h, because only a couple of modules need it

get app_rpt building again after the DAHDI changes

(closes issue #12911)
Reported by: tzafrir


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125138 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-25 23:05:28 +00:00
Tilghman Lesher
7ec25255c5 Merged revisions 124910 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124910 | tilghman | 2008-06-24 16:08:52 -0500 (Tue, 24 Jun 2008) | 8 lines

Occasionally control characters find their way into CallerID.  These need to
be stripped prior to placing CallerID in the headers of an email.
(closes issue #12759)
 Reported by: RobH
 Patches: 
       20080602__bug12759__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: RobH

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124912 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-24 21:18:52 +00:00
Sean Bright
3e0071199d Let app_rpt compile.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-22 14:12:49 +00:00
Steve Murphy
d68b137c3d Merged revisions 124540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124540 | murf | 2008-06-21 20:54:52 -0600 (Sat, 21 Jun 2008) | 9 lines

(closes issue #12910)
Reported by: chris-mac

Sorry, my testing did not contain the simple case of forkCDR(v),
I am much embarrassed to admit.  If I had, I would have 
more solidly initialized the opts element for varset.



........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-22 02:58:06 +00:00
Tilghman Lesher
2bec827536 Merged revisions 124450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124450 | tilghman | 2008-06-20 18:12:33 -0500 (Fri, 20 Jun 2008) | 6 lines

usleep with a value over 1,000,000 is nonportable.  Changing to use sleep()
instead.  (closes issue #12814)
 Reported by: pputman
 Patches: 
       app_rtp_sleep.patch uploaded by pputman (license 81)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-20 23:13:21 +00:00
Mark Michelson
1d2ac41c07 Fix attachment behavior when using IMAP storage for voicemails
1. Filenames had an extra "msg" in the attachment name
2. The attachment was being saved twice

(closes issue #12894)
Reported by: jaroth
Patches:
      imap_attach.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124180 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 22:34:03 +00:00
Michiel van Baak
8e8359465b Older versions of GNU gcc do not allow 'NULL' as sentinel.
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4

This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)

All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:48:33 +00:00
Mark Michelson
7852d30fe8 Merged revisions 124112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124112 | mmichelson | 2008-06-19 15:28:41 -0500 (Thu, 19 Jun 2008) | 8 lines

Fix IMAP forwarding so that messages are sent to the proper mailbox.

(closes issue #12897)
Reported by: jaroth
Patches:
      destination_forward.patch uploaded by jaroth (license 50)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:30:23 +00:00
Mark Michelson
a2b4382fd7 Forwarding non-urgent IMAP messages could inadvertently cause the messages
to be marked urgent. This fixes that issue.

(closes issue #12895)
Reported by: jaroth
Patches:
      urgent_forwarding.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 15:55:10 +00:00
Tilghman Lesher
d2247c2573 Missing comma
(closes issue #12891)
 Reported by: chris-mac


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 15:52:17 +00:00
Sean Bright
62cb684f59 Include original position in TRANSFER entries written to queue_log.
(closes issue #12888)
Reported by: slavon
Patches:
      app_queue_transfer_patch_trunk.diff uploaded by slavon (license 288)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 14:24:43 +00:00
Mark Michelson
eaa14309dd A portion of the code which handled the 'c' queue option had been
removed. No telling when it happened. Anyway, it's back in now
and works properly.

(Based on issue reported on mailing list)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 15:08:56 +00:00
Mark Michelson
103a94c6c4 Silly pointers. This fixes a memory corruption I introduced
with the attended transfer logging.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 14:54:47 +00:00
Tilghman Lesher
90867b2b0c Channel lock janitor -- add locks around retrieval of channel variables
(closes issue #12840)
 Reported by: pputman
 Patches: 
       app_dial_threadsafe3.patch uploaded by pputman (license 81)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 13:09:02 +00:00
Brett Bryant
2aae0ba13d Updates all usages of ast_tcptls_session_instance to be managed by reference counts so that they only get destroyed when all threads are done using
them, and memory does not get free'd causing strange issues with SIP. 

This code was originally written by russellb in the team/group/issue_11972/ branch.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:46:57 +00:00
Tilghman Lesher
9d403c379f Add an option, specifying maximum analysis time for talk detection.
(closes issue #12149)
 Reported by: davevg
 Patches: 
       app_talkdetect.c.diff uploaded by davevg (license 209)
       (Plus a few additional cleanups by moi)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:42:42 +00:00
Mark Michelson
0283469cfc Merged revisions 123274 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123274 | mmichelson | 2008-06-17 10:56:55 -0500 (Tue, 17 Jun 2008) | 12 lines

davidw pointed out that the holdtime calculation used by
app_queue does not use "boxcar" filtering as the comments
say. The term "boxcar" means that the number of samples used
to calculate stays constant, with new samples replacing the
oldest ones. The queue holdtime calculation uses all holdtime
samples collected since the queue was loaded, so the comment
has been changed to be accurate.

(closes issue #12781)
Reported by: davidw


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123275 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 15:57:43 +00:00
Steve Murphy
f4c85ebd22 (closes issue #12689)
Reported by: ys

Many thanks to ys for doing the research on this problem.
I didn't think it would be best to unlock the contexts
and then relock them after the remove_extension2() call,
so I added an extra arg to remove_extension2() and set it
appropriately in each call. There were not that many.

I considered forcing the code to lock the contexts before
the call to remove_extension2(), but that would require
a slightly greater degree of changes, especially since
the find_context_locked is local to pbx.c

I did a simple sanity test to make sure the code doesn't
mess things up in general.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 20:43:46 +00:00
Chris Tooley
39606a9c64 Changes response to the ExternalIVR() P command from pipe delimited to comma delimited. closes issue #12804
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 20:02:06 +00:00
Sean Bright
6c49489b00 Resurrected app_fax
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122834 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 03:33:03 +00:00
Mark Michelson
eb1e6f0806 Fix a segfault by not trying to store a stack address for
long-term use. Instead use the heap. I can't believe this
never happened *once* in my developer branch when I was testing.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-12 23:58:01 +00:00
Jeff Peeler
84d0404ed5 (closes issue 0012193)
Reported by: davidw
Patch by: Corydon76, modified by me to work properly with ParkAndAnnounce app


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-12 23:08:37 +00:00
Mark Michelson
54c92d9a63 Recommitting revision 122228, which was accidentally reverted
as a result of commit 122234.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122399 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-12 21:23:02 +00:00
Mark Michelson
054f08a1c8 Merged revisions 122311 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122311 | mmichelson | 2008-06-12 13:50:58 -0500 (Thu, 12 Jun 2008) | 9 lines

Properly play a holdtime message if the announce-holdtime option is
set to "once."

(closes issue #12842)
Reported by: ramonpeek
Patches:
      patch001.diff uploaded by ramonpeek (license 266)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-12 18:53:17 +00:00
Jeff Peeler
ef3b214728 Goodbye Zaptel, hello DAHDI. Removes Zaptel driver support with DAHDI. Configuration file and dialplan backwards compatability has been put in place where appropiate. Release announcement to follow.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-12 17:27:55 +00:00