Commit graph

5604 commits

Author SHA1 Message Date
Russell Bryant
72d5d58069 Remove commentary from the issues list for SIP TCP/TLS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155929 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-11 16:07:36 +00:00
Mark Michelson
b07eba0c15 Merged revisions 155861 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r155861 | mmichelson | 2008-11-10 15:07:39 -0600 (Mon, 10 Nov 2008) | 14 lines

Channel drivers assume that when their indicate callback
is invoked, that the channel on which the callback was called
is locked. This patch corrects an instance in chan_agent where
a channel's indicate callback is called directly without first
locking the channel.

This was leading to some observed locking issues in chan_local,
but considering that all channel drivers operate under the
same expectations, the generic fix in chan_agent is the right
way to go.

AST-126


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155863 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-10 21:14:44 +00:00
Sean Bright
48522988ab In order to move away from nested function use, some changes to the recently introduced
ast_channel_search_locked need to be made.  Specifically, the caller needs to be able to
pass arbitrary data which in turn is passed to the callback.  This patch addresses all
of the nested functions currently in asterisk trunk.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-09 01:59:59 +00:00
Russell Bryant
ef489f8195 - Check for failure when putting the packet in the ast_str
- fix a spelling error in a header file


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-08 21:46:43 +00:00
Russell Bryant
648ea2aab9 Remove some code that is basically a no-op. Code above this already ensures that
the buffer is terminated.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-08 21:34:36 +00:00
Mark Michelson
111203aed9 Set the invite state to INV_CANCELLED in a place that
makes more sense. Where it was set before, it was impossible
to actually delay sending a CANCEL if we had not yet received
a provisional response to an INVITE.

(closes issue #13626)
Reported by: atis
Patches:
      13626.patch uploaded by putnopvut (license 60)
Tested by: atis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 23:41:44 +00:00
Sean Bright
30d1744ffc Add ability to pass arbitrary data to the ao2_callback_fn (called from
ao2_callback and ao2_find).  Currently, passing OBJ_POINTER to either
of these mandates that the passed 'arg' is a hashable object, making
searching for an ao2 object based on outside criteria difficult.

Reviewed by Russell and Mark M. via ReviewBoard:
    http://reviewboard.digium.com/r/36/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 22:39:30 +00:00
Tilghman Lesher
bd3f685f20 Merged revisions 155398 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r155398 | tilghman | 2008-11-07 16:27:32 -0600 (Fri, 07 Nov 2008) | 7 lines
  
  Clarify error message.
  (closes issue #13809)
   Reported by: denke
   Patches: 
         20081104__bug13809.diff.txt uploaded by Corydon76 (license 14)
   Tested by: denke
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155399 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 22:28:58 +00:00
Tilghman Lesher
ca3cf9f488 Send call release with unallocated cause instead of normal call clearing, when
invalid extension is called.
(closes issue #13408)
 Reported by: adomjan
 Patches: 
       chan_dahdi.c-ss7-unallocated-2 uploaded by adomjan (license 487)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155324 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 20:13:32 +00:00
Kevin P. Fleming
90e573c373 stringfields conversion for struct sip_peer, as requested :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155282 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 15:52:05 +00:00
Russell Bryant
41ab61a2a2 Remove a bogus ast_free() that Kevin noticed. This was probably just left over
from pre-astobj2ified chan_sip.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 15:42:04 +00:00
Russell Bryant
1a239454f1 Fix some code in chan_sip that was intended to unlink multiple objects from a
container.  The OBJ_MULTIPLE flag must be provided here.  Otherwise, this would
only remove a single object.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 14:50:30 +00:00
Kevin P. Fleming
f08ab8278c put ifdef protection around the rest of the libpri function calls that were added at the same time as progress_with_cause
move parsing of the qsig channel mapping configuration option outside ifdef HAVE_PRI_INBANDDISCONNECT and into a properly ifdef'd block



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-06 20:51:26 +00:00
Matthew Fredrickson
5250201d8b Make compilation of chan_dahdi so that it does not require the new pri_progress_with_cause function to have libpri support work.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 20:45:03 +00:00
Eliel C. Sardanons
ccaefe4d40 Add AgentLogin(), AgentMonitorOutgoing() applications and
AGENT() function XML documentation.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154837 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 20:17:06 +00:00
Sean Bright
086a52d9d1 Introduce a new API call ast_channel_search_locked, which iterates through the
channel list calling a caller-defined callback.  The callback returns non-zero
if a match is found.  This should speed up some of the code that I committed
earlier today in chan_sip (which is also updated by this commit).

Reviewed by russellb and kpfleming via ReviewBoard:
	http://reviewboard.digium.com/r/28/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154429 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 23:23:39 +00:00
Tilghman Lesher
bdb21bef93 Switch to using a thread condition to signal that a child thread is ready for
work, rather than a busy wait.
(closes issue #13011)
 Reported by: jpgrayson
 Patches: 
       chan_iax2_find_idle.patch uploaded by jpgrayson (license 492)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 23:03:00 +00:00
Tilghman Lesher
0488e8c94e Merged revisions 154365 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r154365 | tilghman | 2008-11-04 14:49:33 -0600 (Tue, 04 Nov 2008) | 9 lines
  
  On busy systems, it's possible for the values checked within a single line
  of code to change, unless the structure is locked to ensure a consistent
  state.
  (closes issue #13717)
   Reported by: kowalma
   Patches: 
         20081102__bug13717.diff.txt uploaded by Corydon76 (license 14)
   Tested by: kowalma
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 20:51:18 +00:00
Richard Mudgett
89a678df60 Merged revisions 154266 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r154266 | rmudgett | 2008-11-04 13:01:08 -0600 (Tue, 04 Nov 2008) | 4 lines
  
  JIRA ABE-1703
  mISDN sets the channel to the wrong state when it receives
  the indication AST_CONTROL_RINGING.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 19:07:26 +00:00
Tilghman Lesher
721b90aa4b Recorded merge of revisions 154263 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r154263 | tilghman | 2008-11-04 12:58:05 -0600 (Tue, 04 Nov 2008) | 3 lines
  
  Make the monitor thread non-detached, so it can be joined (suggested by Russell
  on -dev list).
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 18:59:48 +00:00
Sean Bright
6ba4e7853e Allow devices that accept dialog-info+xml (like snoms) to get the Caller ID of
the calling party when subscribed to the state of an extension that is ringing.
This has some limitations which are documented in sip.conf.sample.

(closes issue #13827)
Reported by: seanbright
Patches:
      issue13827.patch uploaded by seanbright (license 71)
Reviewed by: russellb


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154187 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 17:00:45 +00:00
Kevin P. Fleming
448562af93 improve configure script to remember the previous value of each dependency in build_tools/menuselect-deps, so that (once it has been written) menuselect can use this information to warn the user when a previously met dependency is no longer met
along the way, change tags used in configure script, menuselect-deps and code for various dependencies to be consistently named



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 15:07:54 +00:00
Eliel C. Sardanons
46d7e8dafa Add XML documentation for:
Applications
     - DAHDISendKeypadFacility()
     - DAHDISendCallreroutingFacility()



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 14:38:20 +00:00
Olle Johansson
204845843e Adding a separation of remote authentication and our authentication.
remotesecret => our password for a remote service
secret => our authentication when someone calls us

Secret => still has both functions if remotesecret is not used.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153904 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 15:16:33 +00:00
Eliel C. Sardanons
4c3ce9b8a1 Add XML documentation for:
Functions
        - IAXPEER()
        - IAXVAR()



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 13:33:58 +00:00
Eliel C. Sardanons
105a020b6f Add XML documentation for:
Applications
        - SIPDtmfMode()
        - SIPAddHeader()
     Functions
        - SIP_HEADER()
        - SIPPEER()
        - SIPCHANINFO()
        - CHECKSIPDOMAIN()



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153803 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 12:35:05 +00:00
Kevin P. Fleming
2dc21e951b fix one more warning missed because i did not have new enough libpri installed
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 19:39:41 +00:00
Kevin P. Fleming
bd4eb070f3 bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 18:52:13 +00:00
Eliel C. Sardanons
1e6864dd9d Add IAX2Provision() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153582 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 06:24:53 +00:00
Sean Bright
3160f06f31 There is a troublesome assert() in the alsa/control.h header that causes
GCC 4.3.2 to complain that the passed argument will always evaluate to
true.  So to get things to compile, disable assert when building
chan_usbradio.so.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 04:14:20 +00:00
Russell Bryant
981c2d03b6 Don't ignore the result of find_peer() when looking for a peer by IP in check_peer_ok().
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-01 23:46:12 +00:00
Russell Bryant
1fef0f63bb Ensure that the sip_pvt properly has its refcount incremented when the scheduler holds
a reference to it for session timer processing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153362 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-01 20:41:38 +00:00
Tilghman Lesher
44b484195e Merged revisions 153114 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r153114 | tilghman | 2008-10-31 11:30:32 -0500 (Fri, 31 Oct 2008) | 3 lines
  
  Turn off qualify on uncached realtime peers.
  (Closes issue #13383)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-31 16:35:21 +00:00
Tilghman Lesher
1132628748 Merged revisions 152958 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152958 | tilghman | 2008-10-30 15:33:28 -0500 (Thu, 30 Oct 2008) | 3 lines
  
  Cannot join detached threads.  See http://www.opengroup.org/onlinepubs/000095399/functions/pthread_join.html
  (Closes issue #13400)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152969 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 20:35:46 +00:00
Tilghman Lesher
33f0058029 Merged revisions 152922 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152922 | tilghman | 2008-10-30 14:43:38 -0500 (Thu, 30 Oct 2008) | 6 lines
  
  Unlock before returning, when extension doesn't exist.
  (closes issue #13807)
   Reported by: eliel
   Patches: 
         chan_local.c.patch uploaded by eliel (license 64)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 19:45:52 +00:00
Russell Bryant
19f1e7e578 Fix the sip_peer reference count with respect to scheduler entries for
scheduling peer pokes, and scheduling peer poke expirations.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 19:40:15 +00:00
Russell Bryant
46a8b1deed Fix the sip_peer reference count with respect to scheduler entries for
registration expirations.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152915 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 19:35:36 +00:00
Mark Michelson
c0b9b259ca I just noticed this construct and thought it was
silly to have a bunch of case statements with duplicated
code in each case. Instead, just use the built-in fallthrough
capability of case statements and reduce the code to
a single instance



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 19:23:16 +00:00
Russell Bryant
3d5b3249a8 Modify the documentation of the sip_registry struct
- Remove a comment that says that the monitor thread is the only one that
   ever touches these objects.  This is no longer the case with TCP.  Also,
   I would eventually like to get the scheduler in its own thread, so this
   is just a poor assumption to make.
 - Note that reference counting of these objects with respect to scheduler
   entries is not complete.  There are some leaked references when deleting
   scheduler entries.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152877 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 19:21:53 +00:00
Kevin P. Fleming
10d36d9f34 fix a few small things found by using sparse
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 16:49:02 +00:00
Russell Bryant
0dbd863733 Merged revisions 152539 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152539 | russell | 2008-10-29 00:23:51 -0500 (Wed, 29 Oct 2008) | 7 lines

Fix an incorrect usage of sizeof()

(closes issue #13795)
Reported by: andrew53
Patches:
	chan_sip_sizeof.patch uploaded by andrew53 (license 519)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-29 05:34:26 +00:00
Tilghman Lesher
e9d96775ad Only re-add the io port if it was closed, otherwise reload causes a memory
leak.
(closes issue #13785)
 Reported by: eliel
 Patches: 
       chan_mgcp.c.patch uploaded by eliel (license 64)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152442 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-28 21:38:26 +00:00
Jeff Peeler
33f576f1a1 Merged revisions 152286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152286 | jpeeler | 2008-10-27 18:28:49 -0500 (Mon, 27 Oct 2008) | 2 lines

Buffer policy setting for half is not needed.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 23:31:39 +00:00
Tilghman Lesher
ae991d086e Merged revisions 152215 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152215 | tilghman | 2008-10-27 16:32:00 -0500 (Mon, 27 Oct 2008) | 6 lines
  
  Inherit ALL elements of CallerID across a local channel.
  (closes issue #13368)
   Reported by: Peter Schlaile
   Patches: 
         20080826__bug13368.diff.txt uploaded by Corydon76 (license 14)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152216 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 21:34:04 +00:00
Olle Johansson
0fdde26109 Trying to fix the user/peer matching correctly. This will need some testing before
getting merged into 1.6.1


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152020 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-26 10:23:01 +00:00
Olle Johansson
9137733e11 Moving more variables to the sip_cfg structure, as I have some future ideas for the usage of that structure.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-26 09:45:17 +00:00
Olle Johansson
31a9f1e6f0 Doxygen changes and some formatting.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151980 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-26 09:19:19 +00:00
Olle Johansson
5aa23add8c Adding a small new feature.
Setting _SIPFROMDOMAIN in a channel will set the domain we use for the URI in the outbound call leg.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151739 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-23 15:30:16 +00:00
BJ Weschke
d7422c975e revert the changes in issue #13705 - it's being re-opened as while the results fixed the complaint in the issue, it introduced other more undesirable issues than what was already reported
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 20:45:03 +00:00
Mark Michelson
0748be1052 Change some logical ands to bitwise ands and add
messages alerting that a channel is being ignored
if the PROC_DAHDI_NOCHAN option is set in process_dahdi.

(closes issue #13759)
Reported by: smurfix
Patches:
      dahdi.patch uploaded by smurfix (license 547)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 20:05:14 +00:00