Commit graph

671 commits

Author SHA1 Message Date
Mark Michelson
30c0e089f6 Fix redeclaration of variables when using IMAP storage
(closes issue #11988)
Reported by: jaroth
Patches:
      variable_cleanup.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@103737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-15 22:56:14 +00:00
Mark Michelson
8f625a4664 Merged revisions 103690 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r103690 | mmichelson | 2008-02-14 15:03:02 -0600 (Thu, 14 Feb 2008) | 3 lines

Fix build for non-IMAP builds


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@103691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-14 21:04:37 +00:00
Mark Michelson
235aa41c6d Merged revisions 103688 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r103688 | mmichelson | 2008-02-14 14:55:48 -0600 (Thu, 14 Feb 2008) | 9 lines

Fix the new message count if delete=yes when using IMAP storage.

(closes issue #11406)
Reported by: jaroth
Patches:
      deleteflag_v2.patch uploaded by jaroth (license 50)
	  Tested by: jaroth


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@103689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-14 20:58:30 +00:00
Tilghman Lesher
9d4d240b94 Merged revisions 103197 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r103197 | tilghman | 2008-02-09 00:23:49 -0600 (Sat, 09 Feb 2008) | 4 lines

Commit fix for being unable to send voicemail from VoiceMailMain
 Reported by: William F Acker (via the -users mailing list)
 Patch by: Corydon76 (license 14)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@103198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-09 06:33:10 +00:00
Russell Bryant
1ec8cb41a8 Merge changes from team/mvanbaak/cli-command-audit
(closes issue #8925)

About a year ago, as Leif Madsen and Jim van Meggelen were going over the CLI
commands in Asterisk 1.4 for the next version of their book, they documented
a lot of inconsistencies.  This set of changes addresses all of these issues
and has been reviewed by Leif.

While this does introduce even more changes to the CLI command structure, it
makes everything consistent, which is the most important thing.

Thanks to all that helped with this one!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@103171 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-08 21:26:32 +00:00
Tilghman Lesher
ee3cc80284 Merged revisions 102576 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r102576 | tilghman | 2008-02-05 18:26:02 -0600 (Tue, 05 Feb 2008) | 4 lines

Move around some defines to unbreak ODBC storage.
(closes issue #11932)
 Reported by: snuffy

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@102602 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-06 03:05:00 +00:00
Mark Michelson
bb156b5cb5 Change verbose messages to use the ast_verb macro.
(closes issue #11931)
Reported by: snuffy
Patches:
      bug-11931.diff uploaded by snuffy (license 35)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@102501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-05 20:54:53 +00:00
Tilghman Lesher
ab5a1a6c8c Merged revisions 101942 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r101942 | tilghman | 2008-02-01 15:54:28 -0600 (Fri, 01 Feb 2008) | 8 lines

Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugs
while I'm in the area.
(closes issue #11615)
 Reported by: jamessan
 Patches: 
       20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76, jamessan

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@101943 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 22:12:55 +00:00
Tilghman Lesher
0d9a551f30 Make the VoicemailUsersList AMI command consistent with other manager list functions.
(closes issue #11874)
 Reported by: srt
 Patches: 
       voicemail_ami-11847.patch uploaded by srt (license 378)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@101269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-30 16:54:20 +00:00
Jason Parker
4688907e17 Merged revisions 100672 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11795)
........
r100672 | qwell | 2008-01-28 14:42:43 -0600 (Mon, 28 Jan 2008) | 7 lines

When using ODBC_STORAGE, make sure we put greeting files into the database like we do with the others.

Issue #11795
Reported by: dimas
Patches:
      vmgreet.patch uploaded by dimas (license 88)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@100676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 21:02:11 +00:00
Tilghman Lesher
6139e1ed82 Coding guidelines fixups
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 05:29:28 +00:00
Tilghman Lesher
6df535971b Merged revisions 99777 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r99777 | tilghman | 2008-01-22 22:31:51 -0600 (Tue, 22 Jan 2008) | 8 lines

When we reset the password via an external command, we should also reset the
password stored in the in-memory list, too (otherwise it doesn't really take
effect).
(closes issue #11809)
 Reported by: davetroy
 Patches: 
       fix_externpass.diff uploaded by davetroy (license 384)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99778 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 04:35:04 +00:00
Mark Michelson
fdc76e87bf Fixing trunk IMAP build
(closes issue #11788)
Reported by: DEA
Patches:
      vm-imap-build-fix.txt uploaded by DEA (license 3)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99002 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-17 22:22:02 +00:00
Jason Parker
b875d0df01 Add backupdeleted option to app_voicemail
(closes issue #10740)
Reported by: ruffle
Patches:
      app_voicemail.diff uploaded by ruffle (license 201)
      10740-voicemail.diff uploaded by qwell (license 4)
      20080113_bug10740.diff.txt uploaded by mvanbaak (license 7)
Tested by: blitzrage, mvanbaak, qwell


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@98889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-14 22:19:40 +00:00
Mark Michelson
45634bab41 Merged revisions 97925 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r97925 | mmichelson | 2008-01-10 15:57:06 -0600 (Thu, 10 Jan 2008) | 6 lines

Let us leave a voicemail for ourself if we have logged into VoiceMailMain and chosen
to leave a message.

(closes issue #11735, reported and patched by jamessan)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 21:58:47 +00:00
Mark Michelson
8f9f9246ce Use the appropriate line ending for the X-Asterisk-VM-Message-Type header.
(closes issue #11734, reported and patched by jaroth)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 20:05:43 +00:00
Tilghman Lesher
857e3412f4 Several manager changes:
1) Add the Dialplan class, for NewExten and VarSet events, which should cut
down on the volume of traffic in the Call class.
2) Permit some commands to be run from multiple classes, such as allowing
DBGet to be run from either the System or the Reporting class.
3) Heavily document each class in the sample config, as there were several
that made no sense to be in the write= line, and two that made no sense to be
in the read= line (since they controlled no permissions there).

(Closes issue #10386)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 00:12:35 +00:00
Tilghman Lesher
19ff8f7f74 Add a new flag 'd' (with optional context) permitting any extension within
that context to be entered as a new extension during the playback of a
voicemail greeting.
Patch inspired by bluecrow76, by tilghman.
(Closes issue #7063)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97305 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 23:51:51 +00:00
Mark Michelson
190306a23f Merged revisions 97192 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r97192 | mmichelson | 2008-01-08 14:42:07 -0600 (Tue, 08 Jan 2008) | 9 lines

Making some changes designed to not allow for a corrupted mailstream for a vm_state.

1. Add locking to the vm_state retrieval functions so that no linked list corruption occurs.
2. Make sure to always grab the persistent vm_state when mailstream access is necessary.
3. Correct an incorrect return value in the init_mailstream function.

(closes issue #11304, reported by dwhite)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97193 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 20:45:59 +00:00
Mark Michelson
52fb517bf9 Explicitly make literal constants long where they are expected to be.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96987 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 22:31:03 +00:00
Mark Michelson
19b18414f5 Document some weird casting magic that's necessary to interface
with the c-client



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 21:10:59 +00:00
Mark Michelson
905fc559d1 Adding user-configurable TCP timeout settings to IMAP voicemail. This could
go a long way towards preventing unexplainable hangs experienced by people. In the
case of MWI hangs, this also will mean that the SIP port isn't blocked anymore.

(closes issue #11665, reported by yehavi)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96934 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 21:04:09 +00:00
Luigi Rizzo
c8f970936d remove more unnecessary casts for NULL.
main/say.c is a big offender in this respect.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95073 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-27 23:32:18 +00:00
Luigi Rizzo
5e041a46dc NULL does not need to be cast to (char *)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-27 23:13:15 +00:00
Mark Michelson
eb10026dba Something I've been itching to do for a while now. A minor optimization in app_voicemail.
Since the dtable in base_encode always gets populated with the same values every time and never
changes, make it static and const and only initialize it once. Also, there's no reason to 
define BASEMAXINLINE twice, so remove the redundant #define.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 21:19:19 +00:00
Mark Michelson
4c8ad19825 Lots of coding guidelines cleanup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:24:24 +00:00
Mark Michelson
42803ef6e4 Merged revisions 94540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94540 | mmichelson | 2007-12-21 14:11:34 -0600 (Fri, 21 Dec 2007) | 8 lines

Better quota support for using IMAP storage voicemail

(closes issue #11415, reported by jaroth)
(closes issue #11152, reported by selsky)

Patch provided by jaroth


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:18:26 +00:00
Mark Michelson
590a70a9cd Merged revisions 94538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94538 | mmichelson | 2007-12-21 13:59:45 -0600 (Fri, 21 Dec 2007) | 5 lines

The mail_copy c-client function does not expect a full imap mailbox string, just the name of the mailbox.

(closes issue #11419, reported and patched by jaroth, with additional patchwork from me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:01:10 +00:00
Mark Michelson
51a48a2ed9 The changes to header inclusion in trunk broke compilation of app_voicemail when using
IMAP storage. The reason is that c-client has its own definitions for LOG_WARNING
and LOG_DEBUG, so we need to be sure to include asterisk's definitions last so that
we use the proper values in app_voicemail.

(closes issue #11437, reported by blitzrage, patch suggested by blitzrage)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 23:43:24 +00:00
Tilghman Lesher
d36381e629 Add 'voicemail reload' command.
Reported by: eliel
Patch by: eliel
(Closes issue #11365)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-19 20:20:55 +00:00
Mark Michelson
2a8a244447 Merged revisions 93291 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r93291 | mmichelson | 2007-12-17 13:53:48 -0600 (Mon, 17 Dec 2007) | 6 lines

We need to create the directory for a voicemail user even if they are using IMAP storage
since greetings are stored in the filesystem.

(closes issue #11388, reported by spditner, patch by me inspired by a patch by spditner)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93293 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-17 20:20:32 +00:00
Mark Michelson
4155befbc0 Resolve a compiler warning
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-14 22:02:18 +00:00
Mark Michelson
f848ebc895 Change places where the name "INBOX" was hardcoded to use the imapfolder
setting from voicemail.conf instead. This commit will help to get issue
#11415 moving towards commitment.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-14 21:40:34 +00:00
Tilghman Lesher
d5b454bf8d Convert ast_verbose to ast_verb.
Reported by: snuffy
Patch by: snuffy
(Closes issue #11547)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-14 14:48:38 +00:00
Mark Michelson
5e5c866cf3 Merged revisions 92807 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92807 | mmichelson | 2007-12-13 14:03:20 -0600 (Thu, 13 Dec 2007) | 3 lines

Prevent another potential fd leak


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-13 20:12:37 +00:00
Mark Michelson
98ad4c80f5 Merged revisions 92803 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92803 | mmichelson | 2007-12-13 13:49:55 -0600 (Thu, 13 Dec 2007) | 3 lines

Prevent a possible fd leak. 


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-13 19:53:21 +00:00
Doug Bailey
26c06f4745 Tag voicemails with UTC time as opposed to local time zone
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-13 15:40:19 +00:00
Olle Johansson
e2a8a6f46a Add a few extra headers in the voicemail users listing in
manager 1.1. Update documentation too.

(closes issue #11495)
Reported by: caio1982
Patches: 
      extra_vm_manager_info1.diff uploaded by caio1982 (license 22)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92140 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-10 13:29:57 +00:00
Mark Michelson
e797cd04dc Handle allocation failure of the heard and deleted arrays of the vm_state.
(closes issue #11408, reported and patched by jaroth)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-06 21:03:15 +00:00
Mark Michelson
fe83f51186 Merged revisions 91292 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r91292 | mmichelson | 2007-12-05 16:57:13 -0600 (Wed, 05 Dec 2007) | 3 lines

Reverting extra stuff I didn't mean to commit


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91293 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-05 22:57:57 +00:00
Mark Michelson
b32e39cbda Merged revisions 91273 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r91273 | mmichelson | 2007-12-05 16:35:52 -0600 (Wed, 05 Dec 2007) | 11 lines

The 'G' option for Dial() did not properly handle the case where only a label was
provided. This was due to the fact that the answering channel did not have an extension
set, so ast_parseable_goto would fail. This fix eliminates the call to ast_parseable_goto
on the answering channel since it is a wasteful call. The answering channel and the calling
channel are both directed to the same extension and context, just different priorities, so
we can just copy the values from the calling channel to the answering channel and increment
the answering channel's priority.

(closes issue #11382, reported by jon, patch by me with correction by jon)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91291 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-05 22:55:49 +00:00
Mark Michelson
0742acef39 Kevin suggested doing the reverse of my last commit, since imap_retrieve_file
does not modify the contents of the "mailbox" string. In other words, I'm changing
the imap_retrieve_file function to take a const char* as the third argument so that I
don't need to cast const char*'s as char*'s to suppress compiler warnings.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@90930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-04 18:29:35 +00:00
Mark Michelson
50ee083210 Suppress a compiler warning due to discarding a "const" qualifier
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@90928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-04 18:14:08 +00:00
Mark Michelson
9c2b82c726 Replacing some calls to free() with ast_free().
(closes issue #11448, reported and patched by jaroth)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@90670 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-03 21:24:56 +00:00
Russell Bryant
972cacad4a Merge some little changes from team/russell/chan_refcount to help reduce
the diff to trunk.

This just removes some checks on the return value of alloca(), as behavior
is undefined if it runs out of stack space, and we don't check it anywhere else.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-28 00:49:55 +00:00
Mark Michelson
0b120dac62 Merged revisions 89580 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89580 | mmichelson | 2007-11-26 09:48:06 -0600 (Mon, 26 Nov 2007) | 6 lines

Revert vmu->email back to an empty string if it was empty when imap_store_file
was called. This prevents sending a duplicate e-mail. 

(closes issue #11204, reported by spditner, patched by me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-26 15:50:37 +00:00
Tilghman Lesher
b0d8378910 Merged revisions 89540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89540 | tilghman | 2007-11-24 00:19:23 -0600 (Sat, 24 Nov 2007) | 9 lines

Currently, zero-length voicemail messages cause a hangup in VoicemailMain.
This change fixes the problem, with a multi-faceted approach.  First, we
do our best to avoid these messages from being created in the first place,
and second, if that fails, we detect when the voicemail message is
zero-length and avoid exiting at that point.
Reported by: dtyoo
Patch by: gkloepfer,tilghman
(Closes issue #11083)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-24 06:24:46 +00:00
Luigi Rizzo
7e8835e0d7 remove another set of redundant #include "asterisk/options.h"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:24:55 +00:00
Luigi Rizzo
a23c055c3d move asterisk/paths.h outside asterisk.h and into those files
who really need it.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:16:15 +00:00
Luigi Rizzo
0595b5e2aa include "logger.h" and errno.h from asterisk.h - usage shows that they
were included almost everywhere.
Remove some of the instances.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 18:52:04 +00:00