Commit Graph

243 Commits

Author SHA1 Message Date
Russell Bryant 04ecb29d03 remove almost all of the checks of the result from ast_strdupa() or alloca().
As it turns out, all of these checks were useless, because alloca will never
return NULL.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@26451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-10 13:22:15 +00:00
Russell Bryant 4120afc28e put all the QUEUE_STRATEGY values in an enum, and use them in all of the places
in the code where the strategy type is checked, to make the code more readable


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-09 07:27:03 +00:00
BJ Weschke 3780d4e7dd strategy "ringall" is really int value of 0, not 1.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-09 00:21:40 +00:00
BJ Weschke c0186f6b4d Make QueueStatusComplete manager event thread safe by wrapping it inside the already existing Queue Lock clause. #7013 (bziherl reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25523 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:38:14 +00:00
BJ Weschke a7f330a2d2 Merged revisions 25520 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r25520 | bweschke | 2006-05-08 09:15:30 -0400 (Mon, 08 May 2006) | 3 lines

 Oops. :(


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:16:06 +00:00
BJ Weschke 415dff6f2a Merged revisions 25518 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r25518 | bweschke | 2006-05-08 09:11:32 -0400 (Mon, 08 May 2006) | 3 lines

 Don't recheck valid_exit() after getting the result from say_position (which already checks it). Should prevent another loop if the caller hits digits during the position announcement. #6776 (tgj reporting)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25519 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:12:39 +00:00
BJ Weschke 714aab87bb Fix situation for when there is no monitor_option defined, but there is a monitor_exec defined.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 12:30:46 +00:00
BJ Weschke d83bd4d136 Integrate the MixMonitor functionality (introduced in 1.2) as an option for recording queue member conversations with callers. #7084
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25076 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-05 22:02:38 +00:00
BJ Weschke 85e0c889e4 Allow for the execution of an AGI to the caller's channel right before they get bridged with the queue member that is going to take their call. Add the option to set a MEMBERINTERFACE variable on the caller's channel that will contain the interface of the queue member that is going to/did take the call. #6843
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-05 21:22:45 +00:00
Tilghman Lesher 7734d20eb5 Merged revisions 24706 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r24706 | tilghman | 2006-05-04 11:27:20 -0500 (Thu, 04 May 2006) | 2 lines

Bug 7023 - reload should not unpause members

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@24707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-04 16:38:32 +00:00
BJ Weschke 80c34d2a91 Make sure that callers kicked from queue because of joinempty and leavewhenempty have an event logged with regard to the reason for their departure. #6559 (Corydon76)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@24566 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-03 20:47:34 +00:00
BJ Weschke 944c8cc4a6 Log hold time and talktime in queue_log when blind transfers are made by queue members. #7038 (alphaqueue) w/documentation mods added
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@24565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-03 20:31:58 +00:00
BJ Weschke ebb7eee9ce Implement and document RINGNOANSWER queue logging functionality to "tattle" on bad queue members.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@24564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-03 20:14:54 +00:00
BJ Weschke 7b3f3db65d Fix autofill behavior in app_queue and document it's functionality in queues.conf.sample and UPGRADE.txt
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@24543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-03 20:01:30 +00:00
BJ Weschke 857f2e8d41 Record bridge channel unique id in "CONNECT" queue_log entry and the corresponding manager event. #6522 (nording) w/ documentation additions where appropriate
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@24293 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-02 19:18:36 +00:00
Luigi Rizzo 2904c6956d remove unused variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-26 22:45:37 +00:00
Matt O'Gorman 7212fa80ad adds new function QUEUE_WAITING_COUNT and a few
warnings if the queue you are looking for in this 
function and other queue functions is not found.
patch from 7036


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-26 22:04:42 +00:00
Luigi Rizzo 1a6572c4e6 more NULL "" equivalence,
mark a couple of inconsistencies (missing CallerIDnum,
"unknown" instead of "<unknown>") - there are more of the same.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:57:03 +00:00
Luigi Rizzo e43bc6634d This rather large commit changes the way modules are loaded.
As partly documented in loader.c and include/asterisk/module.h,
modules are now expected to return all of their methods and flags
into a structure 'mod_data', and are normally loaded with RTLD_NOW
| RTLD_LOCAL, so symbols are resolved immediately and conflicts
should be less likely.  Only in a small number of cases (res_*,
typically) modules are loaded RTLD_GLOBAL, so they can export
symbols.
 
The core of the change is only the two files loader.c and
include/asterisk/module.h, all the rest is simply adaptation of the
existing modules to the new API, a rather mechanical (but believe
me, time and finger-consuming!) process whose detail you can figure
out by svn diff'ing any single module.

Expect some minor compilation issue after this change, please
report it on mantis http://bugs.digium.com/view.php?id=6968
so we collect all the feedback in one place.

I am just sorry that this change missed SVN version number 20000!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 14:08:19 +00:00
Kevin P. Fleming cf15740eaf remove support for BYEXTENSION (which nobody even knows about anymore)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18977 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 23:01:22 +00:00
Kevin P. Fleming f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Tilghman Lesher 756c7cbb12 Bug 6873 - Finish moving from the non-threadsafe (and poor randomness) rand() to threadsafe ast_random()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 17:44:44 +00:00
Olle Johansson 982a66a93a Issue #6882
- move "res=-1" out of verbose block. 
- minor code cleanup
Imported from 1.2 branch


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 18:02:40 +00:00
Luigi Rizzo c0f2f5b5b8 Normalize some cli completion code.
On passing, replace strdup with ast_strdup() and remove
the now useless checks for NULL since ast_strdup() can handle
it correctly.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@15895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-29 00:30:29 +00:00
Mark Spencer 9164eac21a Add micro-http server and abstract manager interface, make snmp not die
on reload.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@14953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-25 23:50:09 +00:00
Russell Bryant f28abd4020 Merged revisions 12925 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r12925 | russell | 2006-03-14 13:28:39 -0500 (Tue, 14 Mar 2006) | 3 lines

fix a problem with not loading realtime queue members by always reloading a 
realtime queue from the database even if it is found in the list (issue #6680)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12926 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-14 18:30:52 +00:00
Tilghman Lesher 30a806010a Bug 6459 - tell manager when queue is abandoned
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-11 15:17:50 +00:00
Russell Bryant a0d438fb6c remove the uses of the deprecated STANDARD_LOCAL_USER
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 20:11:56 +00:00
Kevin P. Fleming f0495e8944 add option to avoid calling members whose channels are 'in use' (issue #6315, plus documentation)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10163 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 02:52:19 +00:00
Kevin P. Fleming c1e19165b4 add channel's uniqueid to manager 'join' event (issue #6458)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 01:01:35 +00:00
Kevin P. Fleming 2f46cb9198 don't use localuser structure for outbound calls (issue #6216)
various code cleanup and reorganization (issue #6216)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10046 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-14 21:50:35 +00:00
Kevin P. Fleming 918cab0e08 Merged revisions 9961,9964,9990,10018 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r10018 | kpfleming | 2006-02-14 14:20:15 -0600 (Tue, 14 Feb 2006) | 2 lines

don't double-increment abandon counter for calls that are hung up while dialing members (issue #6289)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-14 20:21:38 +00:00
Russell Bryant 2f2530b8e6 remove LOCAL_USER_ACF_ADD since it is now the same as LOCAL_USER_ADD
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-13 20:12:50 +00:00
Kevin P. Fleming 96bf384e7d major dialplan functions update
deprecate LANGUAGE() and MUSICCLASS(), in favor of CHANNEL()


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-12 04:28:58 +00:00
Kevin P. Fleming a16ae226b6 use string fields for some stuff in ast_channel
const-ify some more APIs
remove 'type' field from ast_channel, in favor of the one in the channel's tech structure
allow string field module users to specify the 'chunk size' for pool allocations
update chan_alsa to be compatible with recent const-ification patches


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-01 23:05:28 +00:00
Matt O'Gorman 83ab52cdc4 changed some settings to app_args and some code
cleaning patch 6267


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-23 17:23:22 +00:00
Russell Bryant 72a2e892bc fix memory leak from not freeing the list of queue members when freeing a queue
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8447 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-22 19:09:50 +00:00
Tilghman Lesher 56bb41460e Bug 6312 - Macro janitor
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-22 17:28:42 +00:00
Russell Bryant 4414f45393 on this pass, only remove duplicate log messages
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 20:57:06 +00:00
Tilghman Lesher 41c87ccb97 Bug 5936 - Cannot AddQueueMember on realtime queue, if queue not yet loaded (different fix than 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 20:32:17 +00:00
Russell Bryant 9fa6eb5e07 revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8387 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 17:50:04 +00:00
Russell Bryant 7ad681adc8 remove lots of useless checks of the result of ast_strdupa
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 08:13:12 +00:00
Russell Bryant cb8bd57a21 Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue #6302)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-20 18:40:24 +00:00
Russell Bryant 6f71e1178e constify arguments in more places where strings should not be modified (issue #6286)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8203 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-18 22:17:31 +00:00
Matt O'Gorman 90b4d8b9be oops all better now.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8153 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-17 21:10:38 +00:00
Matt O'Gorman 24c4e062cc allow for multiple periodic announcements
from bug 5273 with minor changes.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-17 20:58:56 +00:00
BJ Weschke 3854a2438e Spelling corrections (mostly in comments and doxygen areas) #6249
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8100 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-16 17:37:44 +00:00
Matt O'Gorman 58bac05e59 Added QUEUE_MEMBER_COUNT and QUEUE_MEMBER_LIST
from bug 5451


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-13 22:59:19 +00:00
Russell Bryant 55c8fc92a9 Various cleanups from comments in an email from Luigi Rizzo. Thank you!
- Use a cleaner syntax for declaring the allocation macros
- Fix return value for ast_strdup/ast_strndup
- remove safe_strdup from app_macro, since ast_strup does the same thing
- fix a place in app_queue where ast_calloc+strncpy was used instead of
  ast_strdup.  If you are helping out with these conversions, please watch out
  for other places where this is done.
- add a note to the coding guidelines about the fix to app_queue


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-13 18:38:55 +00:00
Matt O'Gorman 130ce286ba added two new features to meetme, autofill and
autopause.  thanks twisted from 5577


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-13 17:39:56 +00:00