Commit graph

63 commits

Author SHA1 Message Date
Richard Mudgett
9d81fc3273 Fix compile of chan_ooh323.c from IPv6 integration.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 23:23:17 +00:00
Mark Michelson
cd4ebd336f Add IPv6 to Asterisk.
This adds a generic API for accommodating IPv6 and IPv4 addresses
within Asterisk. While many files have been updated to make use of the
API, chan_sip and the RTP code are the files which actually support
IPv6 addresses at the time of this commit. The way has been paved for
easier upgrading for other files in the near future, though.

Big thanks go to Simon Perrault, Marc Blanchet, and Jean-Philippe Dionne
for their hard work on this.

(closes issue #17565)
Reported by: russell
Patches: 
      asteriskv6-test-report.pdf uploaded by russell (license 2)

Review: https://reviewboard.asterisk.org/r/743



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 22:08:07 +00:00
Tzafrir Cohen
c613897d1c Fix various typos reported by Lintian
(Also fix the typos in the comments)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@273641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-02 15:57:02 +00:00
Matthew Nicholson
57d9f8e42d Don't free written frames in chan_mobile's mbl_write() function.
(closes issue #16430)
Reported by: azbest
Tested by: azbest



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@273312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-01 12:57:18 +00:00
Bradley Latus
4405813297 Add High Resolution Times to CDRs for Asterisk
People expressed an interest in having access to the exact length of calls to a finer degree than seconds. See the CHANGES and UPGRADE.txt for usage also updated the sample configs to note the change.

Patch by snuffy.

(closes issue #16559)
Reported by: cianmaher
Tested by: cianmaher, snuffy

Review: https://reviewboard.asterisk.org/r/461/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@269153 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-08 23:48:17 +00:00
Tzafrir Cohen
f14e56249a Typos: 'succesful' (lintian)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@265525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-25 08:31:51 +00:00
Alexandr Anikin
45895dc320 small changes to avoiding 'freeing unused memory...'
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@265227 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-23 18:23:38 +00:00
Tilghman Lesher
6a683a1ee8 Fix build on Linux
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-07 22:09:09 +00:00
Alexandr Anikin
5df6473067 additional checking related to issue 17186
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258855 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-25 18:51:37 +00:00
Alexandr Anikin
91da9be765 Don't pass zero length callerid to ooh323 stack
Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(closes issue #17186)
Reported by: vmikhelson
Patches:
      zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258838 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-25 18:34:29 +00:00
Alexandr Anikin
89e4c15783 corrections in gk interface, small fixes in call clearing.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@255199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-27 23:51:13 +00:00
Kevin P. Fleming
fff17a25dd Use "local" instead of "system" header file inclusion.
Now that these files are in the tree, they should prefer the tree's local
copy of all Asterisk headers over any that may be installed.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@254931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-25 23:38:58 +00:00
Russell Bryant
0ec49aa381 Fix a number of other build problems on Mac OS X.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@254884 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-25 21:39:04 +00:00
Russell Bryant
c23ff728ea Resolve compiler warning on FreeBSD.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@254801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-25 20:41:34 +00:00
Russell Bryant
b69245f8e3 Fix chan_ooh323 so it works on Mac OS X, as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@254799 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-25 20:40:48 +00:00
Kevin P. Fleming
66dd3e295d Get chan_ooh323 building again after recent build system changes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@254636 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-25 18:34:32 +00:00
Alexandr Anikin
fa9d6969d6 generate roundtrip delay requests and responses
added response to roundtrip delay requests from opposite side
added roundtrip delay request sending to opposite side after answer,
added options for sending request (interval between request and 
count of unreplied requests before forced call hangup)

(closes issue #16976)
Reported by: vmikhelson
Patches:
      rtdr-1.6.0-2.patch uploaded by may213 (license 454)
Tested by: vmikhelson, may213



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-14 14:42:59 +00:00
Terry Wilson
68d1ded8dd Only change the RTP ssrc when we see that it has changed
This change basically reverts the change reviewed in
https://reviewboard.asterisk.org/r/374/ and instead limits the
updating of the RTP synchronization source to only those times when we
detect that the other side of the conversation has changed the ssrc.

The problem is that SRCUPDATE control frames are sent many times where
we don't want a new ssrc, including whenever Asterisk has to send DTMF
in a normal bridge. This is also not the first time that this mistake
has been made. The initial implementation of the ast_rtp_new_source
function also changed the ssrc--and then it was removed because of
this same issue. Then, we put it back in again to fix a different
issue. This patch attempts to only change the ssrc when we see that
the other side of the conversation has changed the ssrc.

It also renames some functions to make their purpose more clear.

Review: https://reviewboard.asterisk.org/r/540/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-12 22:04:51 +00:00
Alexandr Anikin
9c946df4c8 small log issue from bug 0016664
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-07 00:45:35 +00:00
Alexandr Anikin
13d7c1e6bd generate connected line info update from info in h.323 packets
Tested by: benngard



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-16 22:58:22 +00:00
Alexandr Anikin
9a980d4822 small corrections in call clearing
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-25 21:20:02 +00:00
Alexandr Anikin
d48fe3c81d AST_CONTROL_CONNECTED_LINE frame type processing added to setup DisplayIE field
incorrect q.931 message order filtered on incoming calls (first msg must be setup, 
next must be not setup)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-24 22:42:11 +00:00
Tilghman Lesher
b4504ada8b Permit dates and times to be stored in timezones other than the default (typically, UTC)
(closes issue #16401)
 Reported by: lordmortis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 21:03:46 +00:00
Tilghman Lesher
9c1b53cab4 According to POSIX, the capital L modifier applies only to floating point types.
Fixes a crash on Solaris.
(closes issue #16572)
 Reported by: crjw
 Patches: 
       frame_changes.patch uploaded by crjw (license 963)
       Plus several others found and fixed by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239074 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-10 19:37:30 +00:00
Alexandr Anikin
11e1780402 add docallbacks flag in q931decode function because
when we decode received q931 packet we must do callbacks and
when we print sended q931 packet we must not. 


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-10 17:53:59 +00:00
Sean Bright
f0190a1092 Fix reading samples from format_mp3 after ast_seekstream/ast_tellstream.
There is a bug when using ast_seekstream/ast_tellstream with format_mp3 in that
the file read position is not reset before attempting to read samples.  So when
we seek to determine the maximum size of the file (as in res_agi's STREAM FILE)
we weren't then resetting the file pointer so that we could properly read
samples.  This patch addresses that (in a similar manner to format_wav.c).

(closes issue #15224)
Reported by: rbd
Patches:
      20091230_addons_1.4_issue15224.diff uploaded by seanbright (license 71)
Tested by: rbd, seanbright

Review: https://reviewboard.asterisk.org/r/453


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238014 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-06 15:35:43 +00:00
Alexandr Anikin
c032901aae small q931 processing and signalling corrections
don't decode UUIE from Q931StatusMessage
clean call without callIdentifier data
don't start tcs/msd exchange procedure after call proceeding received

(closes issue #16365)
Reported by: benngard2
Tested by: may213, benngard2



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237098 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-30 23:51:32 +00:00
Tilghman Lesher
80cb88e1f8 Typo pointed out on #asterisk-dev (by atis_work)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233732 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-08 18:40:19 +00:00
Tilghman Lesher
494647fbe7 Update the mysql driver to always return NULL columns, as this is needed for the realtime API to work correctly.
(closes issue #16138)
 Reported by: sohosys
 Patches: 
       20091029__issue16138.diff.txt uploaded by tilghman (license 14)
 Tested by: sohosys


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 16:08:58 +00:00
Alexandr Anikin
4d19e3eb4b jitterbuffer setup correction
correction of double pointer references from previous rev


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@232853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-03 20:26:55 +00:00
Matthew Nicholson
546416ff4b Fix support for multiline SMS messages in chan_mobile.
(closes issue #16278)
Reported by: Artem
Patches: 
      multiline-sms-fix2.diff uploaded by mnicholson (license 96)
Tested by: Artem


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@232580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 21:37:18 +00:00
Matthew Nicholson
6c926bca38 Do something with the service indicator so that asterisk does not attempt to use a chan_mobile endpoint that does not have service.
(closes issue #16132)
Reported by: nikkk
Patches: 
      service-indicator2.diff uploaded by mnicholson (license 96)
Tested by: nikkk


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@232544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 21:13:02 +00:00
Tilghman Lesher
f59fe83c56 More 32->64 bit codec conversions.
In the process of swapping ULAW to a place in the extended codec space, we
found several unhandled cases, where a 32-bit integer was still being used to
handle a codec field.  Most of these have been fixed with this commit, although
there is at least one case (codec_dahdi) which depends upon outside headers to
be altered before a conversion can be made.
(Fixes AST-278, SWP-459)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-01 20:27:37 +00:00
Olle Johansson
5fcf1c9268 If CDR logging is disabled, it's considered a FAILURE
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229840 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 09:22:04 +00:00
Tilghman Lesher
c0b3c923a4 Fix various problems detected with Valgrind.
* chan_console accessed pvts after deallocation.
 * cdr_mysql stored a pointer that was freed by realloc()
 * The module loader did not check usecount on shutdown, which led to chan_iax2
 reading a timer that was already unloaded.
 * The event subsystem sometimes creates an event with no IEs.  Due to a corner
 condition, the code would read beyond the memory boundary.
 * res_pktccops did not correctly check whether its monitor thread was started.
(closes issue #16062)
 Reported by: alexanderheinz
 Patches: 
       20091109__issue16062.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-09 07:37:52 +00:00
Mark Michelson
341c7b60dd Make compilation of chan_ooh323 disabled by default.
All addons modules should be disabled by default, requiring the
user to turn them on if desired. After all, these are addons we're
talking about here.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228659 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 22:02:36 +00:00
Mark Michelson
fbe477ea50 Get chan_ooh323 to compile with gcc 4.2.
For some reason, the code compiles just fine with later versions
of GCC, but this one requires some weird double casting in order
to get rid of all warnings. Whatever.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228658 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 22:00:12 +00:00
Tilghman Lesher
c17525391b Missed these two channel drivers on the codec_bits merge
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 19:38:33 +00:00
Jeff Peeler
f999554af7 Update chan_ooh323 to support the expanded codec bitfield from 227580.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227914 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 22:22:51 +00:00
Alexandr Anikin
9530310954 Reworked chan_ooh323 channel module.
Many architectural and functional changes.
Main changes are threading model chanes (many thread in ooh323 stack
instead of one), modifications and improvements in signalling part,
additional codecs support (726, speex), t38 mode support.
This module tested and used in production environment.

(closes issue #15285)
Reported by: may213
Tested by: sles, c0w, OrNix

Review: https://reviewboard.asterisk.org/r/324/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 22:10:44 +00:00
Tilghman Lesher
8f336e3d01 Fix trunk building
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:13:50 +00:00
Russell Bryant
cea6ee4143 Fix audio problems with format_mp3.
This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue #15850)
Reported by: 99gixxer
Patches:
      issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-08 18:06:57 +00:00
Russell Bryant
078b0b0eff Fix memory corruption caused by format_mp3.
format_mp3 claimed that it provided AST_FRIENDLY_OFFSET in frames returned by
read().  However, it lied.  This means that other parts of the code that
attempted to make use of the offset buffer would end up corrupting the fields
in the ast_filestream structure.  This resulted in quite a few crashes due to
unexpected values for fields in ast_filestream.

This patch closes out quite a few bugs.  However, some of these bugs have been
open for a while and have been an area where more than one bug has been
discussed.  So with that said, anyone that is following one of the issues
closed here, if you still have a problem, please open a new bug report for the
specific problem you are still having.  If you do, please ensure that the bug
report is based on the newest version of Asterisk, and that this patch is
applied if format_mp3 is in use.  Thanks!

(closes issue #15109)
Reported by: jvandal
Tested by: aragon, russell, zerohalo, marhbere, rgj

(closes issue #14958)
Reported by: aragon

(closes issue #15123)
Reported by: axisinternet

(closes issue #15041)
Reported by: maxnuv

(closes issue #15396)
Reported by: aragon

(closes issue #15195)
Reported by: amorsen
Tested by: amorsen

(closes issue #15781)
Reported by: jensvb

(closes issue #15735)
Reported by: thom4fun

(closes issue #15460)
Reported by: marhbere


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-01 20:44:13 +00:00
Tilghman Lesher
e25ca31589 Select uncommented lines, not commented ones.
(closes issue #15746)
 Reported by: makoto


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-20 15:29:53 +00:00
Tilghman Lesher
ed7bc8d72f Clarify some of the error messages, to help upgraders.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-18 19:49:52 +00:00
Tilghman Lesher
642bec4d6f AST-2009-005
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-10 19:20:57 +00:00
Matthew Nicholson
d0664ba6af Add an 'sms' option to mobile.conf to manually enable or disable SMS support.
(closes issue #15071)
Reported by: ughnz
Patches:
      optional-sms1.diff uploaded by mnicholson (license 96)
Tested by: ughnz, mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-03 14:01:39 +00:00
David Brooks
48363c16e1 Fixes numerous spelling errors. Patch submitted by alecdavis.
(closes issue #15595)
Reported by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-30 16:07:05 +00:00
Matthew Nicholson
6568cd6aa8 This patch adds the ability to send a CUSD command to a bluetooth device.
(closes issue #15278)
Reported by: Artem
Patches:
      cusd5.patch uploaded by Artem (license 800)
Tested by: mnicholson, Artem

Review: https://reviewboard.asterisk.org/r/274/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-29 21:46:17 +00:00
Matthew Nicholson
0cff13075f Fixed a comment for hfp_parse_clip
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209453 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-29 21:13:42 +00:00