Commit Graph

19064 Commits

Author SHA1 Message Date
Tilghman Lesher baca4c6437 Found a few places where queue refcounts were counted incorrectly. Also add debug statements.
(closes issue #15982, closes issue #15984)
 Reported by: atis
 Patches: 
       20091111__issue15982.diff.txt uploaded by tilghman (license 14)
 Tested by: atis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-24 20:31:28 +00:00
Jeff Peeler c10288ec01 Fix erroneous hangup extension execution
ast_spawn_extension behaves differently from 1.4 in that hangups and extensions
that do not exist do not return an error, whereas in 1.6 it does. This is now 
taken into account so that the AST_FLAG_BRIDGE_HANGUP_RUN flag gets set
properly.

(closes issue #16106)
Reported by: ajohnson
Tested by: ajohnson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-24 18:50:36 +00:00
Jeff Peeler ac9a4cecf3 Fix problem on digital channels due to digital flag not getting set
Changed areas in sig_pri to set the digital flag using a callback that will
also set the corresponding flag in chan_dahdi. Modified dahdi_request slightly
so that if a bearer is marked as digital, that information is available when
creating the new channel.

(closes issue #16151)
Reported by: alecdavis
Patch based on bug_16151.diff.txt uploaded by alecdavis (license 585)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231058 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-24 17:12:25 +00:00
Matthew Nicholson 1c7dd506d6 Updated CHANGES file to describe the new 'd' option to app_followme added in r230964
(related to issue #14155)
Reported by: junky


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231025 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-24 13:52:21 +00:00
Tilghman Lesher 0bccc4fbe6 Add REPLACE & PASSTHRU functions, overhaul of func_strings, fix API docs for the ast_get_encoded_* functions.
* Add REPLACE function, which searches a given variable for a set of
   characters and replaces each with a given character.
 * Add PASSTHRU function, which passes a literal string back, like a NoOp for
   functions.  Intent is to be able to specify a literal string to another
   function that takes a variable name as an argument.
 * Let the array manipulation functions work with dialplan functions, in
   addition to variables.  This allows the array manipulation functions to
   modify ASTDB and ODBC backends, assuming the func_odbc configuration has
   both read and write functions.
(closes issue #15223)
 Reported by: ajohnson
Patches: 
       20091112__issue15223.diff.txt uploaded by tilghman (license 14)
 Tested by: lmadsen, tilghman


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-24 04:58:44 +00:00
Matthew Nicholson 606276ec48 Add an option to app_followme to disable the "please hold" announcement.
(closes issue #14155)
Reported by: junky
Patches:
      M14555-trunk.diff uploaded by junky (license 177) (modified)
Tested by: junky


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 22:37:39 +00:00
Joshua Colp 60e10aba46 Change fax detection in chan_sip so it behaves as one would expect.
Internally the way T.38 is negotiated has changed and the option no longer
reflects a behavior that is valid. It will now look for a CNG tone on
received calls and if present send the call to the 'fax' extension. It is
then up to the application or channel to request the switch over to T.38.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230881 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 15:45:45 +00:00
Kevin P. Fleming fe1ebc8d46 Merged revisions 230839 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230839 | kpfleming | 2009-11-23 09:09:24 -0600 (Mon, 23 Nov 2009) | 1 line
  
  Correct fix for issue #16268... the reporter's original patch was very close to correct.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230877 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 15:34:16 +00:00
Kevin P. Fleming 9d0319f88f Blocked revisions 230875 via svnmerge
........
  r230875 | kpfleming | 2009-11-23 09:31:02 -0600 (Mon, 23 Nov 2009) | 7 lines
  
  When 'sip set debug' is enabled, and the last line of an incoming SIP message
  is not properly newline terminated, ensure that that line is included in the
  debug output.
  
  (part of issue #16268)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230876 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 15:33:02 +00:00
Kevin P. Fleming 1f759eddfa Merged revisions 230772 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5 lines
  
  Ensure that SDP parsing does not ignore the last line of the SDP.
  
  (closes issue #16268)
  Reported by: sgimeno
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 14:15:48 +00:00
David Vossel 417657f4ed fixes iax2 show cache locking error, thanks alecdavis!
(closes issue #16094)
Reported by: alecdavis
Patches:
      bug16094.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, dvossel


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-20 22:35:54 +00:00
Tilghman Lesher b6378e07d7 Revert code in error and include the gcc suggested workaround for the original problem, while gcc investigates.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-20 21:47:39 +00:00
Matthew Nicholson cab2253d34 Merged revisions 230627 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230627 | mnicholson | 2009-11-20 14:53:06 -0600 (Fri, 20 Nov 2009) | 8 lines
  
  Copy the peer CDR's userfield to the bridge CDR if it exists.  This is necessary for the recordagentcalls option in chan_agent to store the recorded file name in the bridge CDR.
  
  (closes issue #14590)
  Reported by: msetim
  Patches:
        queue_agent_userfield.patch uploaded by Laureano (license 265)
  Tested by: Laureano, mnicholson
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-20 21:01:10 +00:00
David Ruggles 6e27759d33 Fix/Implement error events for non-existing files
also include a better cmd define for S command

Review: https://reviewboard.asterisk.org/r/430/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-20 17:28:01 +00:00
David Vossel 3595fbb70c audiohook signal trigger on every status change
(issue #14618)

Review: https://reviewboard.asterisk.org/r/434/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230583 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-20 17:26:20 +00:00
David Vossel eb6025a49a Merged revisions 230508 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230508 | dvossel | 2009-11-19 15:22:46 -0600 (Thu, 19 Nov 2009) | 10 lines
  
  fixes MixMonitor thread not exiting when StopMixMonitor is used
  
  (closes issue #16152)
  Reported by: AlexMS
  Patches:
        stopmixmonitor_1.4.diff uploaded by dvossel (license 671)
  Tested by: dvossel, AlexMS
  
  Review: https://reviewboard.asterisk.org/r/424/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-19 21:26:21 +00:00
David Ruggles 8d9a12a60a Basic cleanup of ExternalIVR: cleaned up argument parsing; implemented good coding practices where applicable; replaced most notice level logging with verbose logging; replaced warning messages that terminated with error messages; fixed memory leak identified by russellb
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230438 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-19 14:53:58 +00:00
Kevin P. Fleming 80fc9540f9 Fix another buglet in T.38 session teardown at the end of FAX sessions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230381 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-16 16:40:25 +00:00
Kevin P. Fleming 237795f6d7 Ensure that only one end of a T.38 session initiates teardown at completion.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-16 12:51:59 +00:00
TransNexus OSP Development 9a707c9b37 1. Added SIP Diversion support.
2. Fixed compile warning for UUID.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-16 01:49:41 +00:00
Kevin P. Fleming 209e1cf195 Merged revisions 230246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230246 | kpfleming | 2009-11-15 11:19:06 -0600 (Sun, 15 Nov 2009) | 6 lines
  
  Correct mistaken option name in error message.
  
  The configuration option for allowing hosts to make non-token-based calls
  is 'calltokenoptional', not 'calltokenignore'. (reported on asterisk-users)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-15 17:23:02 +00:00
Tilghman Lesher f4d50dc70d Increase maximum length of language buffers
(closes issue #16217)
 Reported by: dsessions


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230217 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-15 07:53:16 +00:00
Joshua Colp 8ba56154bb Merged revisions 230144 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230144 | file | 2009-11-13 16:00:19 -0600 (Fri, 13 Nov 2009) | 8 lines
  
  Respect the maddr parameter in the Via header.
  
  (closes issue #14446)
  Reported by: frawd
  Patches:
        via_maddr.patch uploaded by frawd (license 610)
  Tested by: frawd
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230145 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 22:00:44 +00:00
Tilghman Lesher 5e2aa190fe Display a list of channel variables in each channel-oriented event.
(Closes AST-33)
Reviewboard:	https://reviewboard.asterisk.org/r/368/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 20:42:03 +00:00
Joshua Colp 85dd68ca7a Merged revisions 230038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230038 | file | 2009-11-13 13:44:07 -0600 (Fri, 13 Nov 2009) | 9 lines
  
  Fix a crash caused by two threads thinking they should both free the
  chan_local private structure when only one should.
  
  (closes issue #15314)
  Reported by: sroberts
  Patches:
        Issue15314_Move_Nulling_owner.patch uploaded by davidw (license 780)
  Tested by: davidw, lottc
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230039 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 19:44:53 +00:00
Joshua Colp f62d03a8f3 Store the cause code that is returned when trying to create a channel in ChanIsAvail in the
AVAILCAUSECODE dialplan variable instead of overwriting the device state in AVAILSTATUS.

(closes issue #14426)
Reported by: macli


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229970 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 17:22:47 +00:00
Joshua Colp 23a0da332b Merged revisions 229965 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229965 | file | 2009-11-13 11:19:59 -0600 (Fri, 13 Nov 2009) | 6 lines
  
  Document a limitation in the AVAILSTATUS variable from ChanIsAvail and provide
  a workaround for it that does not change existing behavior.
  
  (closes issue #14426)
  Reported by: macli
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229966 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 17:20:26 +00:00
Joshua Colp b3b6537e71 Fix T.38 negotiation regression introduced with the SDP parser changes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229912 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 15:56:16 +00:00
Olle Johansson ebc3aff1c3 Fixing trunk in a way so that it compiles again.
Thanks, Philippe :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 10:53:14 +00:00
Olle Johansson 5fcf1c9268 If CDR logging is disabled, it's considered a FAILURE
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229840 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 09:22:04 +00:00
Olle Johansson 75c015bfff Add the capability to require a module to be loaded, or else Asterisk exits.
Review: https://reviewboard.asterisk.org/r/426/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 08:52:28 +00:00
TransNexus OSP Development 8016a55636 Added full number portability parameter support.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 03:16:39 +00:00
Jason Parker 33fedbdb54 Update sample config for ALSA mute and noaudiocapture
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 23:43:28 +00:00
Jason Parker 02087fe03d Add mute functionality. Add config option to not try to open capture device.
Adds "console {mute|unmute}" CLI command.
Adds mute and noaudiocapture config options (will update sample configs shortly).

(closes issue #14673)
Reported by: Nick_Lewis
Patches:
      chan_alsa.c-oneway3.patch uploaded by Nick Lewis (license 657)
Tested by: qwell


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229753 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 23:37:36 +00:00
Jason Parker e1ec2df832 Fix mute toggling on OSS channels.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 23:30:10 +00:00
David Vossel a1037d3d7e Merged revisions 229669 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229669 | dvossel | 2009-11-12 10:41:49 -0600 (Thu, 12 Nov 2009) | 6 lines
  
  fixes merging error, datastore was being freed in the wrong function.
  
  (closes issue #16219)
  Reported by: aragon
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229670 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 16:44:39 +00:00
Leif Madsen e7c7dac8a9 Update sip.conf.sample.
Just updating a spelling error and some capitalization in a
documentation update that Olle added. May the Swenglish be
with you.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 13:54:45 +00:00
Olle Johansson 8e583db28f Clarification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 10:24:20 +00:00
Olle Johansson cca751350a Clarify some security issues early in the sample configuration
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 10:22:30 +00:00
David Ruggles 91b9c8fca1 Remove non-functional feature from ExternalIVR documentation
Remove non-functional socket implementation of ExternalIVR from documentation

(closes issue #16225)
Reported by: thedavidfactor
Patches:
      externalivr.txt.20091111.1542.patch uploaded by thedavidfactor (license 903)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-11 20:47:06 +00:00
David Brooks bac499e521 Merged revisions 229498 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229498 | dbrooks | 2009-11-11 13:46:19 -0600 (Wed, 11 Nov 2009) | 8 lines
  
  Solaris doesn't like NULL going to ast_log
  
  Solaris will crash if NULL is passed to ast_log. This simple patch simply uses S_OR to
  get around this.
  
  (closes issue #15392)
  Reported by: yrashk
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229499 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-11 19:48:18 +00:00
David Brooks c5990d41bb Flags not initialized in app_softhangup.c, causing undefined behavior
Trivial patch [kobaz] to initialize an ast_flags = {0}

(closes issue #16129)
Reported by: kobaz


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229460 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-11 18:13:56 +00:00
Leif Madsen 0ce378d3da Update CHANGES file.
Updating the CHANGES file after noticing an email on the asterisk-dev mailing
list from Russell.

(issue #15874)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-11 14:30:04 +00:00
Tilghman Lesher 4c8319190b Merged revisions 229360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229360 | tilghman | 2009-11-10 16:09:16 -0600 (Tue, 10 Nov 2009) | 12 lines
  
  If two pattern classes start with the same digit and have the same number of characters, they will compare equal.
  The example given in the issue report is that of [234] and [246], which have
  these characteristics, yet they are clearly not equivalent.  The code still
  uses these two characteristics, yet when the two scores compare equal, an
  additional check will be done to compare all characters within the class to
  verify equality.
  (closes issue #15421)
   Reported by: jsmith
   Patches: 
         20091109__issue15421__2.diff.txt uploaded by tilghman (license 14)
   Tested by: jsmith, thedavidfactor
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 22:14:22 +00:00
David Ruggles baee8b9a54 Merged revisions 229355 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229355 | diruggles | 2009-11-10 16:45:15 -0500 (Tue, 10 Nov 2009) | 9 lines
  
  Fix ExternalIVR Documentation
  
  Remove documentation for event that doesn't function
  
  (closes issue #16220)
  Reported by: thedavidfactor
  Patches:
        externalivr.txt.20091110.1622.patch uploaded by thedavidfactor (license 903)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229356 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 22:01:50 +00:00
Tilghman Lesher 423d4b8278 When GOSUB is invoked within an AGI, it may not exit correctly.
(closes issue #16216)
 Reported by: atis
 Patches: 
       20091110__atis_work.diff.txt uploaded by tilghman (license 14)
 Tested by: atis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 21:22:50 +00:00
Joshua Colp 9c807da785 Merged revisions 229281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229281 | file | 2009-11-10 16:03:14 -0400 (Tue, 10 Nov 2009) | 8 lines
  
  Remove broken support for direct transcoding between G.726 RFC3551 and G.726 AAL2.
  
  On some systems the translation core would actually consider g726aal2 -> g726 -> signed linear
  to be a quicker path then g726aal2 -> signed linear which exposed this problem.
  
  (closes issue #15504)
  Reported by: globalnetinc
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229282 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 20:06:13 +00:00
David Ruggles 00b269af48 Merged revisions 229191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229191 | diruggles | 2009-11-10 12:23:59 -0500 (Tue, 10 Nov 2009) | 11 lines
  
  Document ExternalIVR event tag collision
  
  ExternalIVR uses the D tag for two different event types. This documents that
  behavior and how to differentiate between the two cases. Also includes a minor
  spelling fix and clarification
  
  (closes issue #16211)
  Reported by: thedavidfactor
  Patches:
        externalivr.txt.20091109.1507.patch uploaded by thedavidfactor (license 903)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229228 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 17:33:47 +00:00
David Vossel 60f80e5360 Merged revisions 229167 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229167 | dvossel | 2009-11-10 11:15:57 -0600 (Tue, 10 Nov 2009) | 9 lines
  
  don't crash on log message in solaris
  
  AST-2009-006
  
  (closes issue #16206)
  Reported by: bklang
  Tested by: bklang
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 17:16:49 +00:00
Matthew Nicholson 2cc2bade4b Reverted revision 201717.
(closes issue 0016175)
Reported by: paul-tg


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 15:53:52 +00:00