Commit Graph

4697 Commits

Author SHA1 Message Date
Luigi Rizzo ce7120b7d5 remove a DEBUG_THREADS message that accesses private lock fields.
If needed, the code to extract this information should be implemented
in some generic header or library and the function called here.

(closed bug #11362)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-24 13:57:46 +00:00
Luigi Rizzo 1a38b870cd put in the necessary hooks for video support in the console.
This is a NOP as far as the current code is concerned,
but there is already support in ./configure and the
Makefiles for the various libraries used by console_video.c
(not yet in the tree) so addition is trivial.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-23 15:54:13 +00:00
Luigi Rizzo 87b633b71e set rtpmap video info according to what is read from SDP;
make the format explicit in a debug message;

print the audio instead of aggregated peer capability in a debugging msg.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-23 15:49:40 +00:00
Steve Murphy 86476c607f closes issue #11285, where an unload of a module that creates a dialplan context, causes a crash when you do a 'dialplan show' of that context. This is because the registrar string is defined in the module, and the stale pointer is traversed. The reporter offered a patch that would always strdup the registrar string, which is practical, but I preferred to destroy the created contexts in each module where one is created. That seemed more symmetric. There were only 6 place in asterisk where this is done: chan_sip, chan_iax2, chan_skinny, res_features, app_dial, and app_queue. The two apps destroyed the context, but left the contexts. All is fixed now and unloads should be dialplan friendly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:54:12 +00:00
Luigi Rizzo 7e8835e0d7 remove another set of redundant #include "asterisk/options.h"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:24:55 +00:00
Matthew Fredrickson 27dc9e7c70 Remove unneccessary explicit case for BRI
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89510 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:37:25 +00:00
Matthew Fredrickson 9f0859d19d Take some debug code out :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:34:45 +00:00
Matthew Fredrickson 0643a7ccff Add BRI support to chan_zap
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:07:55 +00:00
Russell Bryant 192252ec58 fix a small gramatical error in a comment
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89488 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 18:24:23 +00:00
Russell Bryant 6d8d66e9e7 Fix some code that was supposed to ensure that a buffer was terminated, but was
writing to the wrong byte.  Also, remove some non-thread safe test code.

(closes issue #11317)
Reported by: IgorG
Patches:
      unistim-2.patch uploaded by IgorG (license 20)
	  - additional changes by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 16:24:17 +00:00
Kevin P. Fleming 296fe3e1fb get this to actually compile...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89481 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 15:45:56 +00:00
Luigi Rizzo 83eabfda55 remove this file, it is not used anywhere.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 08:28:27 +00:00
Luigi Rizzo a23c055c3d move asterisk/paths.h outside asterisk.h and into those files
who really need it.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:16:15 +00:00
Luigi Rizzo 6938f4b2b0 Fix building of modules under cygwin.
After this commit we can actually load modules under windows,
and we can start debugging more interesting problems related
to the load order and functionality of modules.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89454 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 16:12:10 +00:00
Joshua Colp 564e0815b6 Include the compatibility header file in ast_h323.cxx for compatibility reasons.
(closes issue #11311)
Reported by: falves11


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89447 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 14:49:32 +00:00
Olle Johansson 28531cde08 Fix sip show history.
Closes issue #11312


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 14:44:26 +00:00
Olle Johansson 308646f8ef Change terminology a bit for CLI commands handling SIP channels/calls/dialogs/whatever.
Closes issue #11312


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 08:36:32 +00:00
Mark Michelson fb3b4f4937 Changed the "busy-level" option in sip.conf to "busylevel" to be more parallel
with the SIPPEER() argument of the same name. The deprecation procedure is not
being used here since this is a trunk-only option.

(closes issue #11307, reported by pj, patched by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89441 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 23:24:35 +00:00
Luigi Rizzo ed9b9733b6 another few errno.h removals
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 21:18:14 +00:00
Tilghman Lesher 0aa40f1366 Change delimiter of SIPPEER to be comma (instead of pipe) and further deprecate the old ':' delimiter
Reported by: pj
Patch by: tilghman
Closes issue #11305


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89429 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 20:13:40 +00:00
Luigi Rizzo 0595b5e2aa include "logger.h" and errno.h from asterisk.h - usage shows that they
were included almost everywhere.
Remove some of the instances.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 18:52:04 +00:00
Olle Johansson 743d3774d7 Adding busy-level to the SIP_PEER() dialplan function.
With this, you can control the peer in the dialplan, so you avoid placing outbound
calls when the device has reached busy-level.
Reported by pj.

Closes bug #11180



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89406 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 09:12:27 +00:00
Olle Johansson 1dc6524449 Make some notes about a problem I found with the OPTIONs handler while working with
the bug tracker. Since we don't authenticate devices (peers/users) on OPTIONS we don't
have the proper context set for the user/peer. 

However, we might not want to process an authentication for every OPTIONS, so we could
have a config option for this, "optionsforceok" to always answer 200 OK on the request
and not check device or destination, nor add a SDP. If Asterisk sends the OPTIONs request,
it doesn't care about the reply. Some devices use OPTIONs to discover capabilities,
since we should answer like an INVITE from the device and we need to support that properly
too, which we don't today.

So much to do :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89404 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 08:34:26 +00:00
Matthew Fredrickson 19460802ef Add SS7 Generic address support (#11156)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89393 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 21:47:48 +00:00
Luigi Rizzo 1e6489a175 trim more redundant headers
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 16:18:53 +00:00
Luigi Rizzo 5663ff6518 fix breakage induced by previous mistake
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 14:45:46 +00:00
Luigi Rizzo 270b6d978b filter out modules that do not compile under windows
(this should be handled with the dependencies generated by
configure and menuselect, but will be fixed later)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 09:48:45 +00:00
Luigi Rizzo d82a631f9c more removal of duplicate #include lines
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 00:02:33 +00:00
Luigi Rizzo 5490960453 remove a bunch of duplicate includes
Reproduce with

grep -r #include . | grep -v .svn | grep -v Binary | sort | uniq -c | sort -nr 



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 23:54:45 +00:00
Luigi Rizzo 4afe3b5ba9 remove redundant #include "asterisk/compat.h",
but make sure that asterisk/compiler.h is included everywhere



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89336 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 21:08:28 +00:00
Luigi Rizzo fdb7f7ba3d Start untangling header inclusion in a way that does not affect
build times - tested, there is no measureable difference before and
after this commit.

In this change:

use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h

Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.

Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better. 

For the time being I have left alone second-level directories
(main/db1-ast, etc.).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 20:04:58 +00:00
Christian Richter c00d3374ff fixed #10631, about one way audio. thanks IgorG again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 10:06:55 +00:00
Luigi Rizzo e6e98982c9 move the inner part of config file parsing to a separate function,
so it can be reused in the implementation of cli commands when
they have a similar syntax.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89320 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 09:51:41 +00:00
Christian Richter 0bc0f6919f fixed compilation of chan_misdn, #11269, thanks IgorG.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89319 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 08:54:04 +00:00
Tilghman Lesher f4d440e039 Merged revisions 89301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89301 | tilghman | 2007-11-15 12:23:14 -0600 (Thu, 15 Nov 2007) | 2 lines

Fix an uninitialized memory read found by valgrind

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 18:39:46 +00:00
Tilghman Lesher fc74a46ee2 Merged revisions 89298 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89298 | tilghman | 2007-11-15 12:05:56 -0600 (Thu, 15 Nov 2007) | 5 lines

Yet another memory corruption issue.
Reported by: atis
Patch by: tilghman
Fixes issue #10923

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89299 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 18:11:36 +00:00
Joshua Colp e7e208009f And file said... let trunk build again! Accomplished by some more constification, and marking a function in chan_sip as purposely unused until it is fixed up.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 15:21:04 +00:00
Olle Johansson 8740176dc3 Always relying on the responses when crossing NAT's are not a good
solution, it breaks communication.
Rizzo - you need to implement a configuration option for this 
code. It's good, but maybe should be off by default.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 12:21:57 +00:00
Olle Johansson a4ce44bda4 Merged revisions 89281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89281 | oej | 2007-11-15 12:26:22 +0100 (Tor, 15 Nov 2007) | 6 lines

Don't send re-invites during pending INVITE transactions.

Patch by one47 - thanks!

Closes issue #9305

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:31:27 +00:00
Olle Johansson c698e39245 Merged revisions 89280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89280 | oej | 2007-11-15 12:15:09 +0100 (Tor, 15 Nov 2007) | 5 lines

Improve support for multipart messages. Code by gasparz, changes
by me (mostly formatting). Thanks, gasparz!

Closes issue #10947

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89282 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:27:19 +00:00
Olle Johansson 257b4fb41e Exit early instead of deciding to exit after processing the message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 10:26:00 +00:00
Olle Johansson eab6b00904 Add support for application/dtmf SIP INFO dtmf handling. Yep, another
way of handling DTMF in SIP. Totally undocumented, but implemented
in enough devices so we have to support it. 

Code by sergee, small changes by oej.

Closes issue #11049


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 10:21:41 +00:00
Tilghman Lesher 0f6892419e One more typo in config.c; and missed conversions due to the constifying of ast_variable_new parameters
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 15:13:22 +00:00
Luigi Rizzo 7f8ecd2cd3 make the 'name' and 'value' fields in ast_variable const char *
This prevents modifying the strings in the stored variables, 
and catched a few instances where this was actually done.

Given the differences between trunk and 1.4 (and the fact that this
is effectively an API change) it is better to fix 1.4 independently.
These are

chan_sip.c::sip_register()
chan_skinny.c:: near line 2847
config.c:: near line 1774
logger.c::make_components()
res_adsi.c:: near line 1049

I may have missed some instances for modules that do not build here.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 13:18:40 +00:00
Russell Bryant 50426062b7 - Convert initialization of a struct to C99 style instead of GNU style
- Fix a minor spelling error in a comment


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 20:53:49 +00:00
Tilghman Lesher f821071748 Merged revisions 89246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89246 | tilghman | 2007-11-13 11:34:11 -0600 (Tue, 13 Nov 2007) | 2 lines

If we set a value for qualify, we should actually pay attention to it, instead of overriding the value

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 17:41:02 +00:00
Jason Parker cfbc4f5fb8 Doxygen fixes.
Also fix a common typo I kept seeing (arguement) in various files.

Closes issue #11222, patch by snuffy (with arguement > argument by me).


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89202 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 23:44:20 +00:00
Tilghman Lesher 061e5a1674 Merged revisions 89184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89184 | tilghman | 2007-11-12 11:29:17 -0600 (Mon, 12 Nov 2007) | 5 lines

Fix two cases of memory corruption caused by background threads.
Reported by: atis
Patch by: tilghman
Fixes issue #10923

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 17:44:04 +00:00
Christian Richter 2a0b16b663 Merged revisions 89173 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89173 | crichter | 2007-11-12 12:26:48 +0100 (Mo, 12 Nov 2007) | 1 line

if we're NT and no number was dialed and overlapdial is set, we wait for the ISDN timeout instead of starting our own timer. added a comment for the misdn.conf.sample for the overlapdial config option.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:36:45 +00:00
Christian Richter 753f223a69 Merged revisions 89172 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89172 | crichter | 2007-11-12 12:23:57 +0100 (Mo, 12 Nov 2007) | 1 line

added restart all interfaces Restart_Indicator, to automatically send a RESTART after the L2 of a PTP Port comes up. Also fixed some places where we have send a RELEASE without need for it.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89178 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:33:13 +00:00