Commit graph

153 commits

Author SHA1 Message Date
Russell Bryant
9f9a5f1984 move the calls to ast_jb_configure() to before the PBX thread is started on the
channel to remove the theoretical race condition that the channel could get
bridged before the channel's jitterbuffer gets configured.  This was pointed
out by PCadach on IRC.  Thanks!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-16 03:43:47 +00:00
Kevin P. Fleming
aa3947e9fa complete the coding style changes for these frame structures
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-15 17:14:20 +00:00
Steve Murphy
e648f4ddb4 Made "style" change requested by Kevin Fleming... used initializer in declaration,
brought decl down to block where the variable is used, got rid of memset.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-15 16:35:06 +00:00
Steve Murphy
14beac0408 On behalf of PCadach, " IMHO that was last deadlock in chan_h323..."
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-15 14:55:30 +00:00
Russell Bryant
663adb2b0e Merged revisions 38903-38904 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r38903 | russell | 2006-08-05 01:07:39 -0400 (Sat, 05 Aug 2006) | 2 lines

suppress a compiler warning about the usage of a potentially uninitialized variable

........
r38904 | russell | 2006-08-05 01:08:50 -0400 (Sat, 05 Aug 2006) | 10 lines

Fix an issue that would cause a NewCallerID manager event to be generated
before the channel's NewChannel event.  This was due to a somewhat recent
change that included using ast_set_callerid() where it wasn't before.  This
function should not be used in the channel driver "new" functions.
(issue #7654, fixed by me)

Also, fix a couple minor bugs in usecount handling.  chan_iax2 could have
increased the usecount but then returned an error.  The place where chan_sip
increased the usecount did not call ast_update_usecount()

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38905 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 05:26:29 +00:00
Kevin P. Fleming
6d0742fc16 merge Russell's 'hold_handling' branch, finally implementing music-on-hold handling the way it was decided at AstriDevCon Europe 2006 (and the way people really want it to be)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 20:44:39 +00:00
Russell Bryant
73e8e2ab1f Blocked revisions 36725 via svnmerge
........
r36725 | russell | 2006-07-03 00:19:09 -0400 (Mon, 03 Jul 2006) | 4 lines

use ast_set_callerid to be more consistent and to make sure that the
"callerid" option in the conf files is always handled the same way and sets ANI
(issue #7285, gkloepfer)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-03 04:25:21 +00:00
Russell Bryant
c8ceb92a4f revert my changes that converted the jb on the channel to be dynamically
allocated. These changes caused crashes when using a channel type that did
not support the jitterbuffer. Instead of fixing why it's crashing, I'm going
to implement this in a better way next week. The way I did it caused a
jitterbuffer to be allocated on every channel where the channel type supported
jitterbuffers, even if they were disabled.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 16:49:12 +00:00
Russell Bryant
46018d5032 - dynamically allocate the ast_jb structure that is on the channel structure
so that channels not using a jitterbuffer don't waste as much memory
- ensure that the channel drivers that use jitterbuffers can handle a failure
  from configuring a jitterbuffer on a new channel because of a memory
  allocation error
- On passing through these channel drivers, configure the jitterbuffer before
  starting the PBX thread instead of afterwards. If the pbx fails to start for
  whatever reason, this would have caused a crash.
- Also on passing, move the increase of the usecount to after all of the
  possible failure conditions in the function
- fix a place where ast_update_use_count() was not called
- ensure that the owner channel pointer of the channel pvt strcutures is set to
  NULL in failure conditions


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35553 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 17:05:17 +00:00
Kevin P. Fleming
472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Russell Bryant
4c76028de9 - add the ability to configure forced jitterbuffers on h323, jingle,
and mgcp channels
- remove the jitterbuffer configuration from the pvt structures in
  the sip, zap, and skinny channel drivers, as copying the same global
  configuration into each pvt structure has no benefit.
- update and fix some typos in jitterbuffer related documentation
(issue #7257, north, with additional updates and modifications)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31413 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 16:47:28 +00:00
Russell Bryant
0384330d64 update the rest of the channel drivers that use RTP so that their channel
tech structures indicate that they create jitter


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-31 17:21:21 +00:00
Kevin P. Fleming
b5a7328dbe update the ->indicate() callback for the new arguments
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@26495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-10 15:00:33 +00:00
Luigi Rizzo
96e015a239 partial adaptation to the new module loading
(not sure if it compiles, partly inspired by #9981 but
with adaptations)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@23272 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-29 04:54:05 +00:00
Kevin P. Fleming
574e14cbea Thanks to the fine work of Russell Bryant and Dancho Lazarov, we now have autoconf and menuselect tools for Asterisk!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-24 17:11:45 +00:00
Kevin P. Fleming
f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Matt O'Gorman
319945c922 bug updates chan_h323 to some api changes it
also allows for it to compile once more patch
taken from 6446 with minor mods, similar bugs 6521
and 6560


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-03 18:36:30 +00:00
Russell Bryant
e01861fafd define a global null_frame object so when queueing a null frame, you don't
have to allocate one on the stack


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9001 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-31 17:18:58 +00:00
Russell Bryant
a725468381 update doxygen docs to specify authors
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-30 21:18:06 +00:00
Kevin P. Fleming
2c65582b66 remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Russell Bryant
31a804b97c issue #5605
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 15:09:47 +00:00
Russell Bryant
9ddf0e4dce Remove unnecessary checks before calls to ast_strlen_zero. Also, change
some places where strlen is used instead of ast_strlen_zero


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-27 02:19:37 +00:00
Russell Bryant
3453e3efa5 Doxygen documentation update from oej (issue #5505)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Jeremy McNamara
9ce1402c8b ok wtf, no compiler error here
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6621 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 17:08:52 +00:00
Jeremy McNamara
59e784c96a I swore this compiled. Honest, officer
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6620 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 16:58:02 +00:00
Kevin P. Fleming
b8f23573fa more license/copyright header updates (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6618 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 15:44:26 +00:00
Jeremy McNamara
3cba705808 Lets try this - an attempt to properly deal with DTMF
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6615 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 03:26:02 +00:00
Jeremy McNamara
777e97ab26 clean up debug
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 03:16:07 +00:00
Jeremy McNamara
c1517d081a castrate the logic in oh323_digit to pass DTMF no matter what. (issue #4989)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6613 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 03:14:21 +00:00
Jeremy McNamara
65f426169d Fix newsignal/newcontrol compile issue. Bug #4867
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6255 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-02 03:25:28 +00:00
Jeremy McNamara
adae4181f0 Stomp on deadlock. Bug #4555
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-27 04:45:11 +00:00
Jeremy McNamara
2fc8abd8ae one-way-audio problem on multihomed host with bind to secondary address. Bug #4505
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-27 04:39:53 +00:00
Russell Bryant
4c531ca8c0 define an AST_MAX_CONTEXT for use instead of AST_MAX_EXTENSION
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6076 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-10 23:49:57 +00:00
Kevin P. Fleming
4803ab0bb2 don't use locks when reading usecounts (reading only, not writing)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-24 02:15:04 +00:00
Kevin P. Fleming
adc9c81692 fix version tag macro calls
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 23:12:05 +00:00
Kevin P. Fleming
005e436b57 another round of version tag updates, along with 'show version files' pattern filtering
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 21:09:59 +00:00
Jeremy McNamara
2353f5925c Optimize global/user/peer configuration call options. Bug #4336
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5753 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-21 17:09:30 +00:00
Jeremy McNamara
ec9ce8db9d Make capbilities be connection specific versus for the whole endpoint. Bug #4334
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-19 19:13:19 +00:00
Jeremy McNamara
793182ea7d Fix memory leak, avoid uncessary abuse of memory and formatting tweaks. Bug #4282
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5739 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-19 16:17:08 +00:00
Jeremy McNamara
5af8df2b98 Formatting fixes and sanity checks Bug #4263
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-13 20:24:30 +00:00
Jeremy McNamara
e6be0236e5 Formatting fixes, proper locking and to shut bkw up. Bug #4185
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-11 13:27:49 +00:00
Jeremy McNamara
09ed70fcaf Fix one-way audio issues with CCM and possibly other [broken] endpoints. Bug #4135
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-03 18:58:50 +00:00
Jeremy McNamara
931e1debff Fix dtmfmode, dtmfcodec capability, Faststart for users and peers. Bug #4112
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-02 18:46:36 +00:00
Kevin P. Fleming
8634ef9e4a don't use '%i' at all, since we have no current use cases that need non base-10 parsing (bug #4110)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-29 17:00:33 +00:00
Jeremy McNamara
45f7567d70 Fix codec negiocation on inbound calls. Bugs 3980, 4021, 4045
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-29 04:22:47 +00:00
Kevin P. Fleming
1f9ab2380a use double-quotes instead of angle-brackets for non-system include files (bug #4058)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-21 06:02:45 +00:00
Jeremy McNamara
4c736c3600 Better dependancy and version checking method, solve call problems when dealing with a gatekeeper, sanity check call cleanup, in hopes to avoid deadlocks (Bugs #3848 #3643, #3591)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5383 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-04 15:54:34 +00:00
Mark Spencer
7082d0584e Add PLC and jitter buffer and iax2 meta trunk with timestamps (bug #2532, #3400)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-03-17 21:30:19 +00:00
Josh Roberson
4e395aac8b Fix compilation of chan_h323.c since removal of the private channel structures (Bug # 3738)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5153 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-03-08 23:11:23 +00:00
Mark Spencer
18d9b26cf9 Rework channel structure to eliminate "pvt" portion of channel (bug #3573)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5137 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-03-04 06:47:24 +00:00