Commit Graph

180 Commits

Author SHA1 Message Date
Olle Johansson 5fcf1c9268 If CDR logging is disabled, it's considered a FAILURE
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229840 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 09:22:04 +00:00
Tilghman Lesher c0b3c923a4 Fix various problems detected with Valgrind.
* chan_console accessed pvts after deallocation.
 * cdr_mysql stored a pointer that was freed by realloc()
 * The module loader did not check usecount on shutdown, which led to chan_iax2
 reading a timer that was already unloaded.
 * The event subsystem sometimes creates an event with no IEs.  Due to a corner
 condition, the code would read beyond the memory boundary.
 * res_pktccops did not correctly check whether its monitor thread was started.
(closes issue #16062)
 Reported by: alexanderheinz
 Patches: 
       20091109__issue16062.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-09 07:37:52 +00:00
Mark Michelson 341c7b60dd Make compilation of chan_ooh323 disabled by default.
All addons modules should be disabled by default, requiring the
user to turn them on if desired. After all, these are addons we're
talking about here.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228659 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 22:02:36 +00:00
Mark Michelson fbe477ea50 Get chan_ooh323 to compile with gcc 4.2.
For some reason, the code compiles just fine with later versions
of GCC, but this one requires some weird double casting in order
to get rid of all warnings. Whatever.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228658 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 22:00:12 +00:00
Tilghman Lesher c17525391b Missed these two channel drivers on the codec_bits merge
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 19:38:33 +00:00
Jeff Peeler f999554af7 Update chan_ooh323 to support the expanded codec bitfield from 227580.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227914 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 22:22:51 +00:00
Alexandr Anikin 9530310954 Reworked chan_ooh323 channel module.
Many architectural and functional changes.
Main changes are threading model chanes (many thread in ooh323 stack
instead of one), modifications and improvements in signalling part,
additional codecs support (726, speex), t38 mode support.
This module tested and used in production environment.

(closes issue #15285)
Reported by: may213
Tested by: sles, c0w, OrNix

Review: https://reviewboard.asterisk.org/r/324/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 22:10:44 +00:00
Tilghman Lesher 8f336e3d01 Fix trunk building
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:13:50 +00:00
Russell Bryant cea6ee4143 Fix audio problems with format_mp3.
This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue #15850)
Reported by: 99gixxer
Patches:
      issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-08 18:06:57 +00:00
Russell Bryant 078b0b0eff Fix memory corruption caused by format_mp3.
format_mp3 claimed that it provided AST_FRIENDLY_OFFSET in frames returned by
read().  However, it lied.  This means that other parts of the code that
attempted to make use of the offset buffer would end up corrupting the fields
in the ast_filestream structure.  This resulted in quite a few crashes due to
unexpected values for fields in ast_filestream.

This patch closes out quite a few bugs.  However, some of these bugs have been
open for a while and have been an area where more than one bug has been
discussed.  So with that said, anyone that is following one of the issues
closed here, if you still have a problem, please open a new bug report for the
specific problem you are still having.  If you do, please ensure that the bug
report is based on the newest version of Asterisk, and that this patch is
applied if format_mp3 is in use.  Thanks!

(closes issue #15109)
Reported by: jvandal
Tested by: aragon, russell, zerohalo, marhbere, rgj

(closes issue #14958)
Reported by: aragon

(closes issue #15123)
Reported by: axisinternet

(closes issue #15041)
Reported by: maxnuv

(closes issue #15396)
Reported by: aragon

(closes issue #15195)
Reported by: amorsen
Tested by: amorsen

(closes issue #15781)
Reported by: jensvb

(closes issue #15735)
Reported by: thom4fun

(closes issue #15460)
Reported by: marhbere


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-01 20:44:13 +00:00
Tilghman Lesher e25ca31589 Select uncommented lines, not commented ones.
(closes issue #15746)
 Reported by: makoto


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-20 15:29:53 +00:00
Tilghman Lesher ed7bc8d72f Clarify some of the error messages, to help upgraders.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-18 19:49:52 +00:00
Tilghman Lesher 642bec4d6f AST-2009-005
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-10 19:20:57 +00:00
Matthew Nicholson d0664ba6af Add an 'sms' option to mobile.conf to manually enable or disable SMS support.
(closes issue #15071)
Reported by: ughnz
Patches:
      optional-sms1.diff uploaded by mnicholson (license 96)
Tested by: ughnz, mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-03 14:01:39 +00:00
David Brooks 48363c16e1 Fixes numerous spelling errors. Patch submitted by alecdavis.
(closes issue #15595)
Reported by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-30 16:07:05 +00:00
Matthew Nicholson 6568cd6aa8 This patch adds the ability to send a CUSD command to a bluetooth device.
(closes issue #15278)
Reported by: Artem
Patches:
      cusd5.patch uploaded by Artem (license 800)
Tested by: mnicholson, Artem

Review: https://reviewboard.asterisk.org/r/274/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-29 21:46:17 +00:00
Matthew Nicholson 0cff13075f Fixed a comment for hfp_parse_clip
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209453 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-29 21:13:42 +00:00
David Brooks d81d6d3415 Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"
(closes issue #15571)
Reported by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209098 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-27 16:33:50 +00:00
Kevin P. Fleming 96e4e31eeb Merged revisions 207647 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r207647 | kpfleming | 2009-07-21 08:04:44 -0500 (Tue, 21 Jul 2009) | 12 lines
  
  Ensure that user-provided CFLAGS and LDFLAGS are honored.
  
  This commit changes the build system so that user-provided flags (in ASTCFLAGS
  and ASTLDFLAGS) are supplied to the compiler/linker *after* all flags provided
  by the build system itself, so that the user can effectively override the
  build system's flags if desired. In addition, ASTCFLAGS and ASTLDFLAGS can now
  be provided *either* in the environment before running 'make', or as variable
  assignments on the 'make' command line. As a result, the use of COPTS and LDOPTS
  is no longer necessary, so they are no longer documented, but are still supported
  so as not to break existing build systems that supply them when building Asterisk.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@207680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-21 13:28:04 +00:00
Kevin P. Fleming c9c739b20f Make the menuselect category for Add-Ons consistent with the other directories (uppercase).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@206092 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-13 13:29:23 +00:00
Matthew Nicholson f9d62e3c32 Fix mbl_fixup() in chan_mobile to update newchan->tech_pvt instead of oldchan.
(closes issue #15299)
Reported by: nikkk


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@205700 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-09 21:32:31 +00:00
Tilghman Lesher 257e41e85b Merged revisions 981 via svnmerge from
https://origsvn.digium.com/svn/asterisk-addons/branches/1.4

........
  r981 | tilghman | 2009-07-06 16:30:13 -0500 (Mon, 06 Jul 2009) | 7 lines
  
  Don't reset reconnect time, unless a reconnect really occurred.
  (closes issue #15375)
   Reported by: kowalma
   Patches: 
         20090628__issue15375.diff.txt uploaded by tilghman (license 14)
   Tested by: kowalma, jacco
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204986 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-06 21:37:39 +00:00
Russell Bryant 1ae0291374 Rename ooh323.conf to chan_ooh323.conf, make module support both names
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:18:18 +00:00
Russell Bryant 564b7aa848 Rename mobile.conf to chan_mobile.conf, make module support old name, too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204423 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:16:56 +00:00
Russell Bryant d806ae0da0 Rename res_mysql.conf to res_config_mysql.conf, make module support both
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204422 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:15:09 +00:00
Russell Bryant 65317d3861 Rename mysql.conf to app_mysql.conf, make module support both names
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:10:45 +00:00
Russell Bryant 423fdaa324 Rename cdr_addon_mysql to cdr_mysql
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:09:04 +00:00
Russell Bryant fcc7f459ec Rename app_addon_sql_mysql to app_mysql
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:08:14 +00:00
Kevin P. Fleming 3730650b4c Add-ons related build system improvements.
Ensure that add-on modules can be embedded, fix up Makefile.moddir_rules
to allow module directory Makefiles to more easily specify the modules to
be built, and explicitly list the addons modules in its Makefile, since
the module names don't follow any pattern.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:04:35 +00:00
Russell Bryant c511a26749 Move Asterisk-addons modules into the main Asterisk source tree.
Someone asked yesterday, "is there a good reason why we can't just put these
modules in Asterisk?".  After a brief discussion, as long as the modules are
clearly set aside in their own directory and not enabled by default, it is
perfectly fine.

For more information about why a module goes in addons, see README-addons.txt.

chan_ooh323 does not currently compile as it is behind some trunk API updates.
However, it will not build by default, so it should be okay for now.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204413 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 16:40:38 +00:00