Commit Graph

791 Commits

Author SHA1 Message Date
Tilghman Lesher c8223fc957 Merge ast_str_opaque branch (discontinue usage of ast_str internals)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163991 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-13 08:36:35 +00:00
Mark Michelson 81b642c8c3 Add an option to voicemail.conf to allow urgent messages to be
forwarded as not urgent.

(closes issue #14063)
Reported by: jaroth
Patches:
      urgfwd_v2.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-11 20:57:44 +00:00
Joshua Colp 135bb29ba6 Finish conversion to using ARRAY_LEN and remove it as a janitor project.
(closes issue #14032)
Reported by: bkruse
Patches:
      14032.patch uploaded by bkruse (license 132)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-10 01:09:06 +00:00
Tilghman Lesher fd484690ce Merged revisions 162463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162463 | tilghman | 2008-12-09 17:08:53 -0600 (Tue, 09 Dec 2008) | 2 lines
  
  Oops, should be "tz", not "zonetag".
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-09 23:10:34 +00:00
Tilghman Lesher 73b6cbf66c Merged revisions 162348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162348 | tilghman | 2008-12-09 15:53:25 -0600 (Tue, 09 Dec 2008) | 4 lines
  
  We appear to have documented tz= in the [general] section of voicemail.conf,
  without actually having implemented it.  Oops.
  (Reported by Olivier on the -users list)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-09 21:57:09 +00:00
Eliel C. Sardanons 5e9dc5e1f3 Add voicemail related applications and functions XML documentation:
applications:
      - VoiceMail()
      - VoiceMailMain()
      - MailboxExists()
      - VMAuthenticate()
    functions:
      - MAILBOX_EXISTS()



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161604 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-08 03:35:55 +00:00
Sean Bright 3eee1dbb9b Use ast_free() instead of free(), pointed out by eliel on IRC.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-05 16:04:36 +00:00
Sean Bright 9d2a8810e6 When using IMAP_STORAGE, it's important to convert bare newlines (\n) in
emailbody and pagerbody to CR-LF so that the IMAP server doesn't spit out an
error.  This was informally reported on #asterisk-dev a few weeks ago.  Reviewed
by Mark M. on IRC.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-05 15:56:15 +00:00
Eliel C. Sardanons 1e8e12efcf Janitor, use ARRAY_LEN() when possible.
(closes issue #13990)
Reported by: eliel
Patches:
      array_len.diff uploaded by eliel (license 64)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161218 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-05 10:31:25 +00:00
Sean Bright 2afd7a09a7 Check the return value of fread/fwrite so the compiler doesn't complain. Only a
problem when IMAP_STORAGE is enabled.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161147 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-05 02:47:54 +00:00
Tilghman Lesher c42aef2ebb Merged revisions 160770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160770 | tilghman | 2008-12-03 15:54:07 -0600 (Wed, 03 Dec 2008) | 2 lines
  
  Some compilers warn on null format strings; some don't (caught by buildbot)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160791 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-03 21:58:21 +00:00
Tilghman Lesher 3d4c0cd421 Merged revisions 160207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160207 | tilghman | 2008-12-01 18:25:16 -0600 (Mon, 01 Dec 2008) | 3 lines
  
  Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc
  and glibc.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-02 00:37:21 +00:00
Mark Michelson 6c554e4996 Fix the logic for when delete=yes when IMAP storage
is in use so that the message is deleted from both
local and IMAP storage.

(closes issue #13642)
Reported by: jaroth
Patches:
      deleteyes.patch uploaded by jaroth (license 50)




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18 23:28:23 +00:00
Mark Michelson ea9955dd2a Merged revisions 156816 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156816 | mmichelson | 2008-11-14 09:18:59 -0600 (Fri, 14 Nov 2008) | 10 lines

If the prompt to reenter a voicemail password timed out, it
resulted in the password not being saved, even if the input matched
what you gave when first prompted to enter a new password. This is
because the return value of ast_readstring was checked, but not checked
properly.

This bug was discovered by Jared Smith during an Asterisk training course.
Thanks for reporting it!


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-14 15:20:03 +00:00
Tilghman Lesher 2cc8e25222 Slightly optimize ast_devstate_str and rename global functions devstate2str and config_text_file_save to have an ast_ prefix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154260 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 18:47:20 +00:00
Kevin P. Fleming 448562af93 improve configure script to remember the previous value of each dependency in build_tools/menuselect-deps, so that (once it has been written) menuselect can use this information to warn the user when a previously met dependency is no longer met
along the way, change tags used in configure script, menuselect-deps and code for various dependencies to be consistently named



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 15:07:54 +00:00
Tilghman Lesher b287a63971 Merged revisions 154066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r154066 | tilghman | 2008-11-03 16:27:10 -0600 (Mon, 03 Nov 2008) | 5 lines
  
  Attempting to expunge a mailbox when the mailstream is NULL will crash Asterisk.
  (Closes issue #13829)
  Reported by: jaroth
  Patch by: me (modified jaroth's patch)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 22:28:12 +00:00
Kevin P. Fleming bd4eb070f3 bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 18:52:13 +00:00
Russell Bryant d7742120e9 - Use a for loop instead of a while loop
- Get rid of an unnecessary variable


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:20:10 +00:00
Tilghman Lesher c7367e26be Merged revisions 152463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152463 | tilghman | 2008-10-28 17:32:34 -0500 (Tue, 28 Oct 2008) | 3 lines
  
  Quoting in the wrong direction
  (Fixes AST-107)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-28 22:33:40 +00:00
Tilghman Lesher e818109d73 Merged revisions 148987 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r148987 | tilghman | 2008-10-14 14:03:08 -0500 (Tue, 14 Oct 2008) | 2 lines
  
  Some compilers warn, some don't.  Fixing.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 19:03:44 +00:00
Tilghman Lesher 7bdb6c3ea5 Merged revisions 148916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r148916 | tilghman | 2008-10-14 12:41:08 -0500 (Tue, 14 Oct 2008) | 4 lines
  
  Ensure that mail headers are 7-bit clean, even when UTF-8 characters are used
  in headers like 'Subject' and 'To'.
  Closes AST-107.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148917 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 17:46:48 +00:00
Tilghman Lesher c1351ad237 Merge realtime_update2 branch, which adds a new realtime API call named
'update2', which permits updates which match across multiple columns, instead
of requiring all tables to have a single unique identifier.  All of the other
API calls with the exception of 'update' already had the ability to match on
multiple fields, so it was a missing and very desireable feature that an API
call implementing an update should have this, too.

This does not change any outward performance of Asterisk, but it should make
life easier for application developers who use the RealTime framework.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148570 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 00:08:52 +00:00
Tilghman Lesher 926e3ad13d Merged revisions 148257 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r148257 | tilghman | 2008-10-10 11:25:31 -0500 (Fri, 10 Oct 2008) | 7 lines
  
  User not notified of temporary greeting, if ODBC storage is in use.
  (closes issue #13659)
   Reported by: moliveras
   Patches: 
         20081009__bug13659.diff.txt uploaded by Corydon76 (license 14)
   Tested by: moliveras
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10 16:31:31 +00:00
Sean Bright 1dedb785ab Don't include logger.h in asterisk.h by default as it is causing problems building
app_voicemail.  Instead, include it where it is needed.  This turned out to be a
relatively minor issue because other headers include logger.h as well.

Need to test -addons before merging this back to 1.6.0.

(closes issue #13605)
Reported by: tomo1657
Patches: 
      13605_seanbright.diff uploaded by seanbright (license 71)
Tested by: mmichelson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10 00:42:13 +00:00
Mark Michelson 806f3581d9 Read the callerid in the correct order and make sure to
read the Urgent flag value from the IMAP headers.

(closes issue #13652)
Reported by: jaroth
Patches:
      imapheaders.patch uploaded by jaroth (license 50)




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148144 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 23:30:47 +00:00
Tilghman Lesher 8b14e5f493 Reverting format addition for now
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 21:47:02 +00:00
Tilghman Lesher f5d5eb5e19 Fudges for wav16, just like wav49
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 21:37:23 +00:00
Tilghman Lesher e4de40eabc Merged revisions 147997 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r147997 | tilghman | 2008-10-09 14:38:33 -0500 (Thu, 09 Oct 2008) | 4 lines
  
  When blank, callerid name and number should display "unknown caller" in voicemail
  emails.
  (Closes issue #13643)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148000 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 19:39:34 +00:00
Sean Bright 702ab90240 This was flawed. The issue that I was trying to address was addressed by
adding the imapsecret alias for imappassword.  Will rethink this one and
give it another shot on a rainy day TBD.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 18:00:14 +00:00
Sean Bright e7c2c8b1df Merged revisions 147193 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r147193 | seanbright | 2008-10-07 12:48:30 -0400 (Tue, 07 Oct 2008) | 2 lines

Make 'imapsecret' an alias to 'imappassword' in voicemail.conf.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147194 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 16:52:02 +00:00
Sean Bright 8b53220990 Or not.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 16:44:00 +00:00
Sean Bright 4d9955141c There was a boo-boo in TFOT that is causing some confusion on the mailing lists
so include 'imapsecret' as an alias to 'imappassword' (and print a little notice
nudging users toward the right option name).


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 16:40:24 +00:00
Sean Bright 03e4997ceb If we encounter something in mailbox options that we don't grok, then
spit out a warning instead of just silently ignoring it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 14:59:33 +00:00
Michiel van Baak 4560279c69 All ODBC parts can now use either unixodbc or iodbc.
This allows for the ODBC parts to work on OpenBSD as well.

99.99% of the work is done by seanbright (bow, bow) and I actually
did nothing but test and yell at him that it still didn't work :)

Thanks for helping out !


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 23:14:33 +00:00
Tilghman Lesher 43ba0b858b Merged revisions 143404 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r143404 | tilghman | 2008-09-17 15:55:47 -0500 (Wed, 17 Sep 2008) | 6 lines
  
  When callerid is blank, we want to use "unknown caller" in those cases, too.
  (closes issue #13486)
   Reported by: tomo1657
   Patches: 
         20080917__bug13486.diff.txt uploaded by Corydon76 (license 14)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@143405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-17 20:57:58 +00:00
Tilghman Lesher 08af5bb312 Create a new config file status, CONFIG_STATUS_FILEINVALID for differentiating
when a file is invalid from when a file is missing.  This is most important when
we have two configuration files.  Consider the following example:

Old system:
sip.conf     users.conf     Old result               New result
========     ==========     ==========               ==========
Missing      Missing        SIP doesn't load         SIP doesn't load
Missing      OK             SIP doesn't load         SIP doesn't load
Missing      Invalid        SIP doesn't load         SIP doesn't load
OK           Missing        SIP loads                SIP loads
OK           OK             SIP loads                SIP loads
OK           Invalid        SIP loads incompletely   SIP doesn't load
Invalid      Missing        SIP doesn't load         SIP doesn't load
Invalid      OK             SIP doesn't load         SIP doesn't load
Invalid      Invalid        SIP doesn't load         SIP doesn't load

So in the case when users.conf doesn't load because there's a typo that
disrupts the syntax, we may only partially load users, instead of failing with
an error, which may cause some calls not to get processed.  Worse yet, the old
system would do this with no indication that anything was even wrong.

(closes issue #10690)
 Reported by: dtyoo
 Patches: 
       20080716__bug10690.diff.txt uploaded by Corydon76 (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@142992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-12 23:30:03 +00:00
Tilghman Lesher 81c2d7bccf Merged revisions 142744 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r142744 | tilghman | 2008-09-12 11:38:02 -0500 (Fri, 12 Sep 2008) | 4 lines

Missing merge from 1.2 fixes errant exit on DTMF, only when language is Italian
(cf commit 34242)
(Closes issue #7353)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@142745 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-12 16:38:55 +00:00
Mark Michelson 2ec51f4ed5 Fix compilation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 14:41:54 +00:00
Mark Michelson 18a3422ef0 Merged revisions 140850 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140850 | mmichelson | 2008-09-03 09:29:15 -0500 (Wed, 03 Sep 2008) | 9 lines

Fix voicemail forwarding when using ODBC storage.

(closes issue #13387)
Reported by: moliveras
Patches:
      13387.patch uploaded by putnopvut (license 60)
Tested by: putnopvut, moliveras


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 14:31:33 +00:00
Mark Michelson f1647375b2 Merged revisions 140751 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140751 | mmichelson | 2008-09-02 18:47:49 -0500 (Tue, 02 Sep 2008) | 6 lines

After adding the context checking to app_voicemail
for IMAP storage, I left out a crucial place to 
copy the context to the vm_state structure. This
is the correction.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 23:48:25 +00:00
Mark Michelson d69c866f5f Merged revisions 140421 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140421 | mmichelson | 2008-08-29 11:01:07 -0500 (Fri, 29 Aug 2008) | 12 lines

Add context checking when retrieving a vm_state.
This was causing a problem for people who had identically
named mailboxes in separate voicemail contexts.
This commit affects IMAP storage only.

(closes issue #13194)
Reported by: moliveras
Patches:
      13194.patch uploaded by putnopvut (license 60)
Tested by: putnopvut, moliveras


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140422 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-29 16:06:09 +00:00
Sean Bright 790fde68d9 Another batch of files from RSW. The remaining apps and a few more
files from main/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@137089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-10 20:23:50 +00:00
Mark Michelson 4e2406fda4 Fix compilation for ODBC voicemail
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-08 15:31:31 +00:00
Mark Michelson 64a06c0298 Remove one last batch of debug messages
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 23:39:50 +00:00
Mark Michelson 3917a7d65d Fix build for non-IMAP storage and get rid of some
debug messages.
Thanks to eliel for alerting me.
No thanks to buildbot.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 23:38:08 +00:00
Mark Michelson 5e27c1be24 Merging the imap_consistency_trunk branch to
trunk.

For an explanation of what "imap_consistency" is,
please see svn revision 134223 to the 1.4 branch.

Coincidentally, this also fixes a recent bug report
regarding the inability to save messages to the new
folder when using IMAP storage since they will would
be flagged as "seen" and not be recognized as new
messages.


(closes issue #13234)
Reported by: jaroth




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136715 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 22:25:50 +00:00
Kevin P. Fleming 992440aceb fix some format strings to actually compile without errors
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 16:29:08 +00:00
Tilghman Lesher 0785fad14f Merged revisions 135479 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135479 | tilghman | 2008-08-04 11:56:19 -0500 (Mon, 04 Aug 2008) | 6 lines

Memory leak on unload
(closes issue #13231)
 Reported by: eliel
 Patches: 
       app_voicemail.leak.patch uploaded by eliel (license 64)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-04 16:58:29 +00:00
Mark Michelson 577d6a5c78 IMAP-specific items must go in IMAP_STORAGE defines...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135068 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-01 14:42:24 +00:00