Tilghman Lesher
d8e0c58437
Expand codec bitfield from 32 bits to 64 bits.
...
Reviewboard: https://reviewboard.asterisk.org/r/416/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 14:05:12 +00:00
Tilghman Lesher
642bec4d6f
AST-2009-005
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-10 19:20:57 +00:00
David Brooks
48363c16e1
Fixes numerous spelling errors. Patch submitted by alecdavis.
...
(closes issue #15595 )
Reported by: alecdavis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-30 16:07:05 +00:00
Kevin P. Fleming
aaeec3b40f
Last batch of 'static' qualifiers for module-level global variables.
...
Fix up modules in the 'apps' directory, and also correct the bad example of
enum definitions in include/asterisk/app.h, which many developers followed
(thanks for reading the documentation!). In addition, add some basic usage
examples of the 'pahole' and 'pglobal' tools to the coding guidelines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-15 19:10:10 +00:00
Kevin P. Fleming
e6b2e9a750
Const-ify the world (or at least a good part of it)
...
This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
- CLI command handlers
- CLI command handler arguments
- AGI command handlers
- AGI command handler arguments
- Dialplan application handler arguments
- Speech engine API function arguments
In addition, various file-scope and function-scope constant arrays got 'const' and/or 'static' qualifiers where they were missing.
Review: https://reviewboard.asterisk.org/r/251/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@196072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-05-21 21:13:09 +00:00
Kevin P. Fleming
a3af213506
Remove rarely-used event_log/LOG_EVENT support
...
In discussions today at the Europe Asterisk Developer Meet-Up, we determined that
the event_log was used in only 9 places in the entire tree, and really was not needed
at all. The users have been converted to use LOG_NOTICE, or the messages have been
removed since other messages were already in place that provided the same information.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-05-02 19:02:22 +00:00
Eliel C. Sardanons
e9ab875265
Introduce SMS() application XML documentation.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-07 22:43:46 +00:00
Kevin P. Fleming
bd4eb070f3
bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 18:52:13 +00:00
Mark Michelson
270a2b6a61
Answer the channel prior to checking for the 'a'
...
option in app_sms.
(closes issue #13675 )
Reported by: alecdavis
Patches:
app_sms.bug13675.148985.diff.txt uploaded by alecdavis (license 585)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150257 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 22:44:05 +00:00
Tilghman Lesher
5bf164e901
App is ignoring 'p' parameter -- initial pause.
...
(closes issue #13617 )
Reported by: alecdavis
Patches:
app_sms.13oct.diff.txt uploaded by alecdavis (license 585)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148985 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 18:58:19 +00:00
Tilghman Lesher
5f88f1738d
Correct a typo in the help; also, ensure that the date and time are correctly
...
set, if not specified in the message.
(Closes issue #13594 , closes issue #13595 )
Reported by: alecdavis
Patches:
20081001__bug13595.diff.txt uploaded by Corydon76 (license 14)
Tested by: alecdavis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147592 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-08 19:08:32 +00:00
Tilghman Lesher
38401621f5
Initializing buffer prevents a segfault when arguments are incomplete.
...
(closes issue #13471 )
Reported by: alecdavis
Patches:
20080916__bug13471.diff.txt uploaded by Corydon76 (license 14)
Tested by: alecdavis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 15:44:06 +00:00
Sean Bright
3ffb39833b
More RSW merges. Everything from apps/ except for the big offenders
...
app_voicemail and app_queue.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@137055 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-10 14:45:25 +00:00
Michiel van Baak
f1e9371da8
- revert change to ast_queue_hangup and create ast_queue_hangup_with_cause
...
- make data member of the ast_frame struct a named union instead of a void
Recently the ast_queue_hangup function got a new parameter, the hangupcause
Feedback came in that this is no good and that instead a new function should be created.
This I did.
The hangupcause was stored in the seqno member of the ast_frame struct. This is not very
elegant, and since there's already a data member that one should be used.
Problem is, this member was a void *.
Now it's a named union so it can hold a pointer, an uint32 and there's a padding in case someone
wants to store another type in there in the future.
This commit is so massive, because all ast_frame.data uses have to be
altered to ast_frame.data.data
Thanks russellb and kpfleming for the feedback.
(closes issue #12674 )
Reported by: mvanbaak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-22 16:29:54 +00:00
Tilghman Lesher
463a5dbd0a
Whitespace changes only
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114667 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-25 20:20:10 +00:00
Kevin P. Fleming
4925e7b835
Merged revisions 107464 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r107464 | kpfleming | 2008-03-11 09:53:03 -0500 (Tue, 11 Mar 2008) | 2 lines
fix various other problems found by gcc 4.3
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-11 15:13:38 +00:00
Kevin P. Fleming
5875146526
Merged revisions 107461 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r107461 | kpfleming | 2008-03-11 09:33:45 -0500 (Tue, 11 Mar 2008) | 2 lines
stop checking for mktime() in the configure script... we don't use it, and the test is buggy under gcc 4.3
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107462 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-11 14:37:03 +00:00
Luigi Rizzo
7e8835e0d7
remove another set of redundant #include "asterisk/options.h"
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:24:55 +00:00
Luigi Rizzo
a23c055c3d
move asterisk/paths.h outside asterisk.h and into those files
...
who really need it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:16:15 +00:00
Luigi Rizzo
0595b5e2aa
include "logger.h" and errno.h from asterisk.h - usage shows that they
...
were included almost everywhere.
Remove some of the instances.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 18:52:04 +00:00
Luigi Rizzo
24c2e47e0d
another cygwin compatibility fix.
...
This one must be handled in a better way in configure, also for other
architectures
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 11:08:58 +00:00
Luigi Rizzo
fdb7f7ba3d
Start untangling header inclusion in a way that does not affect
...
build times - tested, there is no measureable difference before and
after this commit.
In this change:
use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h
Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.
Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better.
For the time being I have left alone second-level directories
(main/db1-ast, etc.).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 20:04:58 +00:00
Mark Michelson
5a4867543d
"show application <foo>" changes for clarity.
...
(closes issue #11171 , reported and patched by blitzrage)
Many thanks!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89044 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-06 19:04:45 +00:00
Tilghman Lesher
82cf384e03
Merged revisions 82285 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r82285 | tilghman | 2007-09-12 15:12:06 -0500 (Wed, 12 Sep 2007) | 4 lines
Working on issue #10531 exposed a rather nasty 64-bit issue on ast_mktime, so we
updated the localtime.c file from source. Next we'll have to write ast_strptime
to match.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 21:25:57 +00:00
Tilghman Lesher
20bbd09de3
Mostly cleanup of documentation to substitute the pipe with the comma, but a few other formatting cleanups, too.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-31 01:10:47 +00:00
Russell Bryant
f8483a0d04
Do a massive conversion for using the ast_verb() macro
...
(closes issue #10277 , patches by mvanbaak)
Basically, this changes ...
if (option_verbose > 2)
ast_verbose(VERBOSE_PREFIX_3, "Something\n");
to ...
ast_verb(3, "Something\n");
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77299 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-26 15:49:18 +00:00
Tilghman Lesher
81bc1d7af5
Merge in ast_strftime branch, which changes timestamps to be accurate to the microsecond, instead of only to the second
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-18 19:47:20 +00:00
Joshua Colp
b8cd949cce
Applications no longer need to call ast_module_user_add and ast_module_user_remove. This is now taken care of in the pbx_exec function outside of the application.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-16 14:39:29 +00:00
Joshua Colp
96a646734f
It is no longer required for each module that deals with a channel to call ast_module_user_hangup_all in it's unload function. The loader will automatically perform this action for it.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-16 13:35:20 +00:00
Luigi Rizzo
ad42dfe1dd
move variable declarations to the beginning of a block.
...
Not applicable to previous branches.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-28 19:02:31 +00:00
Tilghman Lesher
e2f71e8937
Code cleanups
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 19:53:57 +00:00
Tilghman Lesher
a1bc823136
Issue 9990 - New API ast_mkdir, which creates parent directories as necessary (and is faster than an outcall to mkdir -p)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71040 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 04:35:12 +00:00
Olle Johansson
253e1daa49
From coding guidelines:
...
Comments should explain what the code does, not when something was changed
or who changed it. If you have done a larger contribution, make sure
that you are added to the CREDITS file.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48984 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 16:58:03 +00:00
Luigi Rizzo
5727170842
improve readability of a few macros.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-22 10:35:20 +00:00
Luigi Rizzo
51f9566199
make sms_hexdump() thread safe;
...
restructure and reduce indentation on some blocks.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48844 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 23:33:44 +00:00
Luigi Rizzo
250c74d10c
make isodate thread-safe
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 22:15:03 +00:00
Luigi Rizzo
99359a4b27
- use the standard option parsing routines;
...
- document existing but undocumented parameters to send a message
(untested but unchanged;
- ad a new option p(N) to set the initial message delay to N ms
so this can be adapted from the dialplan to various countries;
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48825 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 22:03:54 +00:00
Luigi Rizzo
fbe6afd136
put generator functions next to each other.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 19:52:18 +00:00
Steve Murphy
7b338004bf
a quick fix to app_sms.c to get rid of cursed compiler warnings so I can compile under --enable-dev-mode
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48767 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 19:44:20 +00:00
Luigi Rizzo
1080c61d04
reduce indentation
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 18:54:17 +00:00
Luigi Rizzo
067573020d
restructure a block to reduce nesting
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 18:35:22 +00:00
Luigi Rizzo
1ce6943f4f
Add a bit of documentation on this code, including pointers
...
to relevant documents and comment on timing issues.
Initial merge of the code in
http://bugs.digium.com/view.php?id=8586
by Filippo Grassilli (Hyppo) to support
the SMS Protocol 2.
In this commit i have tried to minimize the diffs, so further
code cleanup will come in subsequent commits.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 16:50:26 +00:00
Luigi Rizzo
6ef9c2a16c
more formatting cleanup.
...
Move some code into a function sms_compose1() in preparation
for supporting protocol 2 as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48599 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-20 00:13:23 +00:00
Luigi Rizzo
21556620d0
formatting and code cleanup.
...
Still a lot of copy&pasted code here...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 23:56:08 +00:00
Luigi Rizzo
8a26d19b7c
start documenting this code.
...
On passing, fix the bogus datalen on outgoing frames
just fixed in 1.4 rev.48583
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48588 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 21:29:55 +00:00
Olle Johansson
cf628af83d
Doxygenification
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-02 14:07:20 +00:00
Joshua Colp
34e40c93bc
Merged revisions 47551 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r47551 | file | 2006-11-13 12:08:07 -0500 (Mon, 13 Nov 2006) | 10 lines
Merged revisions 47549 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r47549 | file | 2006-11-13 12:05:32 -0500 (Mon, 13 Nov 2006) | 2 lines
When sending an SMS with a user data header properly set the UDH flag in the first byte. (issue #8347 reported by hoffmeis)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:10:21 +00:00
Russell Bryant
0ca6a42d7e
fix various spelling mistakes in comments (issue #8237 , jmls)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-26 17:52:15 +00:00
Kevin P. Fleming
749029de38
Merged revisions 46200 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46200 | kpfleming | 2006-10-25 09:32:08 -0500 (Wed, 25 Oct 2006) | 2 lines
apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 14:44:50 +00:00
Jason Parker
d22476348a
suppress compiler warning
...
Code shamelessly borrowed from r41271 (it was the same warning/fix)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-29 17:31:15 +00:00