Commit graph

2292 commits

Author SHA1 Message Date
Tilghman Lesher
da03cdd174 Merged revisions 129149 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r129149 | tilghman | 2008-07-08 15:27:47 -0500 (Tue, 08 Jul 2008) | 8 lines

Cause SIP to return a 480 instead of a 404 when a sip peer exists, but is not
registered.
(closes issue #12885)
 Reported by: ibc
 Patches: 
       20080701__bug12885__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: ibc

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@129152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-08 20:30:29 +00:00
Brett Bryant
d185405755 Janitor project to convert sizeof to ARRAY_LEN macro.
(closes issue #13002)
Reported by: caio1982
Patches:
      janitor_arraylen5.diff uploaded by caio1982 (license 22)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@129045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-08 16:40:28 +00:00
Olle Johansson
01214ba763 Merged revisions 128950 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r128950 | oej | 2008-07-08 11:52:21 +0200 (Tis, 08 Jul 2008) | 11 lines

Don't hangup the call if we can't resolve the Contact if there's a proxy
route set for the call.
----
This comment was added a while ago and today it hit me badly. 

/* OEJ: Possible issue that may need a check:
	If we have a proxy route between us and the device,
	should we care about resolving the contact
	or should we just send it?
*/

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-08 10:02:12 +00:00
Olle Johansson
c969c0f24b Merged revisions 128912 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r128912 | oej | 2008-07-08 11:06:08 +0200 (Tis, 08 Jul 2008) | 7 lines

Fix issues where repeated messages where ignored, but retransmitted reliably instead of unreliably.
Reported by: johan
Patches: 
      12746.txt uploaded by oej (license 306)
Tested by: johan
(issue #12746)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128927 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-08 09:26:37 +00:00
Russell Bryant
69782233e4 As pointed out on the -dev list, actually use the result of find_peer() so that
a peer reference is not leaked.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-07 11:53:52 +00:00
Olle Johansson
e18e813814 - Adding alias "udpbindaddr" for the UDP port to comply with "tcpbindaddr" and "tlsbindaddr".
Note: I don't think we can start properly without UDP port open, that needs to be tested.

- Removing "bindport" from configuration example, not needed to mention this any more

I suggest we deprecate "bindaddr" and "bindport" in trunk (for 1.6.1)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 20:19:04 +00:00
Olle Johansson
638234f146 - Fixing issues with "sip show settings"
- Adding IP address for TCP and/or TLS too if auto-domain is enabled and
  binding to a different IP address
- Fixing documentation in sip.conf.sample


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128524 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 20:11:37 +00:00
Olle Johansson
3586b6212d - Remove unused variable "expiry"
- Set global_outboundproxy.force at reload.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 19:14:06 +00:00
Olle Johansson
40c0e6ed47 More doxygen comments.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128485 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 18:25:39 +00:00
Olle Johansson
fce9af0fa0 - Formatting changes
- Doxygen changes
- Replacing a doxygen description that was copied from another function


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128455 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 17:58:06 +00:00
Olle Johansson
e057380907 Adding note about incorrect manager registration...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128454 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 17:45:43 +00:00
Olle Johansson
ccb718b560 Remove comments that doesn't make sense. The deprecation of type=user will come at a later stage,
as indicated by previous commit message


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128381 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 08:43:08 +00:00
Olle Johansson
25ce6ce19e Fix severe problem with my previous commit of "kill-the-user". Russell saw a problem with this
code, but not the correct problem. Thanks, anyway! ;-)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 08:32:11 +00:00
Olle Johansson
bc99e067e6 Disabling code used by dumpdb with #ifdef, since I believe we might use it sometime in the
future, but also want to avoid compiler warnings now. 



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128344 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 08:16:59 +00:00
Olle Johansson
29770b1cd8 Removing the CLI dumpdb command (see asterisk-dev discussion and decision)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-06 08:10:27 +00:00
Olle Johansson
cf9c4ce883 Adding a few reminders
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 22:07:37 +00:00
Olle Johansson
9056540e35 Adding doxygen comments to missing parts, moving some #define
...trying to get my head around the thoughts behind the TCP/TLS stuff
and figure out what needs to be done to make it useful...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 21:55:57 +00:00
Olle Johansson
d5525e3778 Adding TCP and TLS to "sip show settings".
TLS needs to have one configuration per configured domain at some point.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 21:37:57 +00:00
Olle Johansson
6de5e8552b Add some comments...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128284 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 21:27:22 +00:00
Olle Johansson
fc7517d76e Set tls setting to default in reload_config.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 21:25:04 +00:00
Michiel van Baak
bf848cc694 fix compiling of chan_sip.c
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128254 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 21:20:09 +00:00
Joshua Colp
eff212635c I like it when the tree is not broken.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 21:11:04 +00:00
Olle Johansson
318fd4186b KILL THE USER!
Actually, kill the in-memory structure for type=user and start using the sip_peer 
structure for every object. Have only one in-memory list and use them different
ways depending on type=user, type=peer and type=friend - like always.

The idea with this first patch is that configurations should work as before.

Some additional features for realtime peers. By adding a type= field, you
can now have multiple functions.

Let's test this for a while. Won't be integrated in 1.6.0, only in trunk,
for testing.

There's propably more to clean up and simplify here. Help is welcome
and encouraged!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 20:59:49 +00:00
Olle Johansson
b04d101ee5 Stop cli command completion with tabs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 20:04:50 +00:00
Olle Johansson
0a52297cf0 Add new SIP cli command "sip show channelstats" that displays some QoS data (if we have RTCP reports
and not use the p2p rtp bridge). I could not find a way to detect us using the p2p bridge, which
would be nice.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128197 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 19:27:42 +00:00
Tilghman Lesher
1d0637521a Fullcontact needs more than 20 characters, even for the simplest case
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-04 16:41:03 +00:00
Olle Johansson
6f621e6205 - reorganize SIP extensions alphabetically, to make it easier to synch with the IANA list
- add a few new registered and well-known extension names


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127995 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-04 14:36:28 +00:00
Steve Murphy
bc2cfb3e81 Merged revisions 127663 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127663 | murf | 2008-07-02 18:16:25 -0600 (Wed, 02 Jul 2008) | 30 lines

The CDRfix4/5/6 omnibus cdr fixes.

(closes issue #10927)
Reported by: murf
Tested by: murf, deeperror

(closes issue #12907)
Reported by: falves11
Tested by: murf, falves11


(closes issue #11849)
Reported by: greyvoip

As to 11849, I think these changes fix the core problems 
brought up in that bug, but perhaps not the more global
problems created by the limitations of CDR's themselves
not being oriented around transfers.

Reopen if necc, but bug reports are not the best
medium for enhancement discussions. We need to start
a second-generation CDR standardization effort to cover
transfers.

(closes issue #11093)
Reported by: rossbeer
Tested by: greyvoip, murf



........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127793 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 17:16:44 +00:00
Olle Johansson
f99a310219 Make sure we stop session timers as soon as we start hanging up an active call.
May fix issue 12919.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127791 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:48:23 +00:00
Olle Johansson
2491cc6e65 Revert some logic for session timers. We do send in-dialog requests that should not have session-timer
require headers, like MESSAGE and REFER. So in the future, only add them on requests and responses
that are related to INVITEs and re-INVITEs.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:25:59 +00:00
Olle Johansson
b423a939b0 Fix bad formatting in a very confusing function. Who added the sipdb sql output?
It's mixing peers and users in a strange way and should really not be a CLI command,
since it's not meant for human output. It should be done with an app connecting to
manager.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127685 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 09:59:12 +00:00
Brett Bryant
6aa9419cfe Update transport= in sip so that the option is not broken from a recent commit.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127621 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 22:16:29 +00:00
Tilghman Lesher
885d17506b Keep ast_app_inboxcount API compatible with 1.6.0.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 21:27:53 +00:00
Brett Bryant
b30ed551e0 Fix to sip_parse_host so that it passes the correct information to sip_registry.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 17:27:36 +00:00
Tilghman Lesher
cce1ec5463 Change the global timer B to be dependent on the value of the T1 timer, as
recommended in RFC 3261, instead of being hardcoded to 32 seconds.  This is
important for LANs, as it allows autocongestion to occur much more quickly, if
desired by the local PBX administrator.  It also corrects a bug: if the T1
timer was increased beyond 500ms, then timer B would have been set at a much
lower value than recommended.
(closes issue #12544)
 Reported by: kactus
 Patches: 
       20080616__bug12544.diff.txt uploaded by Corydon76 (license 14)
 Tested by: kactus


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 02:48:43 +00:00
Brett Bryant
1b07e87538 Add a configuration option so the global outboundproxy can use tcptls without it being defined by each sip user.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 21:03:52 +00:00
Olle Johansson
b6b5525347 Merged revisions 126902 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126902 | oej | 2008-07-01 16:59:31 +0200 (Tis, 01 Jul 2008) | 7 lines

Use domain part of SIP uri in register= configuration as fromdomain.

Reported by: one47
Patches: 
      sip-reg-fromdom2.dpatch uploaded by one47 (license 23)
(closes issue #12474)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 15:03:59 +00:00
Olle Johansson
f3170a4946 Merged revisions 126899 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126899 | oej | 2008-07-01 16:27:33 +0200 (Tis, 01 Jul 2008) | 8 lines

Handle escaped URI's in call pickups. Patch by oej and IgorG.

Reported by: IgorG
Patches: 
      bug12299-11062-v2.patch uploaded by IgorG (license 20)
Tested by: IgorG, oej
(closes issue #12299)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 14:32:15 +00:00
Olle Johansson
42bed356d1 Merged revisions 126789 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126789 | oej | 2008-07-01 13:51:38 +0200 (Tis, 01 Jul 2008) | 6 lines

Report 200 OK to all in-dialog OPTIONs requests (to confirm that the dialog
exist). Don't bother checking the request URI.

(closes issue #11264)
Reported by: ibc

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 11:58:17 +00:00
Olle Johansson
983b851e3b Merged revisions 126735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126735 | oej | 2008-07-01 09:49:15 +0200 (Tis, 01 Jul 2008) | 7 lines

Fix bad XML for hold notification.
Reported by: gowen72
Patches: 
      hold.patch uploaded by gowen72 (license 432)
(closes issue #12942)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 09:51:22 +00:00
Olle Johansson
33a54ee23b The following patch with some changes for trunk...
Merged revisions 126516 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126516 | oej | 2008-06-30 14:50:55 +0200 (MÃ¥n, 30 Jun 2008) | 10 lines

Send all responses to an INVITE reliably, so that we retransmit if we don't get an ACK and
also fail if we don't get the very same precious ACK. Based on patch by tsearle, with
my own additions.

(closes issue #12951)

Reported by: tsearle
Patches: 
      busy_retransmit.patch uploaded by tsearle (license 373)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 13:03:53 +00:00
Tilghman Lesher
1503ea7128 Merged revisions 126056 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126056 | tilghman | 2008-06-27 17:01:09 -0500 (Fri, 27 Jun 2008) | 4 lines

When we get a 408 Timeout, don't stop trying to re-register.
(closes issue #12863)
 Reported by: ricvil

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 22:10:34 +00:00
Brett Bryant
4ebadd6d21 Small error in the function that converts peer transports to a string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 17:35:41 +00:00
Brett Bryant
12d5cebea2 Change the way that the transport option works for sip users. transport will now take multiple arguments, the first one listed will be the one used
for new dialogs, and the rest listed will be acceptable ways for that peer to contact us. This fixes a minor bug where, because SIP TCP/UDP run on 
the same port, could cause a TCP peer to be saved in the ast_db. There will also be warnings when a transport is changed for an unexpected reason.

(issue #12799)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 16:28:06 +00:00
Olle Johansson
4f32bf72f9 Merged revisions 125384 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r125384 | oej | 2008-06-26 18:32:08 +0200 (Tor, 26 Jun 2008) | 3 lines

Add support for peer realm based auth (a few missing lines, the rest is well documented but never worked)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125385 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 16:54:22 +00:00
Mark Michelson
0f62296eb6 Add a missing "ChannelType" header to one of the "PeerStatus" manager
events in chan_sip

(closes issue #12904)
Reported by: eliel
Patches:
      chan_sip.c.patch uploaded by eliel (license 64)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-20 15:20:11 +00:00
Michiel van Baak
8e8359465b Older versions of GNU gcc do not allow 'NULL' as sentinel.
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4

This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)

All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:48:33 +00:00
Brett Bryant
249ac33ab0 Fix bug in sip registration that sets the default port to 5060 for tls.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 18:57:04 +00:00
Brett Bryant
2aae0ba13d Updates all usages of ast_tcptls_session_instance to be managed by reference counts so that they only get destroyed when all threads are done using
them, and memory does not get free'd causing strange issues with SIP. 

This code was originally written by russellb in the team/group/issue_11972/ branch.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:46:57 +00:00
Mark Michelson
67ca33e267 Merged revisions 123485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123485 | mmichelson | 2008-06-17 15:26:38 -0500 (Tue, 17 Jun 2008) | 4 lines

Make chan_sip build under dev mode with compilers >= GCC 4.2
Thanks to jpeeler for alerting me of this


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123486 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:28:47 +00:00