63f2f04cf4
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-01 22:26:51 +00:00
e3f3a640c0
Merged revisions 88026 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r88026 | file | 2007-11-01 10:27:37 -0300 (Thu, 01 Nov 2007) | 2 lines
Fix up commit for my Zap channel with spies in Meetme fix. (thanks Tony Mountifield!)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-01 13:30:28 +00:00
97fe45ab93
Janitor: use ast_free to pair calls of ast_malloc and ast_calloc
...
Reported by: eliel
Patch by: eliel
Closes issue #11135
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88008 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-01 06:07:18 +00:00
78cae359c8
Merged revisions 87970 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r87970 | file | 2007-10-31 22:53:55 -0300 (Wed, 31 Oct 2007) | 4 lines
If a Zap channel contains a spy or a spy is added take it out of the conference in kernel space and make it go through Asterisk so the spy gets audio from both sides.
(closes issue #10060 )
Reported by: mparker
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87971 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-01 01:55:38 +00:00
df6237eac3
Add volume adjustment in.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87851 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-31 18:03:17 +00:00
f066bfc38a
Restore operation of the option that only writes when the channel is bridged.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-31 17:56:21 +00:00
d13f7d94b1
Add volume adjustment to spy audiohook in app_chanspy.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87833 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-31 17:25:16 +00:00
f595811265
If no '?' is found in the arguments, don't attempt to continue.
...
Reported by: blitzrage
Fixed by: tilghman
Closes issue #11111
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-30 22:15:28 +00:00
c1e08b1ae0
If a caller is listen-only, then don't bother with doing talker detection.
...
(closes issue #10911 , reported by junky, patched by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-29 21:34:47 +00:00
3ffc123db9
Adding the more flexible QUEUE_MEMBER function to replace the QUEUE_MEMBER_COUNT function.
...
A deprecation notice will be issued the first time QUEUE_MEMBER_COUNT is used.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87395 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-29 20:13:23 +00:00
98617d82a1
Make sure we set flags to a 0 value before trying to use it. Pointed out by seanbright while I was debugging issue 11109.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87393 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-29 19:56:50 +00:00
34fd65ba3c
Remove duplicate stdlib.h include.
...
(closes issue #11105 )
Reported by: eliel
Patches:
app_voicemail.c.patch uploaded by eliel (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-29 16:38:31 +00:00
cf861b38c7
Added queue strategy "linear". This strategy is useful for those who always wish for their
...
phones to be rung in a specific order.
(closes issue #7279 , reported and initially patched by diLLec, patch reworked by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-26 15:19:46 +00:00
adc9003fc5
Add support for a muted user to request to talk. The '2' option in the user
...
menu will adjust this status if a user is muted. The talk request status will
be reflected in the CLI commands as well as the manager interface.
(closes issue #9418 )
Reported by: imesper
Patches:
app_meetme_v2.patch uploaded by imesper (license 275)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87040 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-25 18:59:22 +00:00
a8cc80e36d
Adding the general option "shared_lastcall" to queues so that a member's wrapuptime
...
may be used across multiple queues.
(closes issue #9777 , reported and patched by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86985 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-24 21:26:27 +00:00
39ce390203
Convert some spaces to tabs and make it so the CLI command is only registered
...
once instead of 3 times.
(closes issue #11053 )
Reported by: seanbright
Patches:
app_playback.patch uploaded by seanbright (license 71)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 21:17:16 +00:00
ebe4050128
Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 20:05:18 +00:00
967466da29
Merged revisions 86754 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r86754 | file | 2007-10-22 13:15:18 -0300 (Mon, 22 Oct 2007) | 4 lines
Make sure res is a positive value before performing the check to determine whether the user stopped it or not.
(closes issue #11023 )
Reported by: cfc
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 16:19:01 +00:00
2d5c98be1e
Merged revisions 86694 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r86694 | mmichelson | 2007-10-22 09:48:46 -0500 (Mon, 22 Oct 2007) | 5 lines
Account for the fact that sometimes headers may be terminated with \r\n instead of just \n
(closes issue #11043 , reported by yehavi)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86696 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 14:58:57 +00:00
b0f3e6097e
Convert NEW_CLI to AST_CLI.
...
Closes issue #11039 , as suggested by seanbright.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 18:29:40 +00:00
d667064268
Fixed a buffer size issue.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 01:56:47 +00:00
934b814add
Merged revisions 86328 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r86328 | mmichelson | 2007-10-18 12:38:26 -0500 (Thu, 18 Oct 2007) | 5 lines
If a non-existent file is specified to be played either as a periodic announcement
or as a hold/position announcement, the caller would be kicked out of the queue.
No longer does this happen.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 17:40:45 +00:00
37c1943b87
Changed some spaces to tabs
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 16:16:51 +00:00
d1a0d959a7
Merged revisions 86202 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r86202 | mmichelson | 2007-10-17 16:39:05 -0500 (Wed, 17 Oct 2007) | 6 lines
Changing the strategy field of the call_queue struct to be signed instead of unsigned,
since the code attempts to set the strategy to -1 if you specify a bogus strategy.
While this isn't a huge issue in 1.4, it could be a problem for someone who, say, tries
to use the roundrobin strategy in trunk (despite all the deprecation warnings in 1.4).
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 21:41:06 +00:00
c853d3ab01
Enhancements to realtime (closes issue #9609 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 15:13:51 +00:00
c438d76551
Removed the monitor-join option. If one wishes to mix audio, they should instead use
...
monitor-type=mixmonitor.
(related to issue #10885 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 22:54:37 +00:00
a39404fed2
Fixing the build.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 21:51:26 +00:00
dadfe716e2
Fixing app_read so that if a timeout of less than 1 ms is specified,
...
assume that 1 ms is desired.
(closes issue #11000 , reported and patched by michael-fig, with a warning line added by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85965 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 21:38:05 +00:00
bece7e24f2
Merged revisions 85958 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r85958 | mmichelson | 2007-10-16 16:14:34 -0500 (Tue, 16 Oct 2007) | 5 lines
Trying to remove a non-dynamic queue member via dynamic means can lead to some
interesting (read nasty) situations. This patch clears up the issue by making
only dynamic queue members removable via dynamic methods.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 21:16:00 +00:00
1f21e03746
Merged revisions 85896 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r85896 | russell | 2007-10-16 14:10:01 -0500 (Tue, 16 Oct 2007) | 2 lines
Remove a pointless lock.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 19:12:24 +00:00
227d678cc7
Fix IMAP compilation error.
...
(closes issue #10986 , reported and patched by snuffy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 16:40:24 +00:00
a586d03231
Merged revisions 85720 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r85720 | russell | 2007-10-15 16:10:02 -0500 (Mon, 15 Oct 2007) | 3 lines
Ensure that no pending state changes are leaked when the device state change
thread gets stopped on module unload.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85721 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 21:11:06 +00:00
4765cf4553
Another major doc directory update from IgorG. This patch includes
...
- Many uses of the astlisting environment around verbatim text to ensure that
it gets properly formatted and doesn't run off the page.
- Update some things that have been deprecated.
- Add escaping as needed
- and more ...
(closes issue #10978 )
Reported by: IgorG
Patches:
texdoc-85542-1.patch uploaded by IgorG (license 20)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85547 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 13:12:51 +00:00
fbcd884e1b
Allow for the position announcement to be turned off if desired.
...
(closes issue #8515 , reported by bruno_rocha, initial patch by bruno_rocha, final patch by qwell)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-12 20:06:37 +00:00
a4be521c89
Make sure we propogate ANI2 to the outbound channel
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85499 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-11 22:42:44 +00:00
e97a723cf1
Merge a ton of NEW_CLI conversions. Thanks to everyone that helped out! :)
...
(closes issue #10724 )
Reported by: eliel
Patches:
chan_skinny.c.patch uploaded by eliel (license 64)
chan_oss.c.patch uploaded by eliel (license 64)
chan_mgcp.c.patch2 uploaded by eliel (license 64)
pbx_config.c.patch uploaded by seanbright (license 71)
iax2-provision.c.patch uploaded by eliel (license 64)
chan_gtalk.c.patch uploaded by eliel (license 64)
pbx_ael.c.patch uploaded by seanbright (license 71)
file.c.patch uploaded by seanbright (license 71)
image.c.patch uploaded by seanbright (license 71)
cli.c.patch uploaded by moy (license 222)
astobj2.c.patch uploaded by moy (license 222)
asterisk.c.patch uploaded by moy (license 222)
res_limit.c.patch uploaded by seanbright (license 71)
res_convert.c.patch uploaded by seanbright (license 71)
res_crypto.c.patch uploaded by seanbright (license 71)
app_osplookup.c.patch uploaded by seanbright (license 71)
app_rpt.c.patch uploaded by seanbright (license 71)
app_mixmonitor.c.patch uploaded by seanbright (license 71)
channel.c.patch uploaded by seanbright (license 71)
translate.c.patch uploaded by seanbright (license 71)
udptl.c.patch uploaded by seanbright (license 71)
threadstorage.c.patch uploaded by seanbright (license 71)
db.c.patch uploaded by seanbright (license 71)
cdr.c.patch uploaded by moy (license 222)
pbd_dundi.c.patch uploaded by moy (license 222)
app_osplookup-rev83558.patch uploaded by moy (license 222)
res_clioriginate.c.patch uploaded by moy (license 222)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85460 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-11 19:03:06 +00:00
75c83fd851
Merged revisions 85276 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r85276 | mmichelson | 2007-10-10 09:26:31 -0500 (Wed, 10 Oct 2007) | 5 lines
A bunch of changes from sprintf to snprintf.
See security advisory AST-2002-022
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-10 14:38:15 +00:00
dd04101f60
Merged revisions 85242 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r85242 | file | 2007-10-10 11:14:56 -0300 (Wed, 10 Oct 2007) | 6 lines
Close voicemail message description file if duration did not meet the minimum, or else we will eventually run out of file descriptors.
(closes issue #10918 )
Reported by: brak2718
Patches:
vm1.4.12.1.patch uploaded by brak2718 (license 279)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85254 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-10 14:17:08 +00:00
310cfd3280
Patch to add one-touch parking for queues.
...
(closes issue #10869 , reported and patched by bluecrow76)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85177 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-09 22:35:11 +00:00
7adbd6bb16
Remove redundant includes (patch by snuffy) (Closes issue #10922 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85140 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-09 16:04:41 +00:00
23ebcbc370
A two-in-one patch from the bugtracker
...
1) Fix some bad logic in the counting of statistics for QueueSummary manager event. Variables were not being
reset for each additional queue, so cumulative totals were reported on each successive queue.
2) Add a longest hold time stat to QueueSummary manager event.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-04 22:58:26 +00:00
43e2818750
Merged revisions 84692 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r84692 | mmichelson | 2007-10-04 16:57:03 -0500 (Thu, 04 Oct 2007) | 5 lines
Don't allocate space for queue members unless it's needed. You end up deleting dynamic members on a reload. Not good.
closes issue (#10879 , reported by dazza76, patched by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-04 22:00:10 +00:00
e835dd12e4
Merged revisions 84637 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r84637 | file | 2007-10-04 11:51:57 -0300 (Thu, 04 Oct 2007) | 4 lines
Create a duplicate of the channel's member name as the tab completion stuff will free it.
(closes issue #10884 )
Reported by: adamg
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84638 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-04 14:54:30 +00:00
d78463be1e
Corydon posted this janitor project to the bug tracker and mvanbaak provided
...
a patch for it. It replaces a bunch of simple calls to snprintf with ast_copy_string
(closes issue #10843 )
Reported by: Corydon76
Patches:
2007092900_10843.diff uploaded by mvanbaak (license 7)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 15:23:19 +00:00
bff784d509
Merged revisions 84166 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r84166 | russell | 2007-10-01 09:24:49 -0500 (Mon, 01 Oct 2007) | 2 lines
Simplify the CAN_EARLY_BRIDGE macro a bit.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 14:27:02 +00:00
3ed4d505b7
Merged revisions 84158 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r84158 | file | 2007-10-01 10:49:36 -0300 (Mon, 01 Oct 2007) | 4 lines
Only attempt early bridging if the options given to Dial() permit it.
(closes issue #10861 )
Reported by: peekyb
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 13:53:09 +00:00
2d95565f53
interface_exists_global was never returning 1. Most likely an error from my merge on Friday.
...
(closes issue #10817 , reported and patched by snar, patch simplified by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 17:00:57 +00:00
02c997c64c
Add the MeetmeList and Reload manager commands, which supplement the need to have Command privilege. (closes issue #10736 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-22 14:03:48 +00:00
b88902639a
Fix some areas where we were still using '|' for an argument delimiter (closes issue #10793 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 18:41:36 +00:00
e5c12bcf62
Update app_queue to use commas as application argument separators.
...
(closes issue #10793 , snar)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83483 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 18:27:56 +00:00
Steve Murphy
Joshua Colp
Tilghman Lesher
Russell Bryant
Mark Michelson
Jason Parker
TransNexus OSP Development
Matthew Fredrickson