Luigi Rizzo
2c3bc8b1b3
move middle-of-the-block declaration at the top.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-24 11:46:27 +00:00
Luigi Rizzo
d0ef036696
fix uninitialized variable
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-24 11:45:06 +00:00
Joshua Colp
6810884f60
Only deal with getting the supported payloads on audio if an audio RTP stream exists
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38139 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-24 03:42:27 +00:00
Russell Bryant
fb94a4933b
ast_malloc is sufficient here, since snprintf is called on the buffer
...
immediately after it gets allocated, which will automatically NULL terminate
the string
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 15:21:44 +00:00
Russell Bryant
a1fb7a2da3
Merge team/russell/ast_cli_tls into the trunk.
...
This improves the performance of ast_cli() by not doing a heap memory
allocation and deallocation every single time the function is called. Instead,
a thread-specific buffer is allocatted the first time the function is called
and automatically free'd when the thread exits. Also note that this buffer will
only be allocatted in threads that actually call this function, which is
probably only the threads spawned to service connected asterisk consoles.
This does introduce a new limitation on the maximum length of the resulting
string from the arguments passed to ast_cli. Previously there was no limit
since it was just allocating a buffer big enough every time the function was
called. The current buffer size is 16kB. If there is ever a case where we want
to print more than 16k characters in a single call to ast_cli(), this will have
to be increased.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 15:19:16 +00:00
Russell Bryant
4103a6d8d7
fix a seg fault in this application if no context paramater is given
...
(issue #7571 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38118 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 05:20:59 +00:00
Russell Bryant
ee4c121dec
resolve another XXX comment by implementing proper handling of control frames
...
in ast_write(), which is to call the channel's indicate function if it exists
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38117 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 05:06:47 +00:00
Russell Bryant
02077a8cae
take the advice of an XXX comment and use an atomic operation to decrement a
...
variable. Also, change a use of strdup to ast_strdup and remove a duplicated
error message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38108 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 04:58:56 +00:00
Russell Bryant
0b6a420520
remove a stray newline
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 03:29:19 +00:00
Russell Bryant
8f08d7cc13
update to mention svn instead of cvs
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 02:50:25 +00:00
Russell Bryant
5830e9cb4f
various cleanups regarding coding guidelines issues
...
- malloc to ast_malloc
- malloc + memset to ast_calloc
- sizeof(struct foo) to sizeof(*bar)
- remove indentation of the entire body of a function by returning immediately
on an allocation failure
(issue #7581 , tempest1)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38088 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-23 02:41:02 +00:00
Russell Bryant
f21d43ad5e
ast_pbx_outgoing_cdr_failed() is not used outside of pbx.c so make it static
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38078 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-22 00:38:30 +00:00
Russell Bryant
d897bd41c2
use ast_atomic_fetchadd_int in chan_zap, sip, and iax2 for usecount handling
...
and fix a couple little things in passing
- usecnt was not initialized in chan_iax2
- ast_update_use_count() was not called after incrementing the count in chan_sip
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-22 00:33:56 +00:00
Russell Bryant
41ab9c5015
remove an XXX comment and document that ast_autoservice_start() will return -1
...
if the channel is already in the autoservice list.
Why is this a valid case to return -1, you ask? Well, there should never be
any code where it is not clear if the channel is in autoservice or not because
trying to read frames from a channel that is in the autoservice list will lead
to bad results because more than one thread will be waiting on frames to arrive
on the channel and then trying to read them.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38076 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-22 00:08:21 +00:00
Russell Bryant
8dad7e730e
slightly simplify a loop and replace an open coded version of ast_skip_blanks
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38068 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-21 23:58:14 +00:00
Russell Bryant
83749437a9
make ast_state2str thread safe by using thread local storage instead of a
...
static buffer for storing the result when the state value is unknown
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-21 22:36:25 +00:00
BJ Weschke
f2611e36c3
This corrects the crash condition present in #7575 , but I'm not really sure if it's the "right" fix. Please review and make any adjustments you see necessary.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-21 19:10:58 +00:00
Russell Bryant
ca9ba719b6
Merge a new implementation of ast_inet_ntoa, our thread safe replacement for
...
inet_ntoa, which uses thread specific data (aka thread local storage) instead
of stack allocatted buffers to store the result.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38042 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-21 17:31:28 +00:00
Joshua Colp
1861dcdff5
Only bitmaskify the RTP payload structure for video if an RTP structure exists for it... otherwise the default values will cause codec combination madness
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-20 18:42:22 +00:00
Russell Bryant
233aab68a6
add a verbose message to the AGI command, STREAM FILE, similar to the
...
verbose messages when using Playback, Background, or the GET DATA command
(issue #7297 , softins)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38021 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-20 16:18:07 +00:00
North Antara
346c291a2d
Remove "initialization from incompatible pointer type" warnings.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38010 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 22:48:00 +00:00
North Antara
1edb21b423
Fix a few doxygen warnings.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 22:40:36 +00:00
Russell Bryant
9dac8f0f09
add menuselect_stub.c to deps list
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38000 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 21:52:59 +00:00
Russell Bryant
377ae8d648
add notes on the changes to music on hold handling
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37999 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 21:07:14 +00:00
Kevin P. Fleming
6d0742fc16
merge Russell's 'hold_handling' branch, finally implementing music-on-hold handling the way it was decided at AstriDevCon Europe 2006 (and the way people really want it to be)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 20:44:39 +00:00
Kevin P. Fleming
54e1f06c46
make installation of French and Spanish sounds work properly
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 18:50:55 +00:00
Kevin P. Fleming
dce498f8ce
use new sound file version
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37973 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 18:33:14 +00:00
Mark Spencer
2b30934535
Fix some reinitialization of prev!
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 17:26:47 +00:00
Kevin P. Fleming
a353387ea7
restore buildability
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 17:21:33 +00:00
Kevin P. Fleming
5aad4439e9
Merged revisions 37949 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r37949 | kpfleming | 2006-07-19 12:10:10 -0500 (Wed, 19 Jul 2006) | 2 lines
ensure that global 'maxauthreq' is reset to zero during 'reload'
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 17:16:25 +00:00
Kevin P. Fleming
886a6bd6f9
restore buildability (bad marko!)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 17:16:08 +00:00
Kevin P. Fleming
e8d711723a
revert this morning's incorrect indentation change
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37937 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 13:50:19 +00:00
Mark Spencer
837910062b
First pass at in-place file manipulation via manager
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37936 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 13:28:38 +00:00
Steve Murphy
db0b142b06
committing a fix for colons in goto arguments and suppressing operator messages in globals assignments.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 02:55:24 +00:00
Luigi Rizzo
31d0db0e29
move variable declarations to the beginning of a block.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37907 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-18 21:19:59 +00:00
Mark Spencer
566ce7ef26
Eliminate file descriptor leak in built in HTTP server
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37896 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-18 20:26:38 +00:00
Joshua Colp
457ec51f8d
Expand speech API so that the developer can interact with the engine more directly and use specific functions of the connector even if a generic API call is not available
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37881 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-18 16:22:26 +00:00
Russell Bryant
7dd7291aa0
Merged revisions 37856 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r37856 | russell | 2006-07-17 20:41:47 -0400 (Mon, 17 Jul 2006) | 2 lines
don't crash if the frame has no data, but has a src
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-18 00:43:57 +00:00
Russell Bryant
da6910c35b
if asked to duplicate a frame that has no data, don't set the frame's data
...
pointer past the end of the buffer allocated for the new frame
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 23:31:24 +00:00
Russell Bryant
6f6e7f6f03
Blocked revisions 37828 via svnmerge
...
........
r37828 | russell | 2006-07-17 19:25:33 -0400 (Mon, 17 Jul 2006) | 3 lines
if asked to duplicate a frame that has no data, don't set the frame's data
pointer past the end of the allocatted buffer for the new frame
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 23:26:22 +00:00
Tilghman Lesher
69db447bcf
Blocked revisions 37808 via svnmerge
...
........
r37808 | tilghman | 2006-07-17 17:36:56 -0500 (Mon, 17 Jul 2006) | 2 lines
Backport buffer increase to 1.2
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 22:39:02 +00:00
Tilghman Lesher
61c9c25391
H.263 frames can apparently be larger than was originally coded.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 16:31:43 +00:00
Tilghman Lesher
83f5766c47
Merged revisions 37765 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r37765 | tilghman | 2006-07-17 10:52:15 -0500 (Mon, 17 Jul 2006) | 2 lines
Overflow bad
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37766 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 15:56:16 +00:00
Mark Spencer
f6d03e822a
Make app_meetme's do_invite more generic.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 02:17:38 +00:00
Luigi Rizzo
de59e8f655
use a couple of variables to remove duplicate definitions
...
of the various rules for the NOISY/!NOISY cases.
Approved by: kevin
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37744 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-16 22:24:39 +00:00
Russell Bryant
88627c754a
add a QueueLog application that allows for custom entries in the queue_log
...
(issue #7368 , by stevedavies with some modifications)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37734 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-16 19:36:29 +00:00
Russell Bryant
c024569f28
malloc + memset to ast_calloc
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37733 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-16 19:35:09 +00:00
Luigi Rizzo
541fdacb3c
typo LDFAGS -> LDFLLAGS
...
detected by: noisy build on FreeBSD
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37719 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-16 13:01:48 +00:00
Tilghman Lesher
1a396d37f6
Merged revisions 37691 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r37691 | tilghman | 2006-07-15 18:29:28 -0500 (Sat, 15 Jul 2006) | 4 lines
Bug 7513 - ensure that each time we do a query, the results are returned in the
same logical order, so that when we iterate over the list, we get all results,
not some results repeated, due to insufficient sorting.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-15 23:35:21 +00:00
North Antara
2da3b12c51
case consistency in DISA (or is it "disa"?)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-15 21:56:58 +00:00