Commit Graph

47 Commits

Author SHA1 Message Date
Steve Murphy 4c937339e5 As per discussion on bug 7862, the problem wasn't the fact that the documentation differed from behavior, but rather that users are used to REGEX having that space after the double quote in 1.2.x. So, in keeping with history, I investigated a little deeper, and discovered that the change in behavior was due to the modification of the function to use the AST_DECLARE_APP_ARGS and AST_NONSTANDARD_APP_ARGS() to parse the args. The code to skip the blank was left out. So, what I did was add code to throw out the first blank (space or tab) after the double quote, IF IT IS THERE. If not, nothing is done.Verbage is added to the function description saying that the space is optional, and skipped if it is there. If a space is desired, then the documentation advises putting two spaces there. This should make it compatible for 1.2 users, and not mess up new users who are used to using it with no space. It WILL mess up new users who WANT a space. Hopefully, they will double check the doc strings for this func and add the extra space. Hopefully, this class of new user is very small.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42423 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-08 16:44:38 +00:00
Steve Murphy a7b5ef30e7 With respect to bug 7862, the syntax and description are misleading to users. the syntax included a space after the double quotes between the regex and the data to match. I removed this from the function doc, and added some verbage to make this crystal clear, I hope.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42224 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 04:23:00 +00:00
Russell Bryant badabb5bb9 oops.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 04:19:54 +00:00
Russell Bryant 42fc890acc The behavior of REGEX when it did not match was not defined by the docs, so
define it to provide a result of "0" and change the code appropriately.
(issue #7805)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 04:07:35 +00:00
Kevin P. Fleming 0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00
Tilghman Lesher e3482f7f38 Don't attempt to run a regcomp if we haven't even parsed arguments correctly
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-03 06:32:35 +00:00
Tilghman Lesher 2465fd611c Revert the previous change to FILTER and fix the embedded documentation instead.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-01 16:03:51 +00:00
Russell Bryant df2223416d fix the parsing of options in the FILTER function to match the documentation.
(issue #7465)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36504 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-01 14:42:42 +00:00
Kevin P. Fleming 472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Joshua Colp e08dc08ae2 Add SPRINTF dialplan function made by the ever insaneful Corydon (issue #7078 reported by Corydon76)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-18 00:00:32 +00:00
Luigi Rizzo e43bc6634d This rather large commit changes the way modules are loaded.
As partly documented in loader.c and include/asterisk/module.h,
modules are now expected to return all of their methods and flags
into a structure 'mod_data', and are normally loaded with RTLD_NOW
| RTLD_LOCAL, so symbols are resolved immediately and conflicts
should be less likely.  Only in a small number of cases (res_*,
typically) modules are loaded RTLD_GLOBAL, so they can export
symbols.
 
The core of the change is only the two files loader.c and
include/asterisk/module.h, all the rest is simply adaptation of the
existing modules to the new API, a rather mechanical (but believe
me, time and finger-consuming!) process whose detail you can figure
out by svn diff'ing any single module.

Expect some minor compilation issue after this change, please
report it on mantis http://bugs.digium.com/view.php?id=6968
so we collect all the feedback in one place.

I am just sorry that this change missed SVN version number 20000!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 14:08:19 +00:00
Kevin P. Fleming f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Matt O'Gorman 5f446b24ea minor fixes to commit 10934 from bug#6257
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-23 23:36:53 +00:00
Matt O'Gorman a4734960e7 added function QUOTE into strings, which allows
for quoted strings, and escapes them properly.
slightly modified patch from bug #6257


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10934 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-23 22:59:16 +00:00
Kevin P. Fleming 302c943001 add 'consumed' argument to ast_get_time_t, so callers can know how many characters were used in the parser
update pbx_dundi to use ast_get_time_t
eliminate some compiler warnings


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-23 17:13:57 +00:00
Kevin P. Fleming c5ff2c4f42 add KEYPADHASH dialplan function (issue #6441)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 00:59:01 +00:00
Kevin P. Fleming 4662d58b01 add API function for parsing strings to time_t (issue #6320, with mods)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10105 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 00:24:24 +00:00
Kevin P. Fleming 96bf384e7d major dialplan functions update
deprecate LANGUAGE() and MUSICCLASS(), in favor of CHANNEL()


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-12 04:28:58 +00:00
Kevin P. Fleming a38a7eec61 build function modules independently (no more pbx_functions.so)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-11 03:14:05 +00:00
Tilghman Lesher 7d897634dc Bug 6262 - New function STRPTIME
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-22 08:09:02 +00:00
Russell Bryant 4414f45393 on this pass, only remove duplicate log messages
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 20:57:06 +00:00
Russell Bryant 9fa6eb5e07 revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8387 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 17:50:04 +00:00
Russell Bryant 2499926195 remove useless checks of the result of ast_strdupa
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8380 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 08:23:57 +00:00
Tilghman Lesher 109b5baa8d Argh, another ERROR that should have been DEBUG
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-16 18:41:18 +00:00
Tilghman Lesher 7f28989616 Change a debugging message committed with the wrong level
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8103 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-16 18:39:01 +00:00
BJ Weschke fa07ae94ec More code optimization with the new argument macros #6253
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-16 17:31:30 +00:00
Tilghman Lesher 2dec3747df Clarify description of ARRAY function
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8080 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-15 18:08:04 +00:00
Tilghman Lesher 9702fac4f8 Bug 6238 - Janitor - update to app_args macros
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8076 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-14 19:30:37 +00:00
Tilghman Lesher 3578c5b19d Merged revisions 8074 via svnmerge from
/branches/1.2


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8075 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-14 19:08:03 +00:00
Russell Bryant a725468381 update doxygen docs to specify authors
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-30 21:18:06 +00:00
Tilghman Lesher 340f5b67de Bug 5906 - ARRAY dialplan function
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-27 06:50:25 +00:00
Tilghman Lesher 5323442db4 Bug 5327 - new function FILTER and optional argument to CALLERID
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-23 21:03:25 +00:00
Kevin P. Fleming 2c65582b66 remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Russell Bryant 987b87662c make app_queue 1.2 jump compliant (issue #5580)
add missing includes of stdio.h
remove some unused and duplicate headers


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7026 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 04:48:00 +00:00
Kevin P. Fleming a0a9769616 issue #5648
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 01:55:31 +00:00
Russell Bryant 3453e3efa5 Doxygen documentation update from oej (issue #5505)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Russell Bryant a863d2b280 clean up function to be more consistent with coding guidelines
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-17 17:54:32 +00:00
Kevin P. Fleming 9a85d06a64 initialize variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-14 00:45:38 +00:00
Russell Bryant 33377538b0 provide the correct string to evaluate with the given regex, instead of the
entire string provided as input to the REGEX function..  Also, use the
provided buffer to store the result.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6744 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-12 01:09:04 +00:00
Kevin P. Fleming d612e3bc27 ensure result buffer is initialized (issue #5285)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-25 20:47:00 +00:00
Kevin P. Fleming 5da915dcfd update MANY more files with proper copyright/license info (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 20:46:50 +00:00
Kevin P. Fleming 22b0f5d306 add a library of timeval manipulation functions, and change a large number of usses to use the new functions (bug #4504)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-15 23:00:47 +00:00
Kevin P. Fleming 2b8338cb52 more file version tags
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 22:12:19 +00:00
Kevin P. Fleming 2638192439 add EVAL function, deprecate Eval application (bug #4277)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-15 23:53:11 +00:00
Kevin P. Fleming 7cd4ac0ee1 clean up file headers
restore appropriate copyrights for functions that came from files with copyrights listed


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5587 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-05 12:48:52 +00:00
Kevin P. Fleming f01e832eef add STRFTIME dialplan function (bug #4098, modified to use new funcs subdirectory)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-05 05:50:11 +00:00
Kevin P. Fleming 4d2537ae11 major re-work of dialplan functions, including:
- locking of functions list during registration/unregistration/searching
 - rename of function description structure to be consistent with the rest of the API
 - addition of 'desc' element to description structure, for detailed description (like applications)
 - addition of 'show function' CLI command to show function details
 - conversion of existing functions to use uppercase names to match policy
 - creation of new 'pbx_functions.so' module to contain standard 'builtin' functions
 - removal of all builtin functions from pbx.c and apps and placement into new 'funcs' directory


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5583 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-05 05:39:33 +00:00