sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
asterisk/apps
History
Terry Wilson 13427db64c Fix segfault introduced by conversion to ACO API 
The value "none" is specified in the config file as a valid value for
the "video_mode" option. The code prior to the ACO conversion did not
check for "none", but just ignored it and relied on the default zero
value. The parsing with ACO is more strict, so without handling
"none" specifically, parsing would fail.

When parsing failed, but the module loaded anyway, the config info
would never be stored, and one place in the code did not check for
this case and would segfault. It was also possible that the
aco_info struct's internals would be destroyed and used as well.

This patch keeps the module from loading after parse failures, adds
the "none" option to "video_mode", registers CLI functions only
after parsing has completed, checks the config data for NULL before
accessing it, and returns -1 on some allocation failures when
initializing.


(closes issue ASTERISK-20159)
Reported by: Birger "WIMPy" Harzenetter
Tested by: Birger "WIMPy" Harzenetter
Patches:
    confbridge_fix3.txt uploaded by Terry Wilson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370341 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 		2012-07-21 13:25:26 +00:00
..
confbridge Fix segfault introduced by conversion to ACO API 2012-07-21 13:25:26 +00:00
Makefile New HD ConfBridge conferencing application. 2011-04-21 18:11:40 +00:00
app_adsiprog.c Replace direct access to channel name with accessor functions 2012-01-09 22:15:50 +00:00
app_alarmreceiver.c Convert some strncpys to ast_copy_string 2012-04-19 19:05:17 +00:00
app_amd.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
app_authenticate.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_cdr.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_celgenuserevent.c Multiple revisions 369001-369002 2012-06-15 16:20:16 +00:00
app_chanisavail.c app_chanisavail: Fix use of uninitialized variable. 2012-03-14 23:29:32 +00:00
app_channelredirect.c Finalize ast_channel opaquification 2012-03-13 18:20:34 +00:00
app_chanspy.c Add AMI event documentation 2012-06-25 17:59:34 +00:00
app_confbridge.c Fix segfault introduced by conversion to ACO API 2012-07-21 13:25:26 +00:00
app_controlplayback.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_dahdibarge.c Opaquify ast_channel typedefs, fd arrays, and softhangup flag 2012-03-01 22:09:18 +00:00
app_dahdiras.c Opaquify ast_channel typedefs, fd arrays, and softhangup flag 2012-03-01 22:09:18 +00:00
app_db.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_dial.c Clean up ManagerEvent Dial documentation 2012-07-20 19:08:47 +00:00
app_dictate.c Opaquification for ast_format structs in struct ast_channel 2012-02-24 00:32:20 +00:00
app_directed_pickup.c Update Pickup application documentation. (With feeling this time.) 2012-04-26 21:11:25 +00:00
app_directory.c Fix coverity UNUSED_VALUE findings in core support level files 2012-06-11 15:23:30 +00:00
app_disa.c Coverity Report: Fix issues for error type UNINIT in Core supported modules 2012-05-10 15:57:26 +00:00
app_dumpchan.c Finalize ast_channel opaquification 2012-03-13 18:20:34 +00:00
app_echo.c Prevent Echo() from relaying control, null, and modem frames 2012-03-20 20:42:34 +00:00
app_exec.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_externalivr.c Remove declaration of eivr_connect_socket because it no longer exists. 2012-06-20 11:47:12 +00:00
app_fax.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
app_festival.c Opaquification for ast_format structs in struct ast_channel 2012-02-24 00:32:20 +00:00
app_flash.c Opaquify ast_channel typedefs, fd arrays, and softhangup flag 2012-03-01 22:09:18 +00:00
app_followme.c Hangup handlers - Dialplan subroutines that run when the channel hangs up. 2012-06-29 17:02:32 +00:00
app_forkcdr.c Make ForkCDR e option not set end time of the newly forked CDR log 2012-04-13 16:12:17 +00:00
app_getcpeid.c Replace direct access to channel name with accessor functions 2012-01-09 22:15:50 +00:00
app_ices.c Add missing newlines to CLI logging 2012-04-06 18:19:03 +00:00
app_image.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_ivrdemo.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_jack.c app_jack: fix datastore memory leak in error handling path. 2012-03-24 03:03:20 +00:00
app_macro.c Ensure that all ast_datastore_info structures are 'const'. 2012-07-18 17:18:20 +00:00
app_meetme.c Add AMI event documentation 2012-06-25 17:59:34 +00:00
app_milliwatt.c Replace GNU old-style field designator extensions to fix clang warnings 2012-04-04 18:08:28 +00:00
app_minivm.c Fix a variety of memory leaks 2012-05-18 14:43:44 +00:00
app_mixmonitor.c Ensure that all ast_datastore_info structures are 'const'. 2012-07-18 17:18:20 +00:00
app_morsecode.c Merged revisions 336717 via svnmerge from 2011-09-19 20:23:29 +00:00
app_mp3.c Opaquification for ast_format structs in struct ast_channel 2012-02-24 00:32:20 +00:00
app_nbscat.c Opaquification for ast_format structs in struct ast_channel 2012-02-24 00:32:20 +00:00
app_originate.c Added support for all slin formats to app_originate 2011-12-14 22:36:30 +00:00
app_osplookup.c Avoid cppcheck warnings; removing unused vars and a bit of cleanup. 2012-04-17 18:57:40 +00:00
app_page.c Fix a variety of memory leaks 2012-05-18 14:43:44 +00:00
app_parkandannounce.c Finalize ast_channel opaquification 2012-03-13 18:20:34 +00:00
app_playback.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_playtones.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_privacy.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
app_queue.c Hangup handlers - Dialplan subroutines that run when the channel hangs up. 2012-06-29 17:02:32 +00:00
app_read.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_readexten.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
app_readfile.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_record.c Fix a variety of memory leaks 2012-05-18 14:43:44 +00:00
app_saycounted.c Merged revisions 336717 via svnmerge from 2011-09-19 20:23:29 +00:00
app_sayunixtime.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_senddtmf.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_sendtext.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_setcallerid.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
app_skel.c Fix reloading an unchanged file with the Config Options API 2012-06-07 20:32:07 +00:00
app_sms.c Fix a variety of potential buffer overflows 2012-04-19 02:40:55 +00:00
app_softhangup.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_speech_utils.c Document Speech* apps hangup on failure and suggest TryExec 2012-04-20 14:50:42 +00:00
app_stack.c Ensure that all ast_datastore_info structures are 'const'. 2012-07-18 17:18:20 +00:00
app_system.c Multiple revisions 369001-369002 2012-06-15 16:20:16 +00:00
app_talkdetect.c Finalize ast_channel opaquification 2012-03-13 18:20:34 +00:00
app_test.c Opaquification for ast_format structs in struct ast_channel 2012-02-24 00:32:20 +00:00
app_transfer.c Fix the display of documentation for Transfer 2012-04-03 20:14:01 +00:00
app_url.c Merged revisions 339777 via svnmerge from 2011-10-07 19:37:33 +00:00
app_userevent.c Add AMI event documentation 2012-06-25 17:59:34 +00:00
app_verbose.c ast_channel opaquification of pointers and integral types 2012-02-20 23:43:27 +00:00
app_voicemail.c AST-2012-011: Resolve heap corruption issue with voicemail 2012-07-05 19:36:21 +00:00
app_voicemail.exports.in Remove some symbol exports that got missed in the removal of global symbols. 2012-06-15 15:33:41 +00:00
app_waitforring.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_waitforsilence.c Opaquification for ast_format structs in struct ast_channel 2012-02-24 00:32:20 +00:00
app_waituntil.c Merged revisions 328247 via svnmerge from 2011-07-14 20:28:54 +00:00
app_while.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
app_zapateller.c Opaquify ast_channel structs and lists 2012-02-29 16:52:47 +00:00
enter.h remove extraneous svn:executable properties 2005-11-29 18:24:39 +00:00
leave.h remove extraneous svn:executable properties 2005-11-29 18:24:39 +00:00