asterisk/res/res_pjsip/pjsip_global_headers.c
Kevin Harwell e62bd46511 res_pjsip: make it unloadable (take 2)
Due to the original patch causing memory corruptions it was removed until the
problem could be resolved. This patch is the original patch plus some added
locking around stasis router subcription that was needed to avoid the memory
corruption.

Description of the original problem and patch (still applicable):

The res_pjsip module was previously unloadable. With this patch it can now
be unloaded.

This patch is based off the original patch on the issue (listed below) by Corey
Farrell with a few modifications. Namely, removed a few changes not required to
make the module unloadable and also fixed a bug that would cause asterisk to
crash on unloading.

This patch is the first step (should hopefully be followed by another/others at
some point) in allowing res_pjsip and the modules that depend on it to be
unloadable. At this time, res_pjsip and some of the modules that depend on
res_pjsip cannot be unloaded without causing problems of some sort.

The goal of this patch is to get res_pjsip and only res_pjsip to be able to
unload successfully and/or shutdown without incident (crashes, leaks, etc...).
Other dependent modules may still cause problems on unload.

Basically made sure, with the patch applied, that res_pjsip (with no other
dependent modules loaded) could be succesfully unloaded and Asterisk could
shutdown without any leaks or crashes that pertained directly to res_pjsip.

ASTERISK-24485 #close
Reported by: Corey Farrell
Review: https://reviewboard.asterisk.org/r/4363/
patches:
  pjsip_unload-broken-r1.patch submitted by Corey Farrell (license 5909)
........

Merged revisions 431179 from http://svn.asterisk.org/svn/asterisk/branches/13


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@431180 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2015-01-27 19:12:56 +00:00

176 lines
4.2 KiB
C

/*
* Asterisk -- An open source telephony toolkit.
*
* Copyright (C) 2013, Digium, Inc.
*
* Mark Michelson <mmichelson@digium.com>
*
* See http://www.asterisk.org for more information about
* the Asterisk project. Please do not directly contact
* any of the maintainers of this project for assistance;
* the project provides a web site, mailing lists and IRC
* channels for your use.
*
* This program is free software, distributed under the terms of
* the GNU General Public License Version 2. See the LICENSE file
* at the top of the source tree.
*/
#include "asterisk.h"
#include <pjsip.h>
#include <pjlib.h>
#include "asterisk/res_pjsip.h"
#include "asterisk/linkedlists.h"
#include "include/res_pjsip_private.h"
static pj_status_t add_request_headers(pjsip_tx_data *tdata);
static pj_status_t add_response_headers(pjsip_tx_data *tdata);
/*!
* \brief Indicator we've already handled a specific request/response
*
* PJSIP tends to reuse requests and responses. If we already have added
* headers to a request or response, we mark the message with this value
* so that we know not to re-add the headers again.
*/
static unsigned int handled_id = 0xCA115785;
static pjsip_module global_header_mod = {
.name = {"Global headers", 13},
.priority = PJSIP_MOD_PRIORITY_APPLICATION,
.on_tx_request = add_request_headers,
.on_tx_response = add_response_headers,
};
struct header {
AST_DECLARE_STRING_FIELDS(
AST_STRING_FIELD(name);
AST_STRING_FIELD(value);
);
AST_LIST_ENTRY(header) next;
};
static struct header *alloc_header(const char *name, const char *value)
{
struct header *alloc;
alloc = ast_calloc_with_stringfields(1, struct header, 32);
if (!alloc) {
return NULL;
}
ast_string_field_set(alloc, name, name);
ast_string_field_set(alloc, value, value);
return alloc;
}
static void destroy_header(struct header *to_destroy)
{
ast_string_field_free_memory(to_destroy);
ast_free(to_destroy);
}
AST_RWLIST_HEAD(header_list, header);
static struct header_list request_headers;
static struct header_list response_headers;
static void add_headers_to_message(struct header_list *headers, pjsip_tx_data *tdata)
{
struct header *iter;
SCOPED_LOCK(lock, headers, AST_RWLIST_RDLOCK, AST_RWLIST_UNLOCK);
if (tdata->mod_data[global_header_mod.id] == &handled_id) {
return;
}
AST_LIST_TRAVERSE(headers, iter, next) {
ast_sip_add_header(tdata, iter->name, iter->value);
};
tdata->mod_data[global_header_mod.id] = &handled_id;
}
static pj_status_t add_request_headers(pjsip_tx_data *tdata)
{
add_headers_to_message(&request_headers, tdata);
return PJ_SUCCESS;
}
static pj_status_t add_response_headers(pjsip_tx_data *tdata)
{
add_headers_to_message(&response_headers, tdata);
return PJ_SUCCESS;
}
static void remove_header(struct header_list *headers, const char *to_remove)
{
struct header *iter;
AST_LIST_TRAVERSE_SAFE_BEGIN(headers, iter, next) {
if (!strcasecmp(iter->name, to_remove)) {
AST_LIST_REMOVE_CURRENT(next);
destroy_header(iter);
break;
}
}
AST_LIST_TRAVERSE_SAFE_END;
}
static int add_header(struct header_list *headers, const char *name, const char *value, int replace)
{
struct header *to_add;
to_add = alloc_header(name, value);
if (!to_add) {
return -1;
}
AST_RWLIST_WRLOCK(headers);
if (replace) {
remove_header(headers, name);
}
AST_LIST_INSERT_TAIL(headers, to_add, next);
AST_RWLIST_UNLOCK(headers);
return 0;
}
int ast_sip_add_global_request_header(const char *name, const char *value, int replace)
{
return add_header(&request_headers, name, value, replace);
}
int ast_sip_add_global_response_header(const char *name, const char *value, int replace)
{
return add_header(&response_headers, name, value, replace);
}
void ast_sip_initialize_global_headers(void)
{
AST_RWLIST_HEAD_INIT(&request_headers);
AST_RWLIST_HEAD_INIT(&response_headers);
internal_sip_register_service(&global_header_mod);
}
static void destroy_headers(struct header_list *headers)
{
struct header *iter;
while ((iter = AST_RWLIST_REMOVE_HEAD(headers, next))) {
destroy_header(iter);
}
AST_RWLIST_HEAD_DESTROY(headers);
}
void ast_sip_destroy_global_headers(void)
{
destroy_headers(&request_headers);
destroy_headers(&response_headers);
internal_sip_unregister_service(&global_header_mod);
}