When an endpoint is created, its messages are forwarded to both the tech endpoint topic and the all endpoints topic. This is done so that various parties interested in endpoint messages can subscribe to just the tech endpoint and receive all messages associated with that particular technology, as opposed to subscribing to the all endpoints topic. Unfortunately, when the tech endpoint is created, it also forwards all of its messages to the all topic. This results in duplicate messages whenever an endpoint publishes its messages. This patch resolves the duplicate message issue by creating a new function for Stasis caching topics, stasis_cp_sink_create. In most respects, this acts as a normal caching topic, save that it no longer forwards messages it receives to the all endpoints topic. This allows it to act as an aggregation "sink", while preserving the necessary caching behaviour. ASTERISK-25137 #close Reported-by: Vitezslav Novy ASTERISK-25116 #close Reported-by: George Joseph <george.joseph@fairview5.com> Tested-by: George Joseph <george.joseph@fairview5.com> Change-Id: Ie47784adfb973ab0063e59fc18f390d7dd26d17b
216 lines
4.6 KiB
C
216 lines
4.6 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2013, Digium, Inc.
|
|
*
|
|
* David M. Lee, II <dlee@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*! \file
|
|
*
|
|
* \brief Typical cache pattern for Stasis topics.
|
|
*
|
|
* \author David M. Lee, II <dlee@digium.com>
|
|
*/
|
|
|
|
/*** MODULEINFO
|
|
<support_level>core</support_level>
|
|
***/
|
|
|
|
#include "asterisk.h"
|
|
|
|
ASTERISK_REGISTER_FILE()
|
|
|
|
#include "asterisk/astobj2.h"
|
|
#include "asterisk/stasis_cache_pattern.h"
|
|
|
|
struct stasis_cp_all {
|
|
struct stasis_topic *topic;
|
|
struct stasis_topic *topic_cached;
|
|
struct stasis_cache *cache;
|
|
|
|
struct stasis_forward *forward_all_to_cached;
|
|
};
|
|
|
|
struct stasis_cp_single {
|
|
struct stasis_topic *topic;
|
|
struct stasis_caching_topic *topic_cached;
|
|
|
|
struct stasis_forward *forward_topic_to_all;
|
|
struct stasis_forward *forward_cached_to_all;
|
|
};
|
|
|
|
static void all_dtor(void *obj)
|
|
{
|
|
struct stasis_cp_all *all = obj;
|
|
|
|
ao2_cleanup(all->topic);
|
|
all->topic = NULL;
|
|
ao2_cleanup(all->topic_cached);
|
|
all->topic_cached = NULL;
|
|
ao2_cleanup(all->cache);
|
|
all->cache = NULL;
|
|
stasis_forward_cancel(all->forward_all_to_cached);
|
|
all->forward_all_to_cached = NULL;
|
|
}
|
|
|
|
struct stasis_cp_all *stasis_cp_all_create(const char *name,
|
|
snapshot_get_id id_fn)
|
|
{
|
|
RAII_VAR(char *, cached_name, NULL, ast_free);
|
|
RAII_VAR(struct stasis_cp_all *, all, NULL, ao2_cleanup);
|
|
|
|
all = ao2_t_alloc(sizeof(*all), all_dtor, name);
|
|
if (!all) {
|
|
return NULL;
|
|
}
|
|
|
|
ast_asprintf(&cached_name, "%s-cached", name);
|
|
if (!cached_name) {
|
|
return NULL;
|
|
}
|
|
|
|
all->topic = stasis_topic_create(name);
|
|
all->topic_cached = stasis_topic_create(cached_name);
|
|
all->cache = stasis_cache_create(id_fn);
|
|
all->forward_all_to_cached =
|
|
stasis_forward_all(all->topic, all->topic_cached);
|
|
|
|
if (!all->topic || !all->topic_cached || !all->cache ||
|
|
!all->forward_all_to_cached) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(all, +1);
|
|
return all;
|
|
}
|
|
|
|
struct stasis_topic *stasis_cp_all_topic(struct stasis_cp_all *all)
|
|
{
|
|
if (!all) {
|
|
return NULL;
|
|
}
|
|
return all->topic;
|
|
}
|
|
|
|
struct stasis_topic *stasis_cp_all_topic_cached(
|
|
struct stasis_cp_all *all)
|
|
{
|
|
if (!all) {
|
|
return NULL;
|
|
}
|
|
return all->topic_cached;
|
|
}
|
|
|
|
struct stasis_cache *stasis_cp_all_cache(struct stasis_cp_all *all)
|
|
{
|
|
if (!all) {
|
|
return NULL;
|
|
}
|
|
return all->cache;
|
|
}
|
|
|
|
static void one_dtor(void *obj)
|
|
{
|
|
struct stasis_cp_single *one = obj;
|
|
|
|
/* Should already be unsubscribed */
|
|
ast_assert(one->topic_cached == NULL);
|
|
ast_assert(one->forward_topic_to_all == NULL);
|
|
ast_assert(one->forward_cached_to_all == NULL);
|
|
|
|
ao2_cleanup(one->topic);
|
|
one->topic = NULL;
|
|
}
|
|
|
|
struct stasis_cp_single *stasis_cp_single_create(struct stasis_cp_all *all,
|
|
const char *name)
|
|
{
|
|
RAII_VAR(struct stasis_cp_single *, one, NULL, ao2_cleanup);
|
|
|
|
one = stasis_cp_sink_create(all, name);
|
|
if (!one) {
|
|
return NULL;
|
|
}
|
|
|
|
one->forward_topic_to_all = stasis_forward_all(one->topic, all->topic);
|
|
if (!one->forward_topic_to_all) {
|
|
return NULL;
|
|
}
|
|
one->forward_cached_to_all = stasis_forward_all(
|
|
stasis_caching_get_topic(one->topic_cached), all->topic_cached);
|
|
if (!one->forward_cached_to_all) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(one, +1);
|
|
return one;
|
|
}
|
|
|
|
struct stasis_cp_single *stasis_cp_sink_create(struct stasis_cp_all *all,
|
|
const char *name)
|
|
{
|
|
RAII_VAR(struct stasis_cp_single *, one, NULL, ao2_cleanup);
|
|
|
|
one = ao2_t_alloc(sizeof(*one), one_dtor, name);
|
|
if (!one) {
|
|
return NULL;
|
|
}
|
|
|
|
one->topic = stasis_topic_create(name);
|
|
if (!one->topic) {
|
|
return NULL;
|
|
}
|
|
one->topic_cached = stasis_caching_topic_create(one->topic, all->cache);
|
|
if (!one->topic_cached) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(one, +1);
|
|
return one;
|
|
}
|
|
|
|
void stasis_cp_single_unsubscribe(struct stasis_cp_single *one)
|
|
{
|
|
if (!one) {
|
|
return;
|
|
}
|
|
|
|
stasis_forward_cancel(one->forward_topic_to_all);
|
|
one->forward_topic_to_all = NULL;
|
|
stasis_forward_cancel(one->forward_cached_to_all);
|
|
one->forward_cached_to_all = NULL;
|
|
stasis_caching_unsubscribe(one->topic_cached);
|
|
one->topic_cached = NULL;
|
|
|
|
ao2_cleanup(one);
|
|
}
|
|
|
|
struct stasis_topic *stasis_cp_single_topic(struct stasis_cp_single *one)
|
|
{
|
|
if (!one) {
|
|
return NULL;
|
|
}
|
|
return one->topic;
|
|
}
|
|
|
|
struct stasis_topic *stasis_cp_single_topic_cached(
|
|
struct stasis_cp_single *one)
|
|
{
|
|
if (!one) {
|
|
return NULL;
|
|
}
|
|
return stasis_caching_get_topic(one->topic_cached);
|
|
}
|
|
|