asterisk/main/stasis_cache_pattern.c
David M. Lee f29d969a79 Stasis: address refcount races; implementation comments
Change r395954 reordered some stasis object destruction, which should
have been fine. Unfortunately, it caused some hard to reproduce issues
related to objects being accessed after they had been destroyed. The
patch in r396329 fixed the destruction order problem; this patch
addresses the underlying issue. A few other stasis-related fixes were
also added.

 * Add ref-bumps around areas where objects may get transitively
   destroyed. (For example, where we lock a topic, unref a subscription,
   which unrefs the topic, which explodes the topic when we try to
   unlock it.)

 * Wrote an extensive doxygen page about Stasis implementation,
   relationships between objects, lifecycles of objects, how the
   refcounting works, etc. Many other comments were added, corrected, or
   cleaned up.

 * Added an assert to the topic dtor to catch extra ref decrements.

 * Fixed type used after destruction errors for graceful shutdown in
   stasis_channels.c.

 * I added two unit tests in an attempt to catch destruction order
   issues. Since the underlying cause is a race condition, though, the
   tests rarely failed even when the code was wrong.

 * Fixed a leak in stasis_cache_pattern.c.

(closes issue ASTERISK-22243)
Review: https://reviewboard.asterisk.org/r/2746/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@396842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2013-08-16 16:03:34 +00:00

202 lines
4.3 KiB
C

/*
* Asterisk -- An open source telephony toolkit.
*
* Copyright (C) 2013, Digium, Inc.
*
* David M. Lee, II <dlee@digium.com>
*
* See http://www.asterisk.org for more information about
* the Asterisk project. Please do not directly contact
* any of the maintainers of this project for assistance;
* the project provides a web site, mailing lists and IRC
* channels for your use.
*
* This program is free software, distributed under the terms of
* the GNU General Public License Version 2. See the LICENSE file
* at the top of the source tree.
*/
/*! \file
*
* \brief Typical cache pattern for Stasis topics.
*
* \author David M. Lee, II <dlee@digium.com>
*/
/*** MODULEINFO
<support_level>core</support_level>
***/
#include "asterisk.h"
ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
#include "asterisk/astobj2.h"
#include "asterisk/stasis_cache_pattern.h"
struct stasis_cp_all {
struct stasis_topic *topic;
struct stasis_topic *topic_cached;
struct stasis_cache *cache;
struct stasis_subscription *forward_all_to_cached;
};
struct stasis_cp_single {
struct stasis_topic *topic;
struct stasis_caching_topic *topic_cached;
struct stasis_subscription *forward_topic_to_all;
struct stasis_subscription *forward_cached_to_all;
};
static void all_dtor(void *obj)
{
struct stasis_cp_all *all = obj;
ao2_cleanup(all->topic);
all->topic = NULL;
ao2_cleanup(all->topic_cached);
all->topic_cached = NULL;
ao2_cleanup(all->cache);
all->cache = NULL;
stasis_unsubscribe_and_join(all->forward_all_to_cached);
all->forward_all_to_cached = NULL;
}
struct stasis_cp_all *stasis_cp_all_create(const char *name,
snapshot_get_id id_fn)
{
RAII_VAR(char *, cached_name, NULL, ast_free);
RAII_VAR(struct stasis_cp_all *, all, NULL, ao2_cleanup);
all = ao2_alloc(sizeof(*all), all_dtor);
if (!all) {
return NULL;
}
ast_asprintf(&cached_name, "%s-cached", name);
if (!cached_name) {
return NULL;
}
all->topic = stasis_topic_create(name);
all->topic_cached = stasis_topic_create(cached_name);
all->cache = stasis_cache_create(id_fn);
all->forward_all_to_cached =
stasis_forward_all(all->topic, all->topic_cached);
if (!all->topic || !all->topic_cached || !all->cache ||
!all->forward_all_to_cached) {
return NULL;
}
ao2_ref(all, +1);
return all;
}
struct stasis_topic *stasis_cp_all_topic(struct stasis_cp_all *all)
{
if (!all) {
return NULL;
}
return all->topic;
}
struct stasis_topic *stasis_cp_all_topic_cached(
struct stasis_cp_all *all)
{
if (!all) {
return NULL;
}
return all->topic_cached;
}
struct stasis_cache *stasis_cp_all_cache(struct stasis_cp_all *all)
{
if (!all) {
return NULL;
}
return all->cache;
}
static void one_dtor(void *obj)
{
struct stasis_cp_single *one = obj;
/* Should already be unsubscribed */
ast_assert(one->topic_cached == NULL);
ast_assert(one->forward_topic_to_all == NULL);
ast_assert(one->forward_cached_to_all == NULL);
ao2_cleanup(one->topic);
one->topic = NULL;
}
struct stasis_cp_single *stasis_cp_single_create(struct stasis_cp_all *all,
const char *name)
{
RAII_VAR(struct stasis_cp_single *, one, NULL, ao2_cleanup);
one = ao2_alloc(sizeof(*one), one_dtor);
if (!one) {
return NULL;
}
one->topic = stasis_topic_create(name);
if (!one->topic) {
return NULL;
}
one->topic_cached = stasis_caching_topic_create(one->topic, all->cache);
if (!one->topic_cached) {
return NULL;
}
one->forward_topic_to_all = stasis_forward_all(one->topic, all->topic);
if (!one->forward_topic_to_all) {
return NULL;
}
one->forward_cached_to_all = stasis_forward_all(
stasis_caching_get_topic(one->topic_cached), all->topic_cached);
if (!one->forward_cached_to_all) {
return NULL;
}
ao2_ref(one, +1);
return one;
}
void stasis_cp_single_unsubscribe(struct stasis_cp_single *one)
{
if (!one) {
return;
}
stasis_unsubscribe(one->forward_topic_to_all);
one->forward_topic_to_all = NULL;
stasis_unsubscribe(one->forward_cached_to_all);
one->forward_cached_to_all = NULL;
stasis_caching_unsubscribe(one->topic_cached);
one->topic_cached = NULL;
ao2_cleanup(one);
}
struct stasis_topic *stasis_cp_single_topic(struct stasis_cp_single *one)
{
if (!one) {
return NULL;
}
return one->topic;
}
struct stasis_topic *stasis_cp_single_topic_cached(
struct stasis_cp_single *one)
{
if (!one) {
return NULL;
}
return stasis_caching_get_topic(one->topic_cached);
}