4a58261694
Git does not support the ability to replace a token with a version
string during check-in. While it does have support for replacing a
token on clone, this is somewhat sub-optimal: the token is replaced
with the object hash, which is not particularly easy for human
consumption. What's more, in practice, the source file version was often
not terribly useful. Generally, when triaging bugs, the overall version
of Asterisk is far more useful than an individual SVN version of a file. As a
result, this patch removes Asterisk's support for showing source file
versions.
Specifically, it does the following:
* Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
remove passing the version in with the macro. Other facilities
than 'core show file version' make use of the file names, such as
setting a debug level only on a specific file. As such, the act of
registering source files with the Asterisk core still has use. The
macro rename now reflects the new macro purpose.
* main/asterisk:
- Refactor the file_version structure to reflect that it no longer
tracks a version field.
- Remove the "core show file version" CLI command. Without the file
version, it is no longer useful.
- Remove the ast_file_version_find function. The file version is no
longer tracked.
- Rename ast_register_file_version/ast_unregister_file_version to
ast_register_file/ast_unregister_file, respectively.
* main/manager: Remove value from the Version key of the ModuleCheck
Action. The actual key itself has not been removed, as doing so would
absolutely constitute a backwards incompatible change. However, since
the file version is no longer tracked, there is no need to attempt to
include it in the Version key.
* UPGRADE: Add notes for:
- Modification to the ModuleCheck AMI Action
- Removal of the "core show file version" CLI command
Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
122 lines
3.2 KiB
C
122 lines
3.2 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2006-2012, Digium, Inc.
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*! \file
|
|
*
|
|
* SHELL function to return the output generated by a command issued to the system shell.
|
|
*
|
|
* \note Inspiration and Guidance from Russell! Thank You!
|
|
*
|
|
* \author Brandon Kruse <bkruse@digium.com>
|
|
*
|
|
* \ingroup functions
|
|
*/
|
|
|
|
/*** MODULEINFO
|
|
<support_level>core</support_level>
|
|
***/
|
|
|
|
#include "asterisk.h"
|
|
|
|
ASTERISK_REGISTER_FILE()
|
|
|
|
#include "asterisk/module.h"
|
|
#include "asterisk/channel.h"
|
|
#include "asterisk/pbx.h"
|
|
#include "asterisk/utils.h"
|
|
#include "asterisk/app.h"
|
|
|
|
static int shell_helper(struct ast_channel *chan, const char *cmd, char *data,
|
|
char *buf, size_t len)
|
|
{
|
|
int res = 0;
|
|
|
|
if (ast_strlen_zero(data)) {
|
|
ast_log(LOG_WARNING, "Missing Argument! Example: Set(foo=${SHELL(echo \"bar\")})\n");
|
|
return -1;
|
|
}
|
|
|
|
if (chan) {
|
|
ast_autoservice_start(chan);
|
|
}
|
|
|
|
if (len >= 1) {
|
|
FILE *ptr;
|
|
char plbuff[4096];
|
|
|
|
ptr = popen(data, "r");
|
|
if (ptr) {
|
|
while (fgets(plbuff, sizeof(plbuff), ptr)) {
|
|
strncat(buf, plbuff, len - strlen(buf) - 1);
|
|
}
|
|
pclose(ptr);
|
|
} else {
|
|
ast_log(LOG_WARNING, "Failed to execute shell command '%s'\n", data);
|
|
res = -1;
|
|
}
|
|
}
|
|
|
|
if (chan) {
|
|
ast_autoservice_stop(chan);
|
|
}
|
|
|
|
return res;
|
|
}
|
|
|
|
/*** DOCUMENTATION
|
|
<function name="SHELL" language="en_US">
|
|
<synopsis>
|
|
Executes a command using the system shell and captures its output.
|
|
</synopsis>
|
|
<syntax>
|
|
<parameter name="command" required="true">
|
|
<para>The command that the shell should execute.</para>
|
|
</parameter>
|
|
</syntax>
|
|
<description>
|
|
<para>Collects the output generated by a command executed by the system shell</para>
|
|
<para>Example: <literal>Set(foo=${SHELL(echo bar)})</literal></para>
|
|
<note>
|
|
<para>The command supplied to this function will be executed by the
|
|
system's shell, typically specified in the SHELL environment variable. There
|
|
are many different system shells available with somewhat different behaviors,
|
|
so the output generated by this function may vary between platforms.</para>
|
|
|
|
<para>If <literal>live_dangerously</literal> in <literal>asterisk.conf</literal>
|
|
is set to <literal>no</literal>, this function can only be executed from the
|
|
dialplan, and not directly from external protocols.</para>
|
|
</note>
|
|
</description>
|
|
|
|
</function>
|
|
***/
|
|
static struct ast_custom_function shell_function = {
|
|
.name = "SHELL",
|
|
.read = shell_helper,
|
|
};
|
|
|
|
static int unload_module(void)
|
|
{
|
|
return ast_custom_function_unregister(&shell_function);
|
|
}
|
|
|
|
static int load_module(void)
|
|
{
|
|
return ast_custom_function_register_escalating(&shell_function, AST_CFE_READ);
|
|
}
|
|
|
|
AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Collects the output generated by a command executed by the system shell");
|