Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the "core show file version" CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the "core show file version" CLI command Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
170 lines
4.4 KiB
C
170 lines
4.4 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2014, Kinsey Moore
|
|
*
|
|
* Kinsey Moore <kmoore@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*!
|
|
* \file
|
|
* \brief Callerid Tests
|
|
*
|
|
* \author\verbatim Kinsey Moore <kmoore@digium.com> \endverbatim
|
|
*
|
|
* This is an Asterisk test module for callerid functionality
|
|
* \ingroup tests
|
|
*/
|
|
|
|
/*** MODULEINFO
|
|
<depend>TEST_FRAMEWORK</depend>
|
|
<support_level>core</support_level>
|
|
***/
|
|
|
|
#include "asterisk.h"
|
|
#include "asterisk/callerid.h"
|
|
|
|
ASTERISK_REGISTER_FILE()
|
|
|
|
#include "asterisk/utils.h"
|
|
#include "asterisk/module.h"
|
|
#include "asterisk/test.h"
|
|
|
|
struct cid_set {
|
|
char *cid;
|
|
char *name;
|
|
char *number;
|
|
};
|
|
|
|
AST_TEST_DEFINE(parse_nominal)
|
|
{
|
|
static const struct cid_set cid_sets[] = {
|
|
{"\"name\" <number>", "name", "number"},
|
|
{"\" name \" <number>", " name ", "number"},
|
|
{"name <number>", "name", "number"},
|
|
{" name <number>", "name", "number"},
|
|
{"\"\" <number>", NULL, "number"},
|
|
{"<number>", NULL, "number"},
|
|
{"name", "name", NULL},
|
|
{" name", "name", NULL},
|
|
{"\"name\"", "name", NULL},
|
|
{"\"*10\"", "*10", NULL},
|
|
{" \"*10\"", "*10", NULL},
|
|
{"\"name\" <>", "name", NULL},
|
|
{"name <>", "name", NULL},
|
|
{"1234", NULL, "1234"},
|
|
{" 1234", NULL, "1234"},
|
|
{"\"na\\\"me\" <number>", "na\"me", "number"},
|
|
};
|
|
char *name;
|
|
char *number;
|
|
int i;
|
|
|
|
switch (cmd) {
|
|
case TEST_INIT:
|
|
info->name = "parse_nominal";
|
|
info->category = "/main/callerid/";
|
|
info->summary = "Callerid nominal parse unit test";
|
|
info->description =
|
|
"This tests parsing of nominal callerid strings.";
|
|
return AST_TEST_NOT_RUN;
|
|
case TEST_EXECUTE:
|
|
break;
|
|
}
|
|
|
|
for (i = 0; i < ARRAY_LEN(cid_sets); i++) {
|
|
RAII_VAR(char *, callerid, ast_strdup(cid_sets[i].cid), ast_free);
|
|
|
|
ast_callerid_parse(callerid, &name, &number);
|
|
if (!cid_sets[i].name == !ast_strlen_zero(name) || (cid_sets[i].name && strcmp(name, cid_sets[i].name))) {
|
|
ast_test_status_update(test,
|
|
"Expected callerid name '%s' instead of '%s'\n",
|
|
cid_sets[i].name, name);
|
|
return AST_TEST_FAIL;
|
|
}
|
|
|
|
if (!cid_sets[i].number == !ast_strlen_zero(number) || (cid_sets[i].number && strcmp(number, cid_sets[i].number))) {
|
|
ast_test_status_update(test,
|
|
"Expected callerid number '%s' instead of '%s'\n",
|
|
cid_sets[i].number, number);
|
|
return AST_TEST_FAIL;
|
|
}
|
|
}
|
|
|
|
return AST_TEST_PASS;
|
|
}
|
|
|
|
AST_TEST_DEFINE(parse_off_nominal)
|
|
{
|
|
static const struct cid_set cid_sets[] = {
|
|
{"na\\\"me <number>", "na\"me", "number"},
|
|
{"\"na\"me\" <number>", "na\"me", "number"},
|
|
{"na\"me <number>", "na\"me", "number"},
|
|
{"\"name <number>", "\"name", "number"},
|
|
{"name <number", "name", "number"},
|
|
{"\"name <number>\"", "name", "number"},
|
|
};
|
|
char *name;
|
|
char *number;
|
|
int i;
|
|
|
|
switch (cmd) {
|
|
case TEST_INIT:
|
|
info->name = "parse_off_nominal";
|
|
info->category = "/main/callerid/";
|
|
info->summary = "Callerid off-nominal parse unit test";
|
|
info->description =
|
|
"This tests parsing of off-nominal callerid strings.";
|
|
return AST_TEST_NOT_RUN;
|
|
case TEST_EXECUTE:
|
|
break;
|
|
}
|
|
|
|
for (i = 0; i < ARRAY_LEN(cid_sets); i++) {
|
|
RAII_VAR(char *, callerid, ast_strdup(cid_sets[i].cid), ast_free);
|
|
|
|
ast_callerid_parse(callerid, &name, &number);
|
|
if (!cid_sets[i].name == !ast_strlen_zero(name) || (cid_sets[i].name && strcmp(name, cid_sets[i].name))) {
|
|
ast_test_status_update(test,
|
|
"Expected callerid name '%s' instead of '%s'\n",
|
|
cid_sets[i].name, name);
|
|
return AST_TEST_FAIL;
|
|
}
|
|
|
|
if (!cid_sets[i].number == !ast_strlen_zero(number) || (cid_sets[i].number && strcmp(number, cid_sets[i].number))) {
|
|
ast_test_status_update(test,
|
|
"Expected callerid number '%s' instead of '%s'\n",
|
|
cid_sets[i].number, number);
|
|
return AST_TEST_FAIL;
|
|
}
|
|
}
|
|
|
|
return AST_TEST_PASS;
|
|
}
|
|
|
|
static int unload_module(void)
|
|
{
|
|
AST_TEST_UNREGISTER(parse_nominal);
|
|
AST_TEST_UNREGISTER(parse_off_nominal);
|
|
return 0;
|
|
}
|
|
|
|
static int load_module(void)
|
|
{
|
|
AST_TEST_REGISTER(parse_nominal);
|
|
AST_TEST_REGISTER(parse_off_nominal);
|
|
return AST_MODULE_LOAD_SUCCESS;
|
|
}
|
|
|
|
AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Callerid Parse Tests");
|