939dcf66b0
The two reasons why it might be used are that some systems do not implement strerror in thread safe manner, and that strerror_r returns the error code in the string in case there's no error message. However, all of asterisk elsewhere uses strerror() and assumes it to be thread safe. And in chan_mobile the errno is also explicitly printed so neither of the above reasons are valid. The reasoning to remove usage is that there are actually two versions of strerror_r: XSI and GNU. They are incompatible in their return value, and there's no easy way to figure out which one is being used. glibc gives you the GNU version if _GNU_SOURCE is defined, but the same feature test macro is needed for other symbols. On all other systems you assumedly get XSI symbol, and compilation warnings as well as non-working error printing. Thus the easiest solution is to just remove strerror_r and use strerror as rest of the code. Alternative is to introduce ast_strerror in separate translation unit so it can request the XSI symbol in glibc case, and replace all usage of strerror. Change-Id: I84d35225b5642d85d48bc35fdf399afbae28a91d |
||
|---|---|---|
| .. | ||
| ooh323c | ||
| .gitignore | ||
| app_mysql.c | ||
| cdr_mysql.c | ||
| chan_mobile.c | ||
| chan_ooh323.c | ||
| chan_ooh323.h | ||
| format_mp3.c | ||
| Makefile | ||
| ooh323cDriver.c | ||
| ooh323cDriver.h | ||
| res_config_mysql.c | ||