From 2158249069ad9f56614e874c36147ba68364913f Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Tue, 1 Oct 2013 11:35:27 -0500 Subject: [PATCH] hfp_hf_bluez5: Be more pedantic in get_version If no 'Version' key is found we might be assigning an uninitialized value. Return an error in this case as the 'Version' key is required. --- plugins/hfp_hf_bluez5.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index cd8f75ec..18ed348a 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -449,13 +449,14 @@ static int get_version(DBusMessageIter *iter, uint16_t *version) dbus_message_iter_recurse(&entry, &valiter); dbus_message_iter_get_basic(&valiter, &value); - break; + + if (version) + *version = value; + + return 0; } - if (version) - *version = value; - - return 0; + return -ENOENT; } static DBusMessage *profile_new_connection(DBusConnection *conn,