From 26a00f2f31225b9ec8564a9fc6c3987480e47e36 Mon Sep 17 00:00:00 2001 From: Arman Uguray Date: Fri, 27 Feb 2015 00:16:24 -0800 Subject: [PATCH] gdbus/client: Don't GetManagedObjects w/o handlers The client code currently issues GetManagedObjects if new handlers are set via g_dbus_client_set_proxy_handlers. An application may set these to NULL before unref'ing a client or to simply prevent further events. Hence, there is no need to refresh objects or properties if all handlers are NULL. --- gdbus/client.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdbus/client.c b/gdbus/client.c index 238b3482..cd5c7678 100644 --- a/gdbus/client.c +++ b/gdbus/client.c @@ -1374,7 +1374,8 @@ gboolean g_dbus_client_set_proxy_handlers(GDBusClient *client, client->property_changed = property_changed; client->user_data = user_data; - get_managed_objects(client); + if (proxy_added || proxy_removed || property_changed) + get_managed_objects(client); return TRUE; }