From 2864624c56dd79eaf8a7122a3dbde1b4c85d8657 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Thu, 21 Mar 2013 10:19:00 -0500 Subject: [PATCH] hfp_ag_bluez5: Fix sanity check We should be checking that modems != NULL, not modems->data. This is because the list can be empty and we would crash. --- plugins/hfp_ag_bluez5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/hfp_ag_bluez5.c b/plugins/hfp_ag_bluez5.c index a81adfd7..64ea8ca1 100644 --- a/plugins/hfp_ag_bluez5.c +++ b/plugins/hfp_ag_bluez5.c @@ -84,14 +84,14 @@ static DBusMessage *profile_new_connection(DBusConnection *conn, DBG("%s", device); /* Pick the first voicecall capable modem */ - modem = modems->data; - if (modem == NULL) { + if (modems == NULL) { close(fd); return g_dbus_create_error(msg, BLUEZ_ERROR_INTERFACE ".Rejected", "No voice call capable modem"); } + modem = modems->data; DBG("Picked modem %p for emulator", modem); em = ofono_emulator_create(modem, OFONO_EMULATOR_TYPE_HFP);