sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

qmi: remove unused fields of service_send_data 

After setting up the request structure, qmi_service_send makes no
further use of the 'param' and 'service' fields of the service_send_data
structure.  This patch removes those fields and frees 'param'
immediately after the request has been allocated and the parameter data
thereby copied into the send buffer.
This commit is contained in:
Jonas Bonn 2018-03-29 15:57:50 +02:00 committed by Denis Kenzior
parent 8b8a760644
commit 4846c26948
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/qmimodem/qmi.c
View File

@ -2238,8 +2238,6 @@ bool qmi_service_get_version(struct qmi_service *service,
}
struct service_send_data {
struct qmi_service *service;
struct qmi_param *param;
qmi_result_func_t func;
void *user_data;
qmi_destroy_func_t destroy;
@ -2250,8 +2248,6 @@ static void service_send_free(struct service_send_data *data)
if (data->destroy)
data->destroy(data->user_data);
qmi_param_free(data->param);
g_free(data);
}
@ -2308,22 +2304,23 @@ uint16_t qmi_service_send(struct qmi_service *service,
if (!data)
return 0;
data->service = service;
data->param = param;
data->func = func;
data->user_data = user_data;
data->destroy = destroy;
req = __request_alloc(service->type, service->client_id,
message, QMI_SERVICE_HDR_SIZE,
data->param ? data->param->data : NULL,
data->param ? data->param->length : 0,
param ? param->data : NULL,
param ? param->length : 0,
service_send_callback, data, (void **) &hdr);
if (!req) {
g_free(data);
return 0;
}
qmi_param_free(param);
if (device->next_service_tid < 256)
device->next_service_tid = 256;