mirror of git://git.sysmocom.de/ofono
coding-style: mention preferred line wrap
This commit is contained in:
parent
66a8002d6a
commit
4df428f470
|
@ -75,10 +75,11 @@ Example:
|
||||||
a + b; // correct
|
a + b; // correct
|
||||||
|
|
||||||
|
|
||||||
M4: Long condition
|
M4: Wrap long lines
|
||||||
==================
|
===================
|
||||||
If your condition in if, while, for statement is too long to fit in one line,
|
If your condition in if, while, for statement or a function declaration is too
|
||||||
the new line needs to be indented not aligned with the body.
|
long to fit in one line, the new line needs to be indented not aligned with the
|
||||||
|
body.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
1)
|
1)
|
||||||
|
@ -91,6 +92,40 @@ if (call->status == CALL_STATUS_ACTIVE ||
|
||||||
call->status == CALL_STATUS_HELD) { // correct
|
call->status == CALL_STATUS_HELD) { // correct
|
||||||
ofono_dbus_dict_append();
|
ofono_dbus_dict_append();
|
||||||
|
|
||||||
|
3)
|
||||||
|
gboolean sim_ust_is_available(unsigned char *service_ust, unsigned char len,
|
||||||
|
num sim_ust_service index) // wrong
|
||||||
|
{
|
||||||
|
int a;
|
||||||
|
...
|
||||||
|
}
|
||||||
|
|
||||||
|
4)
|
||||||
|
gboolean sim_ust_is_available(unsigned char *service_ust, unsigned char len,
|
||||||
|
enum sim_ust_service index) // correct
|
||||||
|
{
|
||||||
|
int a;
|
||||||
|
...
|
||||||
|
}
|
||||||
|
|
||||||
|
If the line being wrapped is a function call or function declaration, the
|
||||||
|
preferred style is to indent at least past the opening parenthesis. Indenting
|
||||||
|
further is acceptable as well (as long as you don't hit the 80 character
|
||||||
|
limit).
|
||||||
|
|
||||||
|
If this is not possible due to hitting the 80 character limit, then indenting
|
||||||
|
as far as possible to the right without hitting the limit is preferred.
|
||||||
|
|
||||||
|
Example:
|
||||||
|
|
||||||
|
1)
|
||||||
|
gboolean sim_ust_is_available(unsigned char *service_ust, unsigned char len,
|
||||||
|
enum sim_ust_service index); // worse
|
||||||
|
|
||||||
|
2)
|
||||||
|
gboolean sim_ust_is_available(unsigned char *service_ust, unsigned char len,
|
||||||
|
enum sim_ust_service index); // better
|
||||||
|
|
||||||
|
|
||||||
M5: Git commit message 50/72 formatting
|
M5: Git commit message 50/72 formatting
|
||||||
=======================================
|
=======================================
|
||||||
|
|
Loading…
Reference in New Issue