From 66cd5df5d754ffa30f4d9a189d62c71658fb86b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20R=C3=B6jfors?= Date: Sun, 20 Dec 2020 11:18:27 +0000 Subject: [PATCH] huawei: Fix implicit enum conversion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GCC 10 warns about this implicit conversion: drivers/huaweimodem/radio-settings.c: In function ‘band_gsm_from_huawei’: drivers/huaweimodem/radio-settings.c:107:10: error: implicit conversion from ‘enum ofono_radio_band_umts’ to ‘enum ofono_radio_band_gsm’ [-Werror=enum-conversion] 107 | return OFONO_RADIO_BAND_UMTS_ANY; Member from the incorrect enum was returned, both had the value 0, so the code would still work. --- drivers/huaweimodem/radio-settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c index c8ebcba0..b3f31e56 100644 --- a/drivers/huaweimodem/radio-settings.c +++ b/drivers/huaweimodem/radio-settings.c @@ -104,7 +104,7 @@ static enum ofono_radio_band_gsm band_gsm_from_huawei(unsigned int band) size_t i; if (band == HUAWEI_BAND_ANY) - return OFONO_RADIO_BAND_UMTS_ANY; + return OFONO_RADIO_BAND_GSM_ANY; for (i = ARRAY_SIZE(huawei_band_gsm_table) - 1; i > 0; i--) { if (huawei_band_gsm_table[i].band_huawei & band)