sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

atmodem: Shutdown ppp cleanly on remove 

There is a race condition from udev / kernel when a USB dongle is
removed.  Sometimes all ports are removed first (and the io channels for
those ports are signaled as hupped) while other times the udev remove
event fires first.

If the latter happens, then gprs_context remove is called with a
potentially live ppp object.  This patch shuts it down cleanly.
This commit is contained in:
Denis Kenzior 2010-06-11 09:17:27 -05:00
parent c3dddcb5b3
commit 76dc7e4acd
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/atmodem/gprs-context.c
View File

@ -254,6 +254,13 @@ static void at_gprs_context_remove(struct ofono_gprs_context *gc)
{
struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
DBG("");
if (gcd->state != STATE_IDLE) {
g_at_ppp_unref(gcd->ppp);
g_at_chat_resume(gcd->chat);
}
ofono_gprs_context_set_data(gc, NULL);
g_free(gcd);
}