From 823215ff669a78d8c031f631c8ab3134e35d62f3 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Thu, 21 Mar 2013 10:18:11 -0500 Subject: [PATCH] dun_gw_bluez5: Fix sanity check We should be checking that modems != NULL, not modems->data. This is because the list can be empty and we would crash. --- plugins/dun_gw_bluez5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/dun_gw_bluez5.c b/plugins/dun_gw_bluez5.c index bd0d5530..9844092f 100644 --- a/plugins/dun_gw_bluez5.c +++ b/plugins/dun_gw_bluez5.c @@ -81,14 +81,14 @@ static DBusMessage *profile_new_connection(DBusConnection *conn, DBG("%s", device); /* Pick the first powered modem */ - modem = modems->data; - if (modem == NULL) { + if (modems == NULL) { close(fd); return g_dbus_create_error(msg, BLUEZ_ERROR_INTERFACE ".Rejected", "No GPRS capable modem"); } + modem = modems->data; DBG("Picked modem %p for emulator", modem); em = ofono_emulator_create(modem, OFONO_EMULATOR_TYPE_DUN);