sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

smsutil: Don't bother renaming to the same name 

In sms_tx_queue_load, if the resulting file is the same (which is quite
often the case) then don't bother trying to rename it.
This commit is contained in:
Denis Kenzior 2011-01-28 20:27:58 -06:00
parent 31a4c0025d
commit 971bdfbe48
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/smsutil.c
View File

@ -3237,7 +3237,7 @@ GQueue *sms_tx_queue_load(const char *imsi)
struct dirent **entries;
int len;
int i;
unsigned long k;
unsigned long id;
if (imsi == NULL)
return NULL;
@ -3250,17 +3250,18 @@ GQueue *sms_tx_queue_load(const char *imsi)
retq = g_queue_new();
for (i = 0, k = 0; i < len; i++) {
for (i = 0, id = 0; i < len; i++) {
char uuid[SMS_MSGID_LEN * 2 + 1];
GSList *msg_list;
unsigned long oldid;
unsigned long flags;
char *oldpath, *newpath;
struct txq_backup_entry *entry;
struct dirent *dir = entries[i];
char endc;
if (sscanf(dir->d_name, "%*u-%lu-" SMS_MSGID_FMT "%c",
&flags, uuid, &endc) != 2)
if (sscanf(dir->d_name, "%lu-%lu-" SMS_MSGID_FMT "%c",
&oldid, &flags, uuid, &endc) != 3)
continue;
if (strlen(uuid) != 2 * SMS_MSGID_LEN)
@ -3277,9 +3278,15 @@ GQueue *sms_tx_queue_load(const char *imsi)
g_queue_push_tail(retq, entry);
/* Don't bother re-shuffling the ids if they are the same */
if (oldid == id) {
id++;
continue;
}
oldpath = g_strdup_printf("%s/%s", path, dir->d_name);
newpath = g_strdup_printf(SMS_TX_BACKUP_PATH_DIR,
imsi, k++, flags, uuid);
imsi, id++, flags, uuid);
/* rename directory to reflect new position in queue */
rename(oldpath, newpath);