From 9edf68c553985b844a6e99d17afa8962d26c4137 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= Date: Wed, 23 Mar 2011 18:16:35 +0100 Subject: [PATCH] common: fix buffer length in phone_number_to_string update buffer length related to OFONO_MAX_PHONE_NUMBER_LENGTH change 78c1e96bf9601b5e5d31d04413baa1265a1c284f --- src/common.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/common.c b/src/common.c index 520360c0..e65a677f 100644 --- a/src/common.c +++ b/src/common.c @@ -422,16 +422,16 @@ int mmi_service_code_to_bearer_class(int code) const char *phone_number_to_string(const struct ofono_phone_number *ph) { - static char buffer[64]; + static char buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 2]; if (ph->type == 145 && (strlen(ph->number) > 0) && ph->number[0] != '+') { buffer[0] = '+'; - strncpy(buffer + 1, ph->number, 62); - buffer[63] = '\0'; + strncpy(buffer + 1, ph->number, OFONO_MAX_PHONE_NUMBER_LENGTH); + buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 1] = '\0'; } else { - strncpy(buffer, ph->number, 63); - buffer[63] = '\0'; + strncpy(buffer, ph->number, OFONO_MAX_PHONE_NUMBER_LENGTH + 1); + buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 1] = '\0'; } return buffer;