From b363b8f0cf72af7a571988eb5c6c6f8c531ea858 Mon Sep 17 00:00:00 2001 From: Jeevaka Badrappan Date: Sat, 5 Feb 2011 06:29:05 -0800 Subject: [PATCH] coding-style: Don't use hex with shift operator --- doc/coding-style.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index 40bb36b9..287e9e92 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -294,6 +294,18 @@ void foo() // Wrong { } +M16: Don't use hex value with shift operators +============================================== +The expression argument to the shift operators should not be in hex. + +Example: + +1) +1 << y + +2) +0x1 << y // Wrong + O1: Shorten the name ==================== Better to use abbreviation, rather than full name, to name a variable,