sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

radio-settings: Fix potential leak 

rs->imsi is only freed when rs->settings is true.  So tweak the logic
inside radio_load_settings to only strdup the imsi when settings
creation has succeeded.
This commit is contained in:
Denis Kenzior 2016-04-07 09:19:13 -05:00
parent 77a3c58148
commit b708f9f6b3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/radio-settings.c
View File

@ -811,8 +811,7 @@ static void radio_load_settings(struct ofono_radio_settings *rs,
GError *error; GError *error;
char *strmode; char *strmode;
rs->imsi = g_strdup(imsi); rs->settings = storage_open(imsi, SETTINGS_STORE);
rs->settings = storage_open(rs->imsi, SETTINGS_STORE);
/* /*
* If no settings present or error; Set default. * If no settings present or error; Set default.
@ -824,6 +823,8 @@ static void radio_load_settings(struct ofono_radio_settings *rs,
return; return;
} }
rs->imsi = g_strdup(imsi);
error = NULL; error = NULL;
strmode = g_key_file_get_string(rs->settings, SETTINGS_GROUP, strmode = g_key_file_get_string(rs->settings, SETTINGS_GROUP,
"TechnologyPreference", &error); "TechnologyPreference", &error);