sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

sim: Don't re-check for id != 0 

We already check the id is valid in the get_icon function, there's no
reason to re-check it.
This commit is contained in:
Denis Kenzior 2010-10-11 20:40:16 -05:00
parent 920ee13a2b
commit b750de3ec6
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/sim.c
View File

@ -826,14 +826,6 @@ static void sim_get_image(struct ofono_sim *sim, unsigned char id,
unsigned char *efimg;
char *image;
/* icon ids should start at 1, our array starts at zero */
if (id == 0) {
sim_get_image_cb(0, NULL, 0, user_data);
return;
}
id--;
image = sim_fs_get_cached_image(sim->simfs, id);
if (image == NULL)
@ -901,7 +893,7 @@ static DBusMessage *sim_get_icon(DBusConnection *conn,
sim->pending = dbus_message_ref(msg);
sim_get_image(sim, id, sim);
sim_get_image(sim, id - 1, sim);
return NULL;
}