sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

atmodem: Ignore results from IFX radio signal strength indication 

It seems the that XCIEV notification actually returns results from XCSQ
and not the described range 0-7. This makes this notification rather
useless to report signal strength.
This commit is contained in:
Marcel Holtmann 2012-02-16 08:12:28 +01:00
parent 5fb0594750
commit bba5a1a000
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/atmodem/network-registration.c
View File

@ -680,8 +680,8 @@ static void ifx_xhomezr_notify(GAtResult *result, gpointer user_data)
static void ifx_xciev_notify(GAtResult *result, gpointer user_data)
{
struct ofono_netreg *netreg = user_data;
int strength, ind;
//struct ofono_netreg *netreg = user_data;
int ind;
GAtResultIter iter;
g_at_result_iter_init(&iter, result);
@ -692,22 +692,14 @@ static void ifx_xciev_notify(GAtResult *result, gpointer user_data)
if (!g_at_result_iter_next_number(&iter, &ind))
return;
DBG("ind %d", ind);
/*
* Radio signal strength indicators are defined for 0-7,
* but in some cases XCIEV just returns CSQ 0-31,99 values.
* but this notification seems to return CSQ 0-31,99 values.
*
* Ignore this indication for now since it can not be trusted.
*/
if (ind == 0 || ind == 99)
strength = -1;
else if (ind == 7)
strength = 100;
else if (ind < 7)
strength = (ind * 15);
else if (ind > 7)
strength = (ind * 100) / 31;
DBG("ind %d strength %d", ind, strength);
ofono_netreg_strength_notify(netreg, strength);
}
static void ciev_notify(GAtResult *result, gpointer user_data)