sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

smsutil: Fix uninitialized optional elements 

sms_decode was never memsetting the returned structure, so if any
optional elements were present in the SMS (e.g. status report) then the
structure was not completely initialized.
This commit is contained in:
Denis Kenzior 2010-12-02 07:53:54 -06:00
parent ac72349017
commit c5a42cfabe
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/smsutil.c
View File

@ -1024,8 +1024,6 @@ static gboolean decode_status_report(const unsigned char *pdu, int len,
if (out->status_report.pi & 0x02) {
if (!next_octet(pdu, len, &offset, &out->status_report.dcs))
return FALSE;
} else {
out->status_report.dcs = 0;
}
if (out->status_report.pi & 0x04) {
@ -1509,6 +1507,8 @@ gboolean sms_decode(const unsigned char *pdu, int len, gboolean outgoing,
if (len == 0)
return FALSE;
memset(out, 0, sizeof(*out));
if (tpdu_len < len) {
if (!sms_decode_address_field(pdu, len, &offset,
TRUE, &out->sc_addr))