sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity

Fix case where CMGS returns an error before pdu 

Commands like CMGS might return an error before the entire command
has been submitted.  This results in gatchat stalling completely.
This commit is contained in:
Denis Kenzior 2009-07-07 14:31:11 -05:00
parent db71137fd2
commit c74ea2093f
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gatchat/gatchat.c
View File

@ -466,9 +466,21 @@ static void have_line(GAtChat *p, gboolean strip_preceding)
cmd = g_queue_peek_head(p->command_queue);
if (cmd && p->cmd_bytes_written == strlen(cmd->cmd) &&
g_at_chat_handle_command_response(p, cmd, str))
return;
if (cmd) {
char c = cmd->cmd[p->cmd_bytes_written - 1];
/* We check that we have submitted a terminator, in which case
* a command might have failed or completed successfully
*
* In the generic case, \r is at the end of the command, so we
* know the entire command has been submitted. In the case of
* commands like CMGS, every \r or Ctrl-Z might result in a
* final response from the modem, so we check this as well.
*/
if ((c == '\r' || c == 26) &&
g_at_chat_handle_command_response(p, cmd, str))
return;
}
if (g_at_chat_match_notify(p, str) == TRUE)
return;