From c759aea7d93e6f26863bd6e839e3eb5e8b77e75a Mon Sep 17 00:00:00 2001 From: Lucas De Marchi Date: Wed, 1 Dec 2010 13:46:44 -0200 Subject: [PATCH] HACKING: add guidelines to patch submission --- HACKING | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/HACKING b/HACKING index e8251856..3322554a 100644 --- a/HACKING +++ b/HACKING @@ -91,3 +91,22 @@ Other debugging settings that can be toggled: - Environment variable OFONO_AT_DEBUG (set to 1): enable AT commands debugging + + +Submitting patches +================== + +If you fixed a bug or you want to add support for something, patches are +welcome! In order to ease the inclusion of your patch, it's important to follow +some rules, otherwise it will likely be rejected by maintainers: + +1) Do *not* add "Signed-off-by" lines in your commit messages. oFono does not +use them, so including them is actually an error. + +2) Be sure to follow the coding style rules of oFono. They are listed in +doc/coding-style.txt. + +3) Split your patch according to the top-level directories. E.g.: if you added +a feature that touches files under 'include/', 'src/' and 'drivers/' +directories, split in three separated patches, taking care not to +break compilation.