From cae45537101a8becf37e8554f18b8e395f8abaa5 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Tue, 19 Apr 2011 13:31:37 -0500 Subject: [PATCH] emulator: Use a switch/case instead of if Seems a bit cleaner --- src/emulator.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index d941d743..9b4647b4 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -910,15 +910,20 @@ void ofono_emulator_set_indicator(struct ofono_emulator *em, if (!callsetup) return; - if (value == OFONO_EMULATOR_CALLSETUP_INCOMING) { + switch (value) { + case OFONO_EMULATOR_CALLSETUP_INCOMING: if (call_ind->value == OFONO_EMULATOR_CALL_INACTIVE) send_callsetup_notification(em); em->callsetup_source = g_timeout_add_seconds(RING_TIMEOUT, send_callsetup_notification, em); - } else if (value != OFONO_EMULATOR_CALLSETUP_INCOMING && - em->callsetup_source) { - g_source_remove(em->callsetup_source); - em->callsetup_source = 0; + break; + default: + if (em->callsetup_source > 0) { + g_source_remove(em->callsetup_source); + em->callsetup_source = 0; + } + + break; } }