Commit Graph

40 Commits

Author SHA1 Message Date
Denis Kenzior ca105f7040 ppp_net: Make static analysis tools happy
The kernel simply puts a null terminator at index 15 prior to ifr_name
processing.  So we do the same.

Original report by:
Sabas Rosales, Blanca E <blanca.e.sabas.rosales@intel.com>

 Buffer not null terminated (BUFFER_SIZE_WARNING) buffer_size_warning:
 Calling strncpy with a maximum size argument of 16 bytes on destination
 array ifr.ifr_ifrn.ifrn_name of size 16 bytes might leave the
 destination string unterminated.

  67        strncpy(ifr.ifr_name, net->if_name, sizeof(ifr.ifr_name));
2015-07-28 10:16:16 -05:00
Sergey Alirzaev 4a937b96aa build: make ofono build against musl
ifdef away GNU libc extensions and use a POSIXly correct pointer type
2015-07-01 08:09:53 -05:00
Daniel Wagner ef7a4bc3a7 gatchat: Print error message if opening tun failes
This is a very common mistake. Let's help the users to
configure their system correctly.
2012-08-30 17:06:09 -05:00
Marcel Holtmann 21f9da9916 gatchat: Update copyright information 2011-10-10 13:39:25 -07:00
Denis Kenzior 2eb4611de8 ppp: Add basic length sanity checks 2011-06-29 05:00:56 -05:00
Marcel Holtmann 3297a3e865 gatchat: Fix unused variable cases 2011-05-27 09:52:31 -07:00
Denis Kenzior 92e0657eed ppp_net: Keep valgrind happy 2011-05-25 05:30:38 -05:00
Guillaume Zajac 47f5887c29 ppp_net: add ppp_net_resume_interface() API 2011-05-24 12:25:07 -05:00
Denis Kenzior e8c7fc8a8a ppp_net: streamline ppp_net_new logic 2011-05-24 12:10:22 -05:00
Guillaume Zajac 7e5ccc18d7 gatppp: Add new contructor to use external fd 2011-05-24 12:10:22 -05:00
Denis Kenzior d48c309151 ppp_net: Reset the watch to zero when removing 2011-05-08 23:02:19 -05:00
Guillaume Zajac 9fea153593 ppp_net: add ppp_net_suspend_interface() function 2011-05-08 23:00:12 -05:00
Marcel Holtmann d0cbae0092 ppp: Fix some coding style and memory leaks 2010-10-21 18:26:50 +02:00
Denis Kenzior 1803f00c6e ppp: Trivial whitespace error 2010-05-19 05:26:21 -05:00
Kristen Carlson Accardi 3fff4c49c8 ppp: implement ppp_packet_new 2010-05-19 02:58:45 -05:00
Kristen Carlson Accardi 41188e326a ppp: fix another hardcode of ppp_packet size 2010-05-11 09:26:08 -05:00
Kristen Carlson Accardi 125fc62526 ppp: set address and control field
Before sending to hdlc, set the address and control field.
Fix hardcode of ppp header size.
2010-05-10 16:27:15 -05:00
Denis Kenzior db0b7c8a98 ppp: Accept 1500 byte MTUs 2010-04-28 17:27:36 -05:00
Denis Kenzior 955673573b ppp: Make ppp_net_process_packet const correct 2010-04-28 17:27:35 -05:00
Denis Kenzior fa5e8cf56b ppp: Fix trivial style error 2010-04-22 17:58:29 -05:00
Kristen Carlson Accardi e98fb9a6bd ppp: change MTU on TUN device when MRU option received 2010-04-22 17:56:31 -05:00
Kristen Carlson Accardi 71775550fe ppp: implement MRU option
If the peer requests a MRU option, set the mtu for the network
phase.  When we are in link establishment phase, we should
continue to behave as if no option has been set and the peer
should use the default MRU.

This option is required for the Huawei E160G modem.
2010-04-22 07:00:40 +02:00
Denis Kenzior c74e2ab189 ppp: TUN channel should not be opened NONBLOCKING
We don't handle it as a nonblocking channel and getting it right would
be a nightmare.
2010-04-13 15:35:55 -05:00
Denis Kenzior 0aaf98a354 ppp: Get rid of net_open and net_close
There really isn't a need for these now
2010-04-13 15:14:40 -05:00
Denis Kenzior 6525826455 ppp: Hide ppp_net definition in ppp_net.c 2010-04-13 14:42:59 -05:00
Kristen Carlson Accardi 3c3077f847 ppp: implement net close 2010-04-02 19:03:56 -05:00
Denis Kenzior ebc6e3b9dc Refactor: Get rid of (now) pointless comments 2010-04-02 19:03:56 -05:00
Denis Kenzior 2c466c8baf Refactor: Get rid of packet handler registrations
There are only about 4 protocols that the current ppp code handles and
it is doubtful that it will grow much more.  There's no point in having
an extensive packet handler registration framework.
2010-04-02 15:11:48 -05:00
Marcel Holtmann 843d3bd2a3 Add missing arpa/inet.h includes 2010-04-02 11:42:42 -07:00
Denis Kenzior 1ed6966cb4 Split out ipcp protocol into ppp_ipcp.c 2010-04-02 12:53:45 -05:00
Marcel Holtmann 4f99859d37 Remove useless pppcp_protocol_data structure 2010-04-01 09:13:44 -07:00
Marcel Holtmann 5f0d8493e7 Remove forward declarations in PPP network handling 2010-04-01 00:17:10 -07:00
Marcel Holtmann eb9e7872a9 Add debugging for PPP LCP and IPCP options 2010-04-01 00:07:40 -07:00
Marcel Holtmann f081de4ea6 Use ppp%d as PPP interface name instead of tun%d 2010-03-31 22:29:43 -07:00
Denis Kenzior d6093b819f Refactor: GAtPPP connect callback
The connect callback was not giving enough information and the
information it was providing was not in a convenient form.

- Provide the ppp interface name (e.g. tun0)
- Provide ip, dns1 & dns2 as strings
- Do not send the ppp structure in the callback, it is most likely
  present in the user data anyway
2010-03-31 18:45:17 -05:00
Denis Kenzior a3eeb88511 Style: remove unneeded blank line 2010-03-31 13:04:57 -05:00
Marcel Holtmann f87537644b Fix whitespace damage in PPP implementation 2010-03-31 10:30:54 -07:00
Marcel Holtmann 95bceddba4 Add support for NBNS server options 2010-03-26 19:25:56 -07:00
Kristen Carlson Accardi af63a2b8ee ppp: change debug output to include control protocol prefix 2010-03-25 12:38:57 -07:00
Kristen Carlson Accardi a84fc350b4 IP support for PPP
Adds IPCP support, and creates a TUN interface for sending/receiving IP
packets.
2010-03-22 17:28:23 -07:00