function to set the powered timeout for those cases where a device might
require longer time to boot (uncommon).
The function is effective if called before Powered=true,
so it is best called by modem detection logic and prior to calling
ofono_modem_register.
The online/offline state is changed with the new set_online() modem driver
method.
In order to track atoms, there are modem states as follows:
- OFONO_MODEM_STATE_POWER_OFF
- OFONO_MODEM_STATE_PRE_SIM
- OFONO_MODEM_STATE_OFFLINE
- OFONO_MODEM_STATE_ONLINE
Atoms are added with driver methods pre_sim(), post_sim() and post_online().
Atoms are removed by modem core when the state changes.
Introduce two new methods
- pre_sim - SIM is not inserted or locked. This should populate
the modem with atoms that can be used without the SIM.
Generally this is the devinfo atom, the sim atom and the voice
call atom (emergency calls only)
- post_sim - SIM is ready. This method should populate the
modem with the remaining atoms
On Sun, 30 Aug 2009 13:45:45 -0500
Denis Kenzior <denkenz@gmail.com> wrote:
> Hi Andres,
>
> > static struct ofono_modem_driver g1_driver = {
> > .name = "HTC G1",
> > .probe = g1_probe,
> > .enable = g1_enable,
> > .disable = g1_disable,
> > .remove = g1_remove,
> > .populate = g1_populate,
> > };
> >
>
> So the current intention:
> .probe - Detect whether device is really supported by the plugin,
> initialize any data structures specific to the device
> .remove - Destroy data structures
> .enable - Perform power up
> .disable - Perform power down
> .populate - Populate the atoms supported by this device (e.g. netreg,
> voicecall, etc) This is called by the core after every power cycle,
> when the device is brought up.
>
Thanks! See patch below.
> >
> > Of course, I'm also wondering why there needs to be two separate
> > layers of calls in the first place. Why not have drivers register
> > everything from within probe, call ofono_set_powered(modem, TRUE)
> > once the device is ready, and be done with it?
>
> The reason for this is e.g. airplane mode, where you physically want
> to turn off the device. Another case is for battery / power reasons,
> e.g. a netbook with a USB modem that is not being used.
>
Fair enough. In the kernel, we have callbacks named suspend/resume
to handle that.
> > The only reason why this doesn't blow up in the generic_at plugin is
> > because the driver_data is leaked. If one were to free it from
> > generic_at_exit in the wrong place (since it's allocated from
> > generic_at_init, it would make sense to free it in generic_at_exit),
> > one would see the same SEGV/SIGBUS/SIGILL errors upon ctrl-c.
>
> So the leak has now been fixed.
>
> I think you're being unnecessarily harsh here. To be fair, the
> generic_at driver does something like this at init:
My criticism is simply w/ the naming. 'enable'/'disable' doesn't imply
anything about power. powerup/powerdown, poweron/poweroff,
suspend/resume would all imply power state changes (at least the latter
would be familiar to those who do kernel stuff). Having comments that
describe what the callbacks do would also work, though.
>From 80a7b54d52201dfd7d8b590457450ae0a4f72888 Mon Sep 17 00:00:00 2001
From: Andres Salomon <dilinger@collabora.co.uk>
Date: Sun, 30 Aug 2009 15:56:16 -0400
Subject: [PATCH] Add comments to ofono_modem_driver struct
Document what all the callbacks do.
The modem info ops (Serial, Manufacturer, etc) are broken into a
separate oFono atom. This is mainly to support a proper modem device
driver infrastructure. As a result the data structures have been
tweaked a little.
driver.h is now empty and has been removed.
Giacinto Cifelli
Slava Monich
Denis Kenzior
Marcel Holtmann
Daniel Wagner
Jeevaka Badrappan
Gustavo F. Padovan
Pekka Pessi
Denis Kenzior
Andres Salomon