Commit Graph

86 Commits

Author SHA1 Message Date
Marcel Holtmann 37be9d1026 call-forwarding: Increase string buffer to avoid overflow 2019-10-31 08:39:18 +01:00
Philippe Nunes 1bb7222d83 call-forwarding: SS query is made with given cls
GCF test cases 31.2.1.6.1/2 are asking to make a query according a
specific class. The default class is applied in the query form when
no class is specified in the SS code.
2012-09-05 15:00:14 -05:00
Philippe Nunes 666da0ea53 call-forwarding: improve error reporting
Report error based on the error reported by the driver.
2012-08-22 18:16:15 -05:00
Philippe Nunes 308e99dc19 call-forwarding: Return specific errors for SS 2012-05-30 09:05:57 -05:00
Lucas De Marchi e0d6f9f0ce Do not set signature and reply in GDBus tables
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
2012-05-20 02:47:57 -07:00
Lucas De Marchi b3489f2ee8 Convert GDBus methods to use macro helpers
With these macro helpers we can separate in/out arguments and use their
own vector.
2012-05-20 02:47:57 -07:00
Henrique Dante de Almeida 924ee02ff7 Constify GDBus signal tables
Constify signal tables with the following command:

    find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Henrique Dante de Almeida 63bbdebdf2 Constify GDBus method tables
Constify method tables with the following command:

find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Oleg Zhurakivskyy aa8e11bed6 call-forwarding: Remove unneeded variable 2012-04-23 15:39:35 -05:00
Oleg Zhurakivskyy 6356612822 call-forwarding: Streamline set_query_cf_callback() 2012-04-23 15:39:27 -05:00
Oleg Zhurakivskyy 9d8aa928b8 call-forwarding: Refactor cf_find_unconditional() 2012-04-23 15:35:22 -05:00
Oleg Zhurakivskyy d797a868c0 call-forwarding: Streamline cf_find_timeout() logic 2012-04-23 15:33:44 -05:00
Oleg Zhurakivskyy e67a7fb913 call-forwarding: Get rid of extra variable 2012-04-23 15:32:12 -05:00
Denis Kenzior bed9f4e09b call-forwarding: Make cf_cond_find more readable 2012-04-23 15:31:29 -05:00
Oleg Zhurakivskyy e53723e3c6 call-forwarding: Refactor cf_condition_find_with_cls() 2012-04-23 15:27:47 -05:00
Oleg Zhurakivskyy 9b37eefdb7 call-forwarding: Refactor cf_condition_compare() 2012-04-23 15:21:17 -05:00
Oleg Zhurakivskyy 65898b34b8 call-forwarding: Inline get_query_next_cf_cond() 2012-03-19 13:33:41 -05:00
Oleg Zhurakivskyy 021b2145d4 call-forwarding: Remove cf_list_clear()
Use g_slist_free_full() instead.
2012-03-19 13:33:10 -05:00
Denis Kenzior 8b3c9e38a5 call-forwarding: Fix various style issues 2012-02-22 07:17:27 -06:00
Oleg Zhurakivskyy a5372acb1a call-forwarding: Minor code refactoring 2012-02-22 07:05:14 -06:00
Oleg Zhurakivskyy 69453afe9e call-forwarding: Emit signals when cfu is toggled
Emit signals to mask/unmask conditional cfs on cfu
activation/deactivation.
2012-02-22 06:56:58 -06:00
Oleg Zhurakivskyy 0dc3515af4 call-forwarding: Update conditional reporting logic
Don't report conditional cfs when cfu is active
2012-02-22 04:52:14 -06:00
Oleg Zhurakivskyy e4488eef1a call-forwarding: Update conditional setting logic
Due to how the quiescent behavior of conditional call forwarding rules
when CFU is active, do not allow the user to try and set conditional
rules.  This will fail at the network level anyway.
2012-02-22 04:29:16 -06:00
Oleg Zhurakivskyy 12076487aa call-forwarding: Refactoring of is_cfu_enabled()
This also removes the need for uninitialized_var() macro.
2012-02-22 04:24:18 -06:00
Oleg Zhurakivskyy 07adce67e0 call-forwarding: Minor style fixes 2012-02-22 04:23:50 -06:00
Denis Kenzior 2ad5db2e99 call-forwarding: Use __ofono_atom_find 2012-01-18 12:21:36 -06:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Bertrand Aygon f35f985235 call-forwarding: Fix uninitialized var warning
Fix a gcc 4.5.2 warning uninit var
2011-05-05 21:18:39 -05:00
Denis Kenzior 9464dc32b4 call-forwarding: Move to avoid forward-decl 2011-04-05 00:07:43 -05:00
Denis Kenzior ee5282aac9 call-forwarding: Remove unneeded forward-decl 2011-04-05 00:06:29 -05:00
Denis Kenzior f31298666b call-forwarding: Fix typo 2011-04-05 00:05:10 -05:00
Andrzej Zaborowski c57d6049bf call-forwarding: Reregister on EF-CFIS refresh 2011-04-05 00:05:04 -05:00
Mika Liljeberg 0eedf42921 core: remove redundant code 2011-03-30 12:33:54 -05:00
Denis Kenzior c8b5143a03 call-forwarding: Don't update from sim if cached
If we have already cached the settings, then there's no need to update
them from the SIM, even if a SIM refresh was performed.
2011-03-15 21:22:35 -05:00
Andrzej Zaborowski 643144aafb call-forwarding: update EFs changed by SIM refresh 2011-03-15 21:18:17 -05:00
Denis Kenzior 3f798c4741 core: Minor style tweaks 2011-02-03 13:15:29 -06:00
Andrzej Zaborowski a7a0cb1ed0 simfs: implement ofono_sim_context api 2011-02-03 13:13:37 -06:00
Aki Niemi 9be348714d call-forwarding: Remove useless curly brackets 2011-02-02 11:03:21 +02:00
Denis Kenzior 30c19a915e call-forwarding: Properly signal changes
For the ForwardingFlagOnSim property
2010-12-17 17:01:59 -06:00
Denis Kenzior 183624f870 call-forwarding: Get rid of status_on_sim variable 2010-12-17 16:50:33 -06:00
Denis Kenzior 212b291e15 call-forwarding: Simplify sim_set_cf_indicator 2010-12-17 16:40:32 -06:00
Denis Kenzior 424b2f8eb9 call-forwarding: More style fixes 2010-12-17 16:30:43 -06:00
Denis Kenzior 5a9fbb912e call-forwarding: Use a flag instead of a boolean
For storing the presence of CPHS CFF file
2010-12-17 16:11:29 -06:00
Denis Kenzior 88d499d96e call-forwarding: Get rid of cfis_indicator
There's no need to track this information, since if we pick a record
with cfis_indicator for something besides Voice only, then when we
set the record again, the number we set is no longer applicable to
those services.
2010-12-17 16:08:27 -06:00
Denis Kenzior f0d8ae9135 call-forwarding: Minor style fixes 2010-12-17 16:08:24 -06:00
Denis Kenzior 8b848e2b7e call-forwarding: Get rid of unneeded variable 2010-12-17 12:51:18 -06:00
Jeevaka Badrappan 8f8ae1b62f call-forwarding: Read/Write cfis/cphs-cff 2010-12-17 12:23:37 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Jeevaka Badrappan 175ac85942 call-forwarding: skip property change data and fax 2010-11-24 15:54:46 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00