Commit Graph

55 Commits

Author SHA1 Message Date
John Ernberg f987e0b311 cbs: use g_slist_free_full 2016-04-22 15:27:28 -05:00
John Ernberg e43a006c7b cbs: Resolve a use-after-free
In situations where location changes rapidly, a use-after-free condition
can occur.  What happens is that the timeout leaks and then the cbs
struct with the callback is cleaned up, resulting in a SIGSEGV when the
callback occurs from the glib loop.
2015-12-21 17:53:43 -06:00
Lucas De Marchi e0d6f9f0ce Do not set signature and reply in GDBus tables
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
2012-05-20 02:47:57 -07:00
Lucas De Marchi b3489f2ee8 Convert GDBus methods to use macro helpers
With these macro helpers we can separate in/out arguments and use their
own vector.
2012-05-20 02:47:57 -07:00
Henrique Dante de Almeida 924ee02ff7 Constify GDBus signal tables
Constify signal tables with the following command:

    find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Henrique Dante de Almeida 63bbdebdf2 Constify GDBus method tables
Constify method tables with the following command:

find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Denis Kenzior be914cd32a cbs: finding SIM atom seems to not necessary now 2012-01-18 12:52:01 -06:00
Denis Kenzior dc93f5dbe0 cbs: Use __ofono_atom_find macro 2012-01-18 12:21:33 -06:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Mika Liljeberg 0eedf42921 core: remove redundant code 2011-03-30 12:33:54 -05:00
Denis Kenzior 7f43fc0f69 cbs: Set topics on EFcbmid change only if powered 2011-02-17 15:09:17 -06:00
Andrzej Zaborowski 9e640a246a cbs: Watch for changes to relevant SIM files 2011-02-17 15:09:17 -06:00
Denis Kenzior e0d777a655 core: free GError objects returned by glib 2011-02-08 16:48:52 -06:00
Denis Kenzior 3f798c4741 core: Minor style tweaks 2011-02-03 13:15:29 -06:00
Andrzej Zaborowski a7a0cb1ed0 simfs: implement ofono_sim_context api 2011-02-03 13:13:37 -06:00
Aki Niemi 1af43cf7f0 cbs: Fix style issues 2011-02-02 11:03:21 +02:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00
Denis Kenzior c18e01be16 cbs: Minor style fixes 2010-11-10 09:15:51 -06:00
Andrzej Zaborowski 32e4eae814 cbs: CBS-PP download must be enabled in sst / est 2010-11-10 09:10:48 -06:00
Jeevaka Badrappan 4196182770 Fix multi-line comment style issues 2010-09-21 21:16:01 -05:00
Marcel Holtmann aa99c4c0dd Rename CbsManger into CellBroadcast
Other D-Bus interfaces use clear descriptions like SupplementaryServices
or NetworkRegistration. So use CellBroadcast for cell broadcast support.
2010-06-09 20:07:11 -07:00
Andrzej Zaborowski 569c252e48 Fix: download CBS to SIM even when "Powered" is 0 2010-06-09 12:27:24 -05:00
Andrzej Zaborowski 7e5ef25c5a stk: Use envelope encoding utility from stkutil.c 2010-06-09 12:26:32 -05:00
Denis Kenzior 06ecf0e7f5 cbs: Send ETWS topics last 2010-06-07 15:08:58 -05:00
Denis Kenzior ee74f53160 Fix: Look for the STK atom, not SIM atom 2010-04-15 16:49:41 -05:00
Denis Kenzior 8f00272563 Fix: Process CBS sim downloads if STK atom exists 2010-04-15 16:49:41 -05:00
Andrzej Zaborowski aad4d0de78 Add Sim Toolkit atom
- Add ofono_stk atom in stk.c
- Move envelope command from sim driver to stk driver
2010-04-15 16:49:40 -05:00
Andrzej Zaborowski 22cbe98146 Extend sim-ready watch with card insert/eject 2010-04-15 16:49:40 -05:00
Denis Kenzior 0e09221ea5 Move cbs interface definition to dbus.h 2010-03-22 15:36:04 -05:00
Denis Kenzior 87ca1b0c8f Fix: Don't use ofono_debug directly in the core
Use DBG macro which is integrated with the new debug framework.
2010-02-08 11:54:03 -06:00
Denis Kenzior 675ef623c7 Fix: Process CBS settings even if no EFcbmid
If EFcbmid is not present, corrupt or empty the code that bootstraps the
CBS settings is never called.
2010-01-20 21:35:33 -06:00
Denis Kenzior 03fd69ace9 Fix: Print errors for unlikely CBS failures
These indicate driver / hardware issues rather than anything else.
2010-01-20 21:34:19 -06:00
Denis Kenzior ea6ab1ea2b Fix: NULL check both set_topics and clear_topics 2010-01-20 21:08:52 -06:00
Denis Kenzior 11de395af9 Fix: Make the powered setting actually work 2010-01-20 21:03:17 -06:00
Denis Kenzior e829727224 Fix: Default to powered=true for CBS 2010-01-20 10:26:02 -06:00
Andrzej Zaborowski 6c1a997902 Persist CBS Topics list, handle EF-CBMI, EF-CBMIR.
The two SIM files are only used to bootstrap the topics list value
if there's no previous value.
2010-01-12 18:03:34 -06:00
Denis Kenzior 9bed04ca2f Style: Trailing whitespace & extra lines 2010-01-12 17:54:37 -06:00
Marcel Holtmann 144080e749 Update copyright information 2010-01-01 17:00:10 -08:00
Denis Kenzior 7ffd9cb8e8 Style: Flip the if statement
The if case should have the multiple expressions
2009-12-17 21:45:39 -06:00
Denis Kenzior 3b9b6201c1 Style: Add empty lines where needed 2009-12-17 21:45:39 -06:00
Andrzej Zaborowski 8365fc1206 Add Powered property to CbsManager. 2009-12-17 21:45:39 -06:00
Andrzej Zaborowski da6f3e63e0 Handle EF-CBSMID contents. 2009-12-17 21:45:39 -06:00
Denis Kenzior fd6d9f9fc7 Fix: Don't pass ofono_network_operator structures 2009-10-29 15:28:26 -05:00
Denis Kenzior 24d8a5722b Refactor: replace netreg get_operator with mcc/mnc
The full operator information is useless as only mcc/mnc are really
required.  The internal structures will be changing soon
2009-10-27 19:47:52 -05:00
Denis Kenzior 6f9b5be3d5 Fix: Reset netreg to 0 when unregistered 2009-10-26 16:18:17 -05:00
Denis Kenzior be55ba4ab3 Refactor: Move elementary file type checking
Every single EF read callback checks the file type reported out of the
SIM is what it expects.  Instead this should be done in one place and
the errors reported accordingly
2009-10-02 18:25:56 -05:00
Denis Kenzior 26f15e30a8 Assume CBS is registered when SIM ready 2009-09-17 11:53:19 -05:00
Denis Kenzior 971ef1c305 Add reading of various CBS related EFs
- EFcbmi - Cell Broadcast Identifiers
- EFcbmir - Cell Broadcast Identifier Ranges
- EFcbmid - Cell Broadcast Identifiers for Data Download
2009-09-16 17:09:58 -05:00
Denis Kenzior b83c7acfc9 Fix: do not leak memory, cleanup the topic list 2009-09-16 04:53:41 -05:00