sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity
8,869 Commits 12 Branches 0 Tags 8.9 MiB
Commit Graph

36 Commits

Author SHA1 Message Date
Antara Borwankar 0c2f2815ca radio-settings: handling of dual mode technology preference 
Handled two new dual mode technology preferences
"umts,gsm" and "lte,umts".
 2019-05-16 10:40:45 -05:00
John Ernberg 8ad77d5e10 radio-settings: Fix typo in radio_band_umts_from_string 2017-06-29 09:11:11 -05:00
Slava Monich 00613b5bbc radio-settings: Fix memory leaks in radio_load_settings 
Errors returned by g_key_file_get_integer have to be deallocated
by the caller to avoid leaks like these:

==13330== 104 (24 direct, 80 indirect) bytes in 2 blocks are definitely lost
==13330==    at 0x483F3EC: malloc (vg_replace_malloc.c)
==13330==    by 0x4B020DF: g_malloc (gmem.c)
==13330==    by 0x4B17F51: g_slice_alloc (gslice.c)
==13330==    by 0x4AE80B9: g_error_new_valist (gerror.c)
==13330==    by 0x4AE830B: g_set_error (gerror.c)
==13330==    by 0x4AF5681: g_key_file_get_value (gkeyfile.c)
==13330==    by 0x4AF6817: g_key_file_get_integer (gkeyfile.c)
==13330==    by 0x10CFE3: radio_load_settings (radio-settings.c)
==13330==    by 0x10D2E3: ofono_radio_settings_register (radio-settings.c)
 2017-06-02 10:42:30 -05:00
Denis Kenzior 2859e0547c radio-settings: Fix style 2016-04-27 11:19:18 -05:00
Antara Borwankar d8b60d854c radio-settings: Init pending_band_{gsm|umts} 
The set_band method takes two parameters for band settings, one for gsm
and one for umts.  When loaded from storage, and they are not set to
defaults, the band variables can get out of sync when setting the
GsmBand and UmtsBand properties.
 2016-04-27 11:19:13 -05:00
Denis Kenzior f92b763da4 radio-settings: Fix 80-character limit 2016-04-26 08:13:42 -05:00
Antara Borwankar e8c4e0f4c1 radio-settings: Store GSM and UMTS band settings 2016-04-26 08:12:19 -05:00
Denis Kenzior b708f9f6b3 radio-settings: Fix potential leak 
rs->imsi is only freed when rs->settings is true.  So tweak the logic
inside radio_load_settings to only strdup the imsi when settings
creation has succeeded.
 2016-04-07 09:19:13 -05:00
Denis Kenzior 77a3c58148 radio-settings: Fix minor style issues 2016-04-07 09:15:22 -05:00
Anirudh Gargi 07dff1916d radio-settings: Add RAT mode to ofono storage 2016-04-07 09:13:28 -05:00
Denis Kenzior bb9a1954ea radio-settings: Implement get_modem() 2015-11-05 20:50:12 -06:00
Alfonso Sanchez-Beato 10f173981c radio-settings: Show all available technologies 
Not all possible futures technologies were being showed on the DBus
interface.
 2014-12-12 08:54:14 -06:00
Denis Kenzior 95482cb84a radio-settings: Always query available rats 
If fast dormancy query is not implemented the available rats are not
queried.
 2014-12-10 11:03:16 -06:00
Denis Kenzior fce95b767a radio-settings: Add additional sanity check 2014-12-10 11:03:16 -06:00
Denis Kenzior 44049f064a radio-settings: rework AvailableTechnologies logic 
Take advantage of the new enum structure to future proof and simplify
the logic of generating the AvailableTechnologies property
 2014-12-10 11:03:16 -06:00
Alfonso Sanchez-Beato 5210b85c22 src: Implement RAT list property 2014-12-10 11:03:16 -06:00
Lucas De Marchi e0d6f9f0ce Do not set signature and reply in GDBus tables 
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
 2012-05-20 02:47:57 -07:00
Lucas De Marchi b3489f2ee8 Convert GDBus methods to use macro helpers 
With these macro helpers we can separate in/out arguments and use their
own vector.
 2012-05-20 02:47:57 -07:00
Henrique Dante de Almeida 924ee02ff7 Constify GDBus signal tables 
Constify signal tables with the following command:

    find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
 2012-05-20 02:47:56 -07:00
Henrique Dante de Almeida 63bbdebdf2 Constify GDBus method tables 
Constify method tables with the following command:

find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
 2012-05-20 02:47:56 -07:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Denis Kenzior e74e2c3739 radio-settings: Minor style fixes for rule M13 2010-12-08 11:55:07 -06:00
Denis Kenzior e23d25c895 radio-settings: Minor style issues 2010-12-08 11:35:44 -06:00
Lucas De Marchi cefa3b14dc radio-settings: add frequency band selection props 2010-12-08 11:32:15 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:27:15 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00
Denis Kenzior bef003059e radio-settings: Don't check for cached 
Checking for this flag does not have the desired effect, or rather it
has other side-effects (e.g. setting the property twice before
GetProperties).  oFono discourages spurious signal emission.
 2010-10-27 22:26:15 -05:00
Denis Kenzior 107f6ee731 radio-settings: Add extra newlines 
To be compliant with the coding style
 2010-10-27 22:26:15 -05:00
Mika Liljeberg a4983d99eb radio settings: add FastDormancy property 2010-10-27 22:26:15 -05:00
Aki Niemi 90ce04e0e1 radio settings: Fix string to enum mapping 2010-10-21 21:39:41 +03:00
Denis Kenzior 81bc8884b4 radio-settings: Get rid of unneeded casts 2010-10-20 17:59:21 -05:00
Denis Kenzior cbe433c9ee radio-settings: Fixup various style issues 2010-10-20 16:52:35 -05:00
Denis Kenzior 538cd6a1cb Refactor: Rename radio setting type names 2010-03-25 10:42:48 -05:00
Denis Kenzior 6425706c9d Move radio settings interface definition to dbus.h 2010-03-22 15:29:03 -05:00
Denis Kenzior 87ca1b0c8f Fix: Don't use ofono_debug directly in the core 
Use DBG macro which is integrated with the new debug framework.
 2010-02-08 11:54:03 -06:00
Aki Niemi 8d4004d182 Add radio settings atom and driver API 
This interface exposes a read-write property for radio access technology
selection mode.
 2010-02-04 23:43:18 +02:00