Commit Graph

168 Commits

Author SHA1 Message Date
Denis Kenzior 87932a536f stk: Fix potential buffer overrun 2019-04-29 19:24:19 -05:00
Denis Kenzior 9601ff5331 stkutil: Use standard types 2018-12-29 15:26:37 -06:00
Denis Kenzior c3d5ccbe53 stkutil: Use l_queue instead of GSList 2018-12-28 18:12:21 -06:00
Denis Kenzior 22002d142c stkutil: Use l_queue instead of GSList 2018-12-28 13:48:34 -06:00
Denis Kenzior 4927905db4 stkagent: Use bool instead of gboolean / ofono_bool_t 2018-12-28 13:47:41 -06:00
Denis Kenzior 1d08969613 stkutil: Convert stk_text_to_html to use ell 2018-12-27 18:18:51 -06:00
Jonas Bonn 3beeff758d treewide: Remove superfluous use of _GNU_SOURCE
There are a large number of files in the tree that define _GNU_SOURCE
despite not actually using features hidden behind this flag.  This patch
removes all these definitions in one fell swoop...
2018-10-17 10:01:57 -05:00
Slava Monich 0797b23c5d dbus: Use dbus_validate_path
Instead of __ofono_dbus_valid_object_path
2018-01-18 10:53:28 -06:00
Marcel Holtmann 38a6826228 stk: Add missing break statement for inkey duration 2017-07-11 10:44:53 -07:00
John Ernberg 65132868c8 stk: clean up undefined function pointer casts 2016-04-26 08:05:00 -05:00
Lucas De Marchi 874a9ee285 stk: Fix sizeof on memcpy
src/stk.c: In function ‘__ofono_cbs_sim_download’:
src/stk.c:283:45: error: argument to ‘sizeof’ in ‘memcpy’ call is the
same expression as the source; did you mean to dereference it?
[-Werror=sizeof-pointer-memaccess]
  memcpy(&e.cbs_pp_download.page, msg, sizeof(msg));
                                               ^
2013-05-22 21:37:52 -05:00
Denis Kenzior 7fca6fca90 stk: Fix crash with Modem-Handled SIM Refresh 2013-01-01 21:40:14 -06:00
Denis Kenzior e744f9159d Revert "stk: Fix crash in SIM refresh handling"
This reverts commit dfd1fae50b.
2013-01-01 21:03:23 -06:00
Denis Kenzior 1101465305 stk: Fix Set Up Call with pause characters
Set Up Call with extra DTMF characters after the phone number should be
set up with only the dialed number.  Otherwise we get a sequence like
this:
{VoiceCallManager} [CallAdded] /ifx_0/voicecall01 { LineIdentification =
+012340123456c1c2, Name = , Emergency = False, Multiparty = False,
RemoteHeld = False, State = alerting, RemoteMultiparty = False }
2012-11-28 10:31:15 -06:00
Denis Kenzior fb16241aba stk: Print what kind of info the SIM wants
In Provide Local Information implementation
2012-11-28 10:31:14 -06:00
Denis Kenzior b5d7fd8d38 stk: Handle self explanatory icons in idle mode text 2012-11-28 10:31:14 -06:00
Denis Kenzior 5afd6e1f5d stk: Handle icon self explanatory in play tone 2012-11-28 10:31:14 -06:00
Denis Kenzior 3e64381353 stk: Handle icon self explanatory in get input 2012-11-28 10:31:14 -06:00
Denis Kenzior ff6d81a67b stk: Handle icon self explanatory in get inkey 2012-11-28 10:31:14 -06:00
Denis Kenzior b2c287db75 stk: Handle icon self explanatory in display text 2012-11-28 10:31:14 -06:00
Denis Kenzior bc5645640c stk: Handle icon self explanatory in menus 2012-11-28 10:31:14 -06:00
Denis Kenzior dfd1fae50b stk: Fix crash in SIM refresh handling 2012-11-22 06:50:08 -06:00
Denis Kenzior 9d9ae3af28 stk: Always include IdleModeText in GetProperties 2012-11-22 06:50:08 -06:00
Denis Kenzior e98dcc0616 stk: Use the shorter timeout for select item 2012-11-22 06:50:08 -06:00
Denis Kenzior f39d7efb53 stk: use longer timeout for ImmediateResponse 2012-11-22 06:50:08 -06:00
Denis Kenzior 85c0e53013 stk: Use short timeout for get_inkey 2012-11-22 06:50:08 -06:00
Denis Kenzior b581f409ec stk: Use a shorter timeout for DisplayText
For any commands that are tagged as wait-for-user to clear, we should
use the shorter timeout.  The test system expects 25 to 35 seconds.
2012-11-22 06:50:08 -06:00
Denis Kenzior 9d223e7e39 stk: Tweak the concept of continuous tones
The spec explicitly mentions continuous or repeatable tones.  02.40 only
mentions the RP-ACK tone as a single tone, all other tones seem to be
repeatable
2012-10-31 16:14:27 -05:00
Philippe Nunes 94e35ff915 stk: AID shall not be displayed in certain cases
When the icon is marked as self explanatory, the AID should not be
displayed.
2012-09-17 11:25:15 -05:00
Philippe Nunes 23cdb46419 stk: move number conversion to a utility function
The dialing number provided by the Setup Call proactive command
may contain pause and DTMF characters.
2012-09-17 11:24:58 -05:00
Denis Kenzior 50d6f2c607 stk: Fix comment style 2012-08-30 17:01:36 -05:00
Philippe Nunes 0a9a566065 stk: Ask for immediate digit response as required
This is done by using the stk_agent_request_quick_digit function
introduced in the previous commit.
2012-08-30 16:55:36 -05:00
Philippe Nunes 3ac780fee7 stk: Check if an agent is registered when UI is required
In case of unsolicited proactive command, we could have a crash
when no agent was registered.
2012-08-30 16:47:20 -05:00
Philippe Nunes ec6269e59b stk: Display action information while sending USSD 2012-08-30 16:36:49 -05:00
Denis Kenzior 2b606f548c stk: Fix crash when envelope returns sync
ofonod[13066]: src/stk.c:stk_select_item()
ofonod[13066]: src/stk.c:stk_select_item()
ofonod[13066]: src/stk.c:stk_send_envelope()
ofonod[13066]: drivers/qmimodem/stk.c:qmi_envelope()
ofonod[13066]: src/stk.c:envelope_cb() length 0
ofonod[13066]: src/stk.c:menu_selection_envelope_cb()
ofonod[13066]: Sending Menu Selection to UICC failed
process 13066: arguments to dbus_message_new_error() were incorrect,
assertion "reply_to != NULL" failed in file dbus-message.c line 1333.
This is normally a bug in some application using the D-Bus library.
  D-Bus not built with -rdynamic so unable to print a backtrace
  ofonod[13066]: Aborting (signal 6) [./src/ofonod]
  ofonod[13066]: ++++++++ backtrace ++++++++
2012-06-16 23:22:04 -05:00
Lucas De Marchi e0d6f9f0ce Do not set signature and reply in GDBus tables
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
2012-05-20 02:47:57 -07:00
Lucas De Marchi b3489f2ee8 Convert GDBus methods to use macro helpers
With these macro helpers we can separate in/out arguments and use their
own vector.
2012-05-20 02:47:57 -07:00
Henrique Dante de Almeida 924ee02ff7 Constify GDBus signal tables
Constify signal tables with the following command:

    find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Henrique Dante de Almeida 63bbdebdf2 Constify GDBus method tables
Constify method tables with the following command:

find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Denis Kenzior d218070689 stk: find_atom only returns registered atoms
This seems to be an oversight from an earlier refactoring.
2012-01-18 12:58:20 -06:00
Denis Kenzior ae14a3056a stk: Use __ofono_atom_find 2012-01-18 12:50:55 -06:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Denis Kenzior c8131fb10e stk: Fix crashes 2011-08-14 22:56:45 -05:00
Denis Kenzior 968efe08ba stk: Fix missing break statement 2011-07-25 22:59:06 -05:00
Denis Kenzior 55279f16c2 stk: Make sure to set cancel_cmd
For handled commands, in case the terminal response is not reported by
the modem, we must set the cancel_cmd variable so the command is
canceled properly.

This patch also modifies the behavior so that pending_cmd is freed,
since stk_proactive_command_cancel expects cancel_cmd to be set if
pending_cmd is not NULL.
2011-07-25 22:45:55 -05:00
Denis Kenzior bb59d39539 stk: Remove code that does nothing 2011-07-25 22:25:05 -05:00
Denis Kenzior 0c42430f2b stk: Fix possible crash
We can't call stk_command_free on a NULL object
2011-07-25 22:21:46 -05:00
Jeevaka Badrappan f837bdc90a stk: Handle set up call in handled_notify 2011-07-25 21:44:55 -05:00
Jeevaka Badrappan 213d70dca3 stk: Fix crash seen in stk_alpha_id_unset
If there is no default agent, then current agent also will
be NULL. So, call stk_agent_request_cancel only when there is a valid
current agent.
2011-07-15 11:35:13 -05:00
Andrzej Zaborowski 045ac8cf94 stk: Use the right command pointer 2011-07-06 04:14:47 -05:00