Commit Graph

292 Commits

Author SHA1 Message Date
Denis Kenzior a63988a33f stkutil: Call va_end on failure 2019-04-29 14:34:00 -05:00
Denis Kenzior dbc314ebc4 stkutil: Fix ofono_bool_t usage
The actual datatype is bool
2019-01-18 08:55:52 -06:00
Denis Kenzior 9601ff5331 stkutil: Use standard types 2018-12-29 15:26:37 -06:00
Denis Kenzior 27c9952f86 stkutil: Convert away from glib datatypes 2018-12-29 14:14:51 -06:00
Denis Kenzior c3d5ccbe53 stkutil: Use l_queue instead of GSList 2018-12-28 18:12:21 -06:00
Denis Kenzior 22002d142c stkutil: Use l_queue instead of GSList 2018-12-28 13:48:34 -06:00
Denis Kenzior f7d8edeaac stkutil: Convert stk_image_to_xpm to ell 2018-12-27 18:18:51 -06:00
Denis Kenzior 1d08969613 stkutil: Convert stk_text_to_html to use ell 2018-12-27 18:18:51 -06:00
Denis Kenzior b66abb4902 stkutil: Use l_malloc 2018-12-27 18:18:51 -06:00
Denis Kenzior 4059d4226b util: Switch character conversions to ell
Switch various conversions from GSM/UCS2 to UTF8 from glib based
implementation over to ell.

This also converts all related g_free calls to l_free calls (though in
the end they are equivalent calls to free)
2018-12-27 18:18:51 -06:00
Denis Kenzior 9c7a87673a util: Use l_utf8_to_ucs2be instead of g_convert 2018-12-27 18:18:51 -06:00
Denis Kenzior 5229080d92 util: Use ell in convert_utf8_to_gsm 2018-12-27 18:18:51 -06:00
Denis Kenzior d5f117be80 util: Convert pack7_bit / unpack_7bit to use l_malloc 2018-12-27 18:18:51 -06:00
Denis Kenzior 70c70a67b0 util: Use bool instead of gboolean 2018-12-27 18:18:51 -06:00
Jonas Bonn ec3c6c67af stkutil: remove test for impossible condition
'string' is an array and therefore never NULL so this test always fails.
2018-10-29 13:59:19 -05:00
John Ernberg c9be86ce1a stkutil: Use g_slist_free_full 2016-04-22 15:35:27 -05:00
Denis Kenzior 3805cd91c7 stkutil: Make valgrind happy
==29809== Conditional jump or move depends on uninitialised value(s)
==29809==    at 0x4E826C: stk_file_iter_next (stkutil.c:212)
==29809==    by 0x4E8CF8: parse_dataobj_file_list (stkutil.c:635)
==29809==    by 0x4EBA29: parse_dataobj (stkutil.c:2410)
==29809==    by 0x4ECFB5: parse_refresh (stkutil.c:2971)
==29809==    by 0x4EECA3: parse_command_body (stkutil.c:3826)
==29809==    by 0x4EF0DF: stk_command_new_from_pdu (stkutil.c:3948)
==29809==    by 0x4D50DA: ofono_stk_proactive_command_handled_notify
(stk.c:2885)
2012-02-02 09:17:04 -06:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Marcel Holtmann 6a183627f5 stkutil: Fix alignment issue with building event list 2011-06-30 19:32:11 -07:00
Marcel Holtmann 263e554d53 stkutil: Add missing call to va_end() 2011-06-30 17:33:59 -07:00
Philippe Nunes 563fcc5fe9 stkutil: Send at least the data currently available 2011-05-08 23:30:10 -05:00
Denis Kenzior f58c3614aa stkutil: add one more sanity check 2011-03-31 14:00:49 -05:00
Denis Kenzior c79c3c0e54 stkutil: Minor style fixes 2011-03-31 14:00:26 -05:00
Philippe Nunes d147afd6fc stkutil: decoding & encoding for class e commands
Complete the TLV parsing/builder to support BIP commands
2011-03-31 13:43:29 -05:00
Philippe Nunes b2e3a47217 stkutil: Add typo/cleaning modifications 2011-03-30 19:36:09 -05:00
Andrzej Zaborowski 1a4299b8eb stk: fix issue with null data object
This will let the caller correctly detect NULL alpha id.
2011-03-11 14:39:58 -06:00
Jeevaka Badrappan 67d1ddc22a stkutil: add check for qualifier and browser id
Checks the valid qualifier and browser id values
applicable for launch browser proactive command
2011-01-20 10:00:15 -06:00
Denis Kenzior 0a2648c368 stkutil: Minor style fix 2011-01-05 10:36:31 -06:00
Jeevaka Badrappan b447c56457 stkutil: add missing text and icon check
As per the ETSI TS 102 223 section 6.5.4, If the terminal
receives an icon, and either an empty or no alpha identifier/text string
is given by the UICC, than the terminal shall reject the command
with general result "Command data not understood by terminal".
2011-01-05 10:05:44 -06:00
Jeevaka Badrappan 2411a506e3 stkutil: Allocate for empty string in text dataobj 2011-01-05 10:04:15 -06:00
Denis Kenzior 0faf44ecb6 stkutil: Add missing call to va_end in parser 2010-12-30 10:56:03 -06:00
Denis Kenzior 79be5afdc1 stkutil: Allow empty strings in for Text dataobj
Explicitly allow length = 1 (DCS) followed by zero characters.  This
seems to be explicitly allowed by the test specification (namely Get
Input 1.9.1A)
2010-12-10 12:13:06 -06:00
Guillaume Lucas 778302a1e5 stkutil: fix crash cause by null text string
According to 3GPP TS 31.124 a zero length for the text string
should be allowed. An empty string must be returned to the
user in this case.
2010-12-10 10:46:56 -06:00
Yang Gu f6b037661b smsutil: Make timezone an optional field 2010-12-08 07:53:30 -06:00
Lucas De Marchi d725e79682 stkutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:04:35 -06:00
Denis Kenzior cd281f4454 stkutil: Minor style fixes 2010-11-25 17:58:37 -06:00
Guillaume Lucas 9b690aad40 stkutil: Use sms_dcs_decode in decode_text
This is a much more pedantic version that can be used to
retrieve the text character set.
2010-11-25 17:57:26 -06:00
Jeevaka Badrappan 58b3d888c0 stkutil: coding style fixes - rule M6 2010-11-22 05:05:52 -06:00
Yang Gu 6394d5b442 stk: Support send ss response 2010-10-20 18:20:36 -05:00
Jeevaka Badrappan 4196182770 Fix multi-line comment style issues 2010-09-21 21:16:01 -05:00
Denis Kenzior a0d476281d stkutil: Don't include USSD text unless needed 2010-09-15 11:58:00 -05:00
Jeevaka Badrappan e6fbe5e75d stkutil: Add build_dataobj_ussd_text
for ussd specific 'Text' Data object handling
2010-09-10 15:21:20 -05:00
Denis Kenzior 3bf4209813 stkutil: Trivial style issue 2010-09-09 10:25:10 -05:00
Kristen Carlson Accardi f9cb5b37dd stkutil: convert img to xpm 2010-07-26 14:34:54 -05:00
Denis Kenzior e77ea33fd6 stkutil: Set black fore/back ground color 2010-07-13 15:36:00 -05:00
Kristen Carlson Accardi d10deb44f8 stkutil: display text attributes as html 2010-07-13 14:59:21 -05:00
Yang Gu 058d3d0cd4 Interpret "" Alpha Id as empty data object
There needs to be a way to distinguish between no alphaid and "empty
data object" because on some occasions they have different meanings.  In
the Call Control envelope, no Alpha Identifier means the terminal can
inform the user about the call being modified by SIM while empty data
object means no hint should be given.
2010-07-09 12:30:12 -05:00
Andrzej Zaborowski 6de5b7f5bb stkutil: Timer Value is conditional, not optional.
Make the parser check that the value is present when necessary,
so that stk.c doesn't have to check this.
2010-07-08 14:27:33 -05:00
Andrzej Zaborowski c451994139 sktutil: Use the Mandatory flag in parse_dataobj.
We need to look at the Mandatory flag and not at the Minimum flag
when parsing CTLVs.  The Minimum flag is important when encoding CTLVs
because CR bit is set according to it.
2010-07-08 14:27:33 -05:00
Andrzej Zaborowski 365183d5a0 stkutil: Move scaddr field to gsm_sms 2010-07-02 14:13:45 -05:00