Commit Graph

60 Commits

Author SHA1 Message Date
Denis Kenzior 0597b3501a atmodem: Do not re-parse CLIP / CNAP
These needs to be parsed once and not parsed unnecessarily once the
information has been recorded
2010-12-16 18:40:19 -06:00
Denis Kenzior a1bf26f15d atmodem: Set cnap validity to not provided 2010-12-16 18:40:19 -06:00
Gustavo F. Padovan f28f0b3dea atmodem: Add CNAP parsing to voicecall 2010-12-16 18:40:18 -06:00
Gustavo F. Padovan 5ca42255c5 atmodem: use macros for CLIP validity 2010-12-10 12:59:26 -06:00
Gustavo F. Padovan 169651314e atmodem: fix DBG message 2010-12-02 08:15:04 -06:00
Lucas De Marchi b82a7f8511 drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 11:37:09 -06:00
Andrzej Zaborowski 9e46e27932 atmodem: Delay return from send_dtmf
AT+VTS responds with an OK immediately, so add a wait in the driver
before returning so that core knows when the tone has finished.  Note
that some modems actually do wait against 27.007, and other modems
use a manufacturer specific AT command and the drivers will need to
handle accordingly.
2010-10-22 22:28:50 -05:00
Marcel Holtmann 4cacd3a76c atmodem: Send DTMF commands without quotes
The AT+VTS command takes a single character and should not use quotes.
2010-10-13 08:25:59 +03:00
Marcel Holtmann 590e154734 atmodem: Remove quirk for Huawei voice call support
The Huawei voice call support has its own driver now. So this quirk
is no longer needed.
2010-09-29 08:32:23 +09:00
Marcel Holtmann 6fbbd4ca3e atmodem: Some cleanups in voice call driver 2010-09-27 08:07:02 +09:00
Denis Kenzior 09c0ae8478 atmodem: Update comment 2010-09-24 00:18:40 -05:00
Lucas De Marchi 74125ff5d4 Fix common misspellings in drivers
Fix common misspellings by using the list available at
http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

From the list cited above, the substitution script found the following
misspellings:

subsidary(-ies)->subsidiary(-ies)
transfering->transferring
2010-09-14 16:00:16 +09:00
Marcel Holtmann a0fe9cbdbd atmodem: Add Huawei quirk for voice call handling 2010-09-04 23:44:30 +02:00
Denis Kenzior bdc8d02bc8 atmodem: Default to +CHUP to hangup_all 2010-08-20 16:15:11 -05:00
Marcel Holtmann a8d3e7433a atmodem: Remove useless NULL checks before g_free 2010-08-16 22:02:01 +02:00
Denis Kenzior ac524be99f atmodem: Use g_at_chat_clone 2010-08-12 16:40:40 -05:00
Sjur Brændeland dde0a4ccb5 voicecall: Rename hangup to hangup_active 2010-08-12 11:32:12 -05:00
Denis Kenzior c98b951fe6 Refactor: Remove atutil dump_response
No longer needed now that we have nice AT command tracing using
OFONO_AT_DEBUG=1
2010-02-08 12:28:23 -06:00
Denis Kenzior 7f9a9b0cdc Fix: Don't use ofono_debug directly in plugins 2010-02-08 12:09:01 -06:00
Denis Kenzior 1721f81fe9 Fix: Use snprintf instead of sprintf in atmodem 2010-02-05 11:59:24 -06:00
Denis Kenzior d3c2535fae Fix: Dead Assignments 2010-02-04 00:14:49 -06:00
Marcel Holtmann 144080e749 Update copyright information 2010-01-01 17:00:10 -08:00
Denis Kenzior 2297bc926d Style: Fix some remaining style issues in atmodem 2009-12-09 02:46:33 -06:00
Zhenhua Zhang 62df556f28 Fix release clcc_source when voicecall is removed
Release the timer to avoid invoking the callback function after
voicecall driver is removed.
2009-12-04 16:52:32 -06:00
Denis Kenzior 0fbaed38aa Refactor: Run CLCC when initializing
When voicecall atom is initialized, we should run a CLCC query to
populate our call list.  This also notifies the core of the new calls
2009-12-04 16:52:31 -06:00
Denis Kenzior 770586bfb7 Update atmodem voicecall driver to new world order 2009-12-04 16:52:31 -06:00
Denis Kenzior 7fa99301a0 Fix: Style 2009-12-04 16:52:31 -06:00
Denis Kenzior bfc9eb302f Fix: Ignore repeated CCWAs in atmodem as well 2009-11-16 10:17:12 -06:00
Denis Kenzior 1a8dd438b2 Make sure the atmodem handles ATD properly
The driver must set any existing active calls to held
2009-11-13 15:34:41 -06:00
Zhenhua Zhang 9b084e9656 Use at_util_parse_clcc in atmodem
Replace parse_clcc by at_util_parse_clcc in atmodem voicecall.
2009-11-12 11:23:05 -06:00
Denis Kenzior 95aafed445 Fix: Set data to NULL in drivers 2009-11-11 15:59:01 -06:00
Zhenhua Zhang 57aaf9813f Refactor: Move alloc/release id to atutil.c 2009-10-28 17:31:44 -05:00
Zhenhua Zhang 17903940c5 Refactor: Move & Rename functions to atutil.c
Move and rename call_compare and call_compare_by_status to atutil.c.
These will be utilized by other drivers, including hfpmodem.
2009-10-28 17:30:02 -05:00
Denis Kenzior 0faa8b3c42 Fix: Invalid call state transition
When an active and a waiting call exist, and the active is released the
waiting call becomes incoming.  This wasn't properly handled by the
generic at driver.
2009-10-23 13:56:26 -05:00
Denis Kenzior 3362de0010 Move SSN unsolicited notification activation 2009-09-22 00:07:06 -05:00
Denis Kenzior cbb36acee8 Rework DECLARE_FAILURE to be a bit nicer 2009-09-11 12:39:56 -05:00
Denis Kenzior 4c5791a500 Rename at.h to atmodem.h 2009-09-04 20:37:49 -05:00
Denis Kenzior a613105f91 Rename generic_at drivers to atmodem
Be more consistent with directory naming
2009-09-01 22:33:05 -05:00
Denis Kenzior 9caa606bcc Make remove functions not return anything 2009-09-01 22:27:08 -05:00
Denis Kenzior 422df0edfb change int vendor to unsigned int vendor 2009-09-01 21:39:02 -05:00
Denis Kenzior 4064f4ba73 Add vendor flag capability to voicecalls 2009-09-01 18:14:59 -05:00
Denis Kenzior 8c92e3dd18 Remove modem member from cb_data 2009-08-19 18:35:08 -05:00
Denis Kenzior e8e6d519fe Fix release specific not reporting proper reason
The proper disconnect reason was not being reported in the at modem
voicecall plugin
2009-08-19 18:35:08 -05:00
Denis Kenzior c5bee0bb6b Remove poll_clcc variable
The reference implementation will always poll.  If a modem vendor has
extensions for call status reporting, then those should be used in a
separate driver
2009-08-19 18:35:08 -05:00
Denis Kenzior 261c31de1c Update the AT modem voicecall driver for new API 2009-08-19 18:35:08 -05:00
Denis Kenzior 73bba4b83b Remove dead code in voicecall at driver 2009-08-19 18:35:08 -05:00
Denis Kenzior 67aa564adb Update the AT modem SSN driver to the new API 2009-08-14 18:51:36 -05:00
Denis Kenzior cb75833fc8 Rename ofono_modem_userdata 2009-07-29 16:44:16 -05:00
Denis Kenzior 74bbdea02d Preserve clip_validity
CLCC does not report clip_validity.  So if clip_validity of witheld
has been reported in CLIP, but we're still somehow polling CLCC,
which happens if CRING is not supported, and RING is used instead,
this fact can be lost.  Make sure we preserve clip_validity if
possible
2009-06-25 11:45:29 -05:00
Denis Kenzior 4357f33d25 Number and Number Type are optional in CLCC
According to 27.007, the number and number type are optional.  We must
take care not to do anything unexpected in this case.
2009-06-25 11:45:29 -05:00