Petteri Tikander
295ae2dc04
smsutil: style fix
2010-09-01 12:09:19 -05:00
Petteri Tikander
c7473aa7da
smsutil: use DECLARE_SMS_ADDR_STR
...
in sms_assembly_backup_free
2010-09-01 12:07:28 -05:00
Denis Kenzior
e38064a66d
smsutil: Get rid of pointless member
2010-08-17 12:36:26 -05:00
Inaky Perez-Gonzalez
4421b5b912
sms: document use_delivery_reports
...
In function sms_text_prepare
2010-07-23 18:00:10 -05:00
Inaky Perez-Gonzalez
9517bf2991
sms: sms_assembly_encode_address export and rename
...
The new name better reflects the function's purpose.
We need to export it, as for generating unique message naming (for
persistence and D-Bus object naming), we'll be using the
address.
2010-07-23 17:28:18 -05:00
Inaky Perez-Gonzalez
ca46f51c2d
introduce DECLARE_SMS_ADDR_STR()
...
Introduce DECLARE_SMS_ADDR_STR(), which declares a string variable of
the right size for passing to sms_assembly_decode_address(). This way
we detach each client having to have the knowledge of what the right
size is, leaving that decission to the infrastructure
provider. Updated couple of sites in smsutil.c to use it vs a raw
declaration.
2010-07-23 17:26:12 -05:00
Denis Kenzior
e6d6f802a5
smsutil: Fix valgrind complaint
...
SMS cannot be split over GSM extension chars, however on the last
segment this code was causing us to overflow the buffer and resulted in
valgrind complaining.
2010-07-08 14:27:33 -05:00
Denis Kenzior
6bae7a2aa1
smsutil: Fix up some comment style
2010-06-21 15:33:13 -05:00
Denis Kenzior
5aa8841440
smsutil: Take ton_npi into account in sr assembly
2010-06-21 15:21:40 -05:00
Denis Kenzior
36bcae5ff1
smsutil: More code cleanup
...
- Change the flow of the code a bit, in the case that all fragments have
been sent and an udelivered sr arrives, we can simply remove the node
and signal undelivered up
- We ignore temporary and temporary final status reports
2010-06-21 15:21:40 -05:00
Denis Kenzior
cbc27e06b3
smsutil: Make code flow easier to understand
2010-06-21 15:21:40 -05:00
Denis Kenzior
a8bd87cda9
smsutil: multiline comments to preferred style
2010-06-21 15:21:40 -05:00
Denis Kenzior
65b8cab616
smsutil: Minor code style & indentation fixes
2010-06-21 15:21:39 -05:00
Denis Kenzior
d7dacd2fad
smsutil: memcpy is preferable to struct assignment
2010-06-21 15:21:39 -05:00
Denis Kenzior
c967766070
smsutil: Streamline flow of sr add_fragment
2010-06-21 15:21:39 -05:00
Pasi Miettinen
a7372209f3
smsutil: Status report assembly
2010-06-21 10:52:27 -05:00
Yang Gu
179c14fe39
smsutil: Add a decoder for ussd pdus
2010-06-18 13:18:12 -05:00
Pasi Miettinen
475c0de92c
smsutil: Add option to use delivery reports
2010-06-07 13:00:46 -05:00
Denis Kenzior
69e5a65d34
smsutil: status reports also lead with SC_ADDR
2010-06-04 14:21:57 -05:00
Denis Kenzior
4638d3ad83
smsutil: Don't overflow signed ints
...
We were overflowing the datatype which was causing the 31st segments to
be prepended at position 0. This resulted in (very) long messages being
improperly concatenated
2010-06-01 10:07:18 -05:00
Inaky Perez-Gonzalez
9c107821ab
smsutils: add some documentation
...
sms_assembly_add_fragment_backup: clarify how insertion spot is found
2010-05-28 09:23:35 -05:00
Denis Kenzior
9bb7bcd450
smsutil: add sms_decode_unpacked_stk_pdu function
...
Properly check the special 'packing required' sms pdus sent by SIM
toolkit.
2010-05-27 09:25:48 -05:00
Yang Gu
a9cd641855
smsutil: Check that udl is less than 140
2010-05-27 07:21:28 -05:00
Denis Kenzior
b0cf35c324
simutil: Add sim_encode_bcd_number
2010-05-26 09:59:14 -05:00
Denis Kenzior
795f0f3406
smsutil: Update the doc for extract_bcd_number
2010-05-26 09:17:25 -05:00
Andrzej Zaborowski
ff67ee8a2e
smsutil: Expose SMS timestamp encoding utility
...
The function can be re-used in stkutil.c, similarly to sms_decode_scts.
2010-05-25 16:52:54 -05:00
Yang Gu
b20e0d2bf5
Make function decode_scts public
2010-04-02 11:00:56 -05:00
Yang Gu
8bc04ba93a
Refactor: Break out semi-octet decoder
...
Refactor decode_scts to use this function
2010-04-02 10:58:53 -05:00
Denis Kenzior
ad5b2fd26f
Fix: Unnecessary initializations
2010-02-04 00:24:14 -06:00
Denis Kenzior
08b26238c1
Fix: missing break statement
2010-02-04 00:05:57 -06:00
Denis Kenzior
fa433a6acc
Fix: Check for \r in UCS2 alphabets
2010-02-03 23:28:41 -06:00
Marcel Holtmann
144080e749
Update copyright information
2010-01-01 17:00:10 -08:00
Denis Kenzior
955e6a61ee
Style: Fix a few more occurences of if/else
...
See Linux coding style document for details
2009-12-17 21:45:39 -06:00
Andrzej Zaborowski
a964411180
Add utility for checking if CBS topic is in range
2009-12-17 21:45:38 -06:00
Denis Kenzior
1fb5d7191e
Rename sms assembly path to sms_assembly from sms
...
Not to interfere with sms settings storage
2009-11-05 16:42:15 -06:00
Denis Kenzior
eb2c60469c
Fix: Don't return NULL if message is empty
...
Empty SMS messages are in sms_decode_text are returned as NULL, e.g.
error. This shouldn't be the case, empty messages should be reported
and signaled.
2009-10-16 13:19:11 -05:00
Andrzej Zaborowski
30b86c1dda
Fix: Skip over empty messages
2009-10-16 11:50:42 -05:00
Denis Kenzior
9f9327e1e5
Fix: Quiet a warning on some compilers
2009-10-15 16:15:18 -05:00
Denis Kenzior
9ab5eba1da
Fix: Handle empty SMSes
...
If an SMS is empty (e.g. nothing to unpack) then we should simply
continue on.
2009-10-02 19:26:11 -05:00
Denis Kenzior
e2a4c4bee8
Use existing function for converting to iso639
2009-09-17 11:53:37 -05:00
Denis Kenzior
40ef883fe4
Add ability to expire PLMN wide messages
2009-09-10 17:40:16 -05:00
Denis Kenzior
2ade0f6b05
Handle empty topic range lists
2009-09-10 16:13:16 -05:00
Denis Kenzior
c559aa42f6
Make cbs_topic_ranges_to_string work with all ids
2009-09-10 16:13:16 -05:00
Denis Kenzior
52d3c235d5
Add CBS topic range functions
2009-09-10 16:13:15 -05:00
Denis Kenzior
1acf350190
Fix make distcheck
2009-09-08 16:52:12 -05:00
Denis Kenzior
3449b2c0b5
Rework SMS fragment backup storage
...
The SMS address can actually contain other characters than 0-9, +, *, #,
particularly when the alphanumeric address type is used. This is
commonly used by services such as Google or carrier specific SMS
services.
Rework the SMS address storage to simply re-use the SMS address pdu
format, which consists of up to 12 hex-encoded bytes.
2009-09-08 16:40:56 -05:00
Denis Kenzior
47bcf1ac18
Fix style issue
2009-09-08 16:40:38 -05:00
Denis Kenzior
785686ec6b
Fix off by one error in assembly serialize
...
The proper PDU was not being written out fully
2009-09-08 16:39:16 -05:00
Andrzej Zaborowski
06ea6137a3
Write state of SMS assembly to disk and restore on startup.
...
This way we can continue receiving segmented messages over a reset or
crash.
2009-09-08 14:44:39 -05:00
Denis Kenzior
b2bde46bfb
Do supported dialect detection in sms.c
2009-09-08 12:45:04 -05:00